Re: Issue 131459 in chromium: FR: allow users to pin files offline from 'tile view'

[chro...@googlecode.com]

Updates:
Owner: kenmo...@chromium.org
Labels: Mstone-21 strings

Comment #2 on issue 131459 by joshwood...@chromium.org: FR: allow users to
pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

Good catch.

@kenmoore - What do you think about a context menu option - call it "Make
available offline" - for this?

[chro...@googlecode.com]

Comment #6 on issue 131459 by kaznach...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

The "Make available offline" string is already in. Interestingly enough it
has been urgently added before the M21 branch cut:)

[chro...@googlecode.com]

Updates:
Owner: zvory...@chromium.org
Labels: -Pri-2 Pri-1

Comment #8 on issue 131459 by joshwood...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

@zvorygin - Can you please add the context menu item in thumbnail view for
this? It should simply say, "Make available offline"

Thanks!

[chro...@googlecode.com]

Updates:
Labels: -strings

Comment #9 on issue 131459 by kaznach...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Status: Started

Comment #11 on issue 131459 by o...@chromium.org: FR: allow users to pin

[chro...@googlecode.com]

Updates:
Status: Started
Labels: -Mstone-22 Mstone-23

Comment #13 on issue 131459 by o...@chromium.org: FR: allow users to pin

files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

We do not have a string for a reverse operation, so I guess we can't make
it in M22. Moving to M23.

[chro...@googlecode.com]

Updates:
Labels: stirngs

Comment #14 on issue 131459 by joshwood...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

After looking at this a bit more in Drive mobile, I think we should do this:

Have an entry in the context menu that simply says "Available offline", and
the user can either check it or not check it.

If checked, we show the checkmark in the context menu in tile view only.
If unchecked, the file is not pinned and we're good.

Given that we have the string "Make available offline", could we use that
for this and move this bug back to M22?

[chro...@googlecode.com]

Comment #15 on issue 131459 by o...@chromium.org: FR: allow users to pin

files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

Actully, we have a string "Available offline" for column header.

I also like the idea of having a checkbox in the context menu — it seems
natural, though I would consult with Ken first, because it will change how
context menu look and make it significantly wider. Also there's a question
of what to show in case several files are selected with different offline
status. I think, that context menu item for making files offline is very
useful for treating a bunch of files at once, so we should give a thought
to this use case. Maybe add a grey pin there and make it either dark, or
remove it when clicked?

In any case, I've spent half a day on this bug and I do not feel that it's
easy enough to rush it into M22, even if we had the UX decisions. There are
also some issues with how FileManager handles pinned files and I can easily
end up with 100-200 lines of code, especially considering the checkbox in
context menu, which is not trivial.

Another thing to consider is that I am going on vacations starting next
week. If you want this feature badly in M22, I suggest to reassign it to
Dmitry Gozman, who worked with much of the code on which it is dependent. I
can pass him my current CL.

[chro...@googlecode.com]

Comment #16 on issue 131459 by joshwood...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

Ken is out on paternity leave for another 3-5 weeks. :/

* I think we should go ahead and add the checkmark. Logic: there is a
convention for doing this with apps in the apps list and launcher. You can
set them to Open as a tab, Open as a window, etc.

* For multiple file selection and pining, I think we should punt on the
issue for now. For the purposes of this bug, I vote we just grey it out in
the UI - similar to what we do when we can't perform a cut, copy, or paste
operation for example. [Btw, our first focus on pinning multiple files is
to pin directories, Issue 127831. Once we get that, we can define the UX
for pinning multiple files like this.]

* Like you suggest, let's keep this targeted at M23.

Thanks!

[chro...@googlecode.com]

Updates:
Blockedon: chromium:131198

Comment #17 on issue 131459 by o...@chromium.org: FR: allow users to pin

files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

[chro...@googlecode.com]

Updates:
Status: Assigned

Comment #18 on issue 131459 by o...@chromium.org: FR: allow users to pin

[chro...@googlecode.com]

Updates:
Labels: -Mstone-23 Mstone-24

Comment #19 on issue 131459 by o...@chromium.org: FR: allow users to pin

files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

As the blocking bug was moved to M24, I am moving this one too.

[chro...@googlecode.com]

Updates:
Cc: -joshwood...@chromium.org
Labels: -Mstone-24 Mstone-25

Comment #20 on issue 131459 by joshwood...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

Blocking bug has started to land, but it is too late to do much with this
before the M24 branch. Thus, moving to M25.

[chro...@googlecode.com]

Updates:
Owner: zvory...@chromium.org
Labels: iteration-69

Comment #21 on issue 131459 by joshwood...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

Assigning to @zvorygin since @olege is working on a new project. I talked
to @mtomasz yesterday, and he is actively working on the blocking bug so
this one should free up soon.

[chro...@googlecode.com]

Updates:
Owner: dgo...@chromium.org

Comment #23 on issue 131459 by zvory...@chromium.org: FR: allow users to

pin files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

[chro...@googlecode.com]

Updates:
Status: Started
Blockedon: -chromium:131198

Comment #24 on issue 131459 by dgo...@chromium.org: FR: allow users to pin

[chro...@googlecode.com]

Comment #25 on issue 131459 by bugdro...@chromium.org: FR: allow users to

pin files offline from 'tile view'

http://code.google.com/p/chromium/issues/detail?id=131459#c25

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=169339

------------------------------------------------------------------------
r169339 | dgo...@chromium.org | 2012-11-23T15:02:45.260193Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/main.html?r1=169339&r2=169338&pathrev=169339
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/css/file_manager.css?r1=169339&r2=169338&pathrev=169339
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=169339&r2=169338&pathrev=169339
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/js/file_manager_commands.js?r1=169339&r2=169338&pathrev=169339

[filemanager] Context menu command to pin/unpin file on Drive.

BUG=131459
TEST=See bug.

Review URL: https://chromiumcodereview.appspot.com/11414140
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #26 on issue 131459 by dgo...@chromium.org: FR: allow users to pin

files offline from 'tile view'
http://code.google.com/p/chromium/issues/detail?id=131459

Single-file context menu item added.
Please file a separate bug when you come up with multiple-file design.