Issue 582964 in chromium: Password save bubble disappears too fast on skype.com

[chro...@googlecode.com]

Status: Assigned
Owner: vasi...@chromium.org
CC: sabi...@chromium.org
Labels: Type-Bug Pri-2 Cr-UI-Browser-Passwords OS-All M-49

New issue 582964 by dva...@chromium.org: Password save bubble disappears
too fast on skype.com
https://code.google.com/p/chromium/issues/detail?id=582964

On a successful login a password save bubble disappears too fast (<1 sec)
on skype.com. The reason is that there are 2 calls
ManagePasswordsUIController::DidNavigateMainFrame with params.transition
== PAGE_TRANSITION_FORM_SUBMIT and so the bubble is hidden on the second
call. In order not to hide bubble too fast we check that this navigation is
not in-page or redirect, but here we have PAGE_TRANSITION_FORM_SUBMIT
navigation.

So probably it's better to leave 5 seconds delay for bubble as it was
before.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #2 on issue 582964 by bugd...@chromium.org: Password save bubble

disappears too fast on skype.com

https://code.google.com/p/chromium/issues/detail?id=582964#c2

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/719fde6679614fd94f46a4b9630cf75611917ca5

commit 719fde6679614fd94f46a4b9630cf75611917ca5
Author: vasilii <vas...@chromium.org>
Date: Wed Feb 17 15:31:39 2016

Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402, 26186

Review URL: https://codereview.chromium.org/1702333002

Cr-Commit-Position: refs/heads/master@{#375889}

[modify]
http://crrev.com/719fde6679614fd94f46a4b9630cf75611917ca5/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify]
http://crrev.com/719fde6679614fd94f46a4b9630cf75611917ca5/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify]
http://crrev.com/719fde6679614fd94f46a4b9630cf75611917ca5/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

[chro...@googlecode.com]

Updates:
Status: Started
Labels: Merge-Request-49

Comment #3 on issue 582964 by vasi...@chromium.org: Password save bubble

disappears too fast on skype.com
https://code.google.com/p/chromium/issues/detail?id=582964

I'd like to merge r375889. The impact is high. The risk is minimal on the
other hand.

[chro...@googlecode.com]

Updates:
Labels: -Merge-Request-49 Merge-Approved-49 Hotlist-Merge-Approved

Comment #4 on issue 582964 by tin...@google.com: Password save bubble

disappears too fast on skype.com

https://code.google.com/p/chromium/issues/detail?id=582964#c4

Your change meets the bar and is auto-approved for M49 (branch: 2623)