Re: Issue 475506 in chromium: Disallow context menus in --kiosk mode

[chro...@googlecode.com]

Updates:
Summary: Disallow context menus in --kiosk mode
Status: Available
Labels: -Pri-2 -Via-Wizard -Type-Bug -OS-Linux Pri-3 Type-Feature OS-All
Hotlist-GoodFirstBug

Comment #2 on issue 475506 by pkas...@chromium.org: Disallow context menus
in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Hmm. I can understand why some --kiosk users would want to remove context
menus or at least some of their contents. OTOH, it's not obvious whether
all kiosk users would want this or that it should be an inherent property
of kiosk mode.

I think removing context menus entirely is probably OK, but I don't know
when I'll get to this. Patches welcome. Fixing this would probably be
easy.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #3 on issue 475506 by 2378t...@gmail.com: Disallow context menus in
--kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Thank you for answers.
IMHO, add command-line option like '--disable-context-menu' will be enough
for balanced and acceptable solution. By default set as OFF (for save
compatibility with old-versions and behaviors), if need for someone (like
me and other payment terminals holders) - simple add parametr to startup
command line.

[chro...@googlecode.com]

Comment #5 on issue 475506 by 2378t...@gmail.com: Disallow context menus in
--kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Remove context menu in --kiosk-mode is very good idea.
I update google-chrome nowtime up to 42.0.2311.135 from google-repo on
Fedora-21 (baseurl=http://dl.google.com/linux/chrome/rpm/stable/i386), but
context-menu continue appears.
The notification about fix does appear in this bug-tracker (with changing
status to "closed"), or i must watch change-logs and version himself ?

[chro...@googlecode.com]

Comment #6 on issue 475506 by 2378t...@gmail.com: Disallow context menus in
--kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

I don't have enough skills and experience for write patches, but i can make
tests and send reports. Thank you for try to solve this issue.

[chro...@googlecode.com]

Comment #7 on issue 475506 by pkas...@chromium.org: Disallow context menus

in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

If this bug doesn't say "Fixed", expect it not to be fixed.

Again, I strongly encourage external contributions here if you want to see
this happen. --kiosk is not officially supported or maintained by the core
team and there's no time frame for adding features to it or fixing bugs.

[chro...@googlecode.com]

Comment #8 on issue 475506 by 2378t...@gmail.com: Disallow context menus in
--kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

I had make update Google Chrome to 43.0.2357.65 from google-repo on my
Fedora-21, and this menu don't appear in kiosk mode!

In Google Chrome 43.0.2357.65 this bug was fixed.

[chro...@googlecode.com]

Comment #9 on issue 475506 by pkas...@chromium.org: Disallow context menus

in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Sorry, but the patch here hasn't landed, so this isn't fixed. Not sure why
you're not seeing a context menu.

[chro...@googlecode.com]

Comment #10 on issue 475506 by 2378t...@gmail.com: Disallow context menus

in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Some regression taking place ?
I make only standard `yum update` and only after update of system
google-chrome context menu turn disabled.
Can Fedora maintainers make side patches ?

This issue not important for desktop users but critical for kiosk holders.

[chro...@googlecode.com]

Comment #11 on issue 475506 by pkas...@chromium.org: Disallow context

menus in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

I have a hard time understanding what you just posted.

Context menus have not yet been removed in kiosk mode. If you're not
seeing them, I don't know why, but it's something to discuss elsewhere, not
here.

[chro...@googlecode.com]

Comment #12 on issue 475506 by pkas...@chromium.org: Disallow context

menus in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Patch to fix this is at https://codereview.chromium.org/1091173005/

[chro...@googlecode.com]

Comment #13 on issue 475506 by wal...@arreya.com: Disallow context menus in
--kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Is this a duplicate feature since individual kiosk apps & sites can already
control context menu behavior using the onContextMenu event and/or CSS
user-select property?

How will this patch affect the onContextMenu & click event behavior in
kiosk apps?

[chro...@googlecode.com]

Comment #14 on issue 475506 by pkas...@chromium.org: Disallow context

menus in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

I would imagine kiosk apps will be unable to show context menus at all.
That seems better to me than the current situation, which requires everyone
using kiosk mode to be able to customize every page and app to override
context menu hooks to disable context menus, and even that still wouldn't
disable context menus on the browser chrome.

[chro...@googlecode.com]

Comment #15 on issue 475506 by bugd...@chromium.org: Disallow context
menus in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506#c15

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/25e2a6ce5742821aedf91746804487ae64ce2190

commit 25e2a6ce5742821aedf91746804487ae64ce2190
Author: frederic.jacob.78 <frederic...@gmail.com>
Date: Wed Jul 08 02:18:10 2015

Removed the context menu in kiosk mode

This is my first change request so...

BUG=475506
TEST=Start Chrome with --kiosk and the context menu most not be shown.
Start Chrome without the --kiosk flag and the context menu must be shown.

Review URL: https://codereview.chromium.org/1091173005

Cr-Commit-Position: refs/heads/master@{#337741}

[modify] http://crrev.com/25e2a6ce5742821aedf91746804487ae64ce2190/AUTHORS
[modify]
http://crrev.com/25e2a6ce5742821aedf91746804487ae64ce2190/chrome/browser/chrome_browser_application_mac.mm
[modify]
http://crrev.com/25e2a6ce5742821aedf91746804487ae64ce2190/chrome/browser/resources/ntp4/apps_page.js
[modify]
http://crrev.com/25e2a6ce5742821aedf91746804487ae64ce2190/chrome/browser/resources/ntp4/page_list_view.js
[modify]
http://crrev.com/25e2a6ce5742821aedf91746804487ae64ce2190/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc
[modify]
http://crrev.com/25e2a6ce5742821aedf91746804487ae64ce2190/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
[modify]
http://crrev.com/25e2a6ce5742821aedf91746804487ae64ce2190/chrome/browser/ui/webui/ntp/app_launcher_handler.cc

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #16 on issue 475506 by pkas...@chromium.org: Disallow context

menus in --kiosk mode
https://code.google.com/p/chromium/issues/detail?id=475506

Fixed in r337741. Thanks to frederic.jacob.78 for the patch.