Issue 158312 in chromium: Memory leak below XGetWindowAttributes in compositor tests

[chro...@googlecode.com]

Status: Assigned
Owner: osh...@chromium.org
Labels: Type-Bug Pri-2 Area-Internals Stability-Valgrind

New issue 158312 by timur...@chromium.org: Memory leak below
XGetWindowAttributes in compositor tests
http://code.google.com/p/chromium/issues/detail?id=158312

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/16979
[FYI this is the first cycle when compositor tests were run]
Leak_DefinitelyLost
575 bytes in 1 blocks are definitely lost in loss record 2,336 of 2,815
realloc (m_replacemalloc/vg_replace_malloc.c:1088)
__vasprintf_chk (/build/buildd/eglibc-2.11.1/debug/vasprintf_chk.c:90)
g_vasprintf (/usr/include/bits/stdio2.h:199)
g_strdup_vprintf (/build/buildd/glib2.0-2.24.1/glib/gstrfuncs.c:244)
g_strdup_printf (/build/buildd/glib2.0-2.24.1/glib/gstrfuncs.c:270)
gdk_x_error (/build/buildd/gtk+2.0-2.20.1/gdk/x11/gdkmain-x11.c:449)
_XError
(/build/buildd/libx11-1.3.2/obj-x86_64-linux-gnu/src/../../src/XlibInt.c:3103)
process_responses
(/build/buildd/libx11-1.3.2/obj-x86_64-linux-gnu/src/../../src/xcb_io.c:214)
_XReply
(/build/buildd/libx11-1.3.2/obj-x86_64-linux-gnu/src/../../src/xcb_io.c:464)
_XGetWindowAttributes
(/build/buildd/libx11-1.3.2/obj-x86_64-linux-gnu/src/../../src/GetWAttrs.c:116)
XGetWindowAttributes
(/build/buildd/libx11-1.3.2/obj-x86_64-linux-gnu/src/../../src/GetWAttrs.c:151)
gfx::NativeViewGLSurfaceOSMesa::Resize(gfx::Size const&)
(ui/gl/gl_surface_linux.cc:147)
gfx::GLSurfaceOSMesa::Initialize() (ui/gl/gl_surface_osmesa.cc:18)
gfx::NativeViewGLSurfaceOSMesa::Initialize()
(ui/gl/gl_surface_linux.cc:107)
gfx::GLSurface::CreateViewGLSurface(bool, unsigned long)
(ui/gl/gl_surface_linux.cc:279)

webkit::gpu::WebGraphicsContext3DInProcessImpl::CreateForWindow(WebKit::WebGraphicsContext3D::Attributes,
unsigned long, gfx::GLShareGroup*)
(webkit/gpu/webgraphicscontext3d_in_process_impl.cc:179)
ui::DefaultContextFactory::CreateContextCommon(ui::Compositor*, bool)
(ui/compositor/compositor.cc:115)
ui::DefaultContextFactory::CreateContext(ui::Compositor*)
(ui/compositor/compositor.cc:91)
ui::Compositor::createOutputSurface() (ui/compositor/compositor.cc:401)
WebKit::WebLayerTreeViewImpl::createOutputSurface()
(webkit/compositor_bindings/web_layer_tree_view_impl.cc:230)
cc::LayerTreeHost::createContext() (cc/layer_tree_host.cc:311)
cc::SingleThreadProxy::initializeContext() (cc/single_thread_proxy.cc:90)
cc::LayerTreeHost::initialize() (cc/layer_tree_host.cc:129)
cc::LayerTreeHost::create(cc::LayerTreeHostClient*, cc::LayerTreeSettings
const&) (cc/layer_tree_host.cc:89)

WebKit::WebLayerTreeViewImpl::initialize(WebKit::WebLayerTreeView::Settings
const&) (webkit/compositor_bindings/web_layer_tree_view_impl.cc:56)

webkit::WebCompositorSupportImpl::createLayerTreeView(WebKit::WebLayerTreeViewClient*,
WebKit::WebLayer const&, WebKit::WebLayerTreeView::Settings const&)
(webkit/compositor_bindings/web_compositor_support_impl.cc:91)
ui::Compositor::Compositor(ui::CompositorDelegate*, unsigned long)
(ui/compositor/compositor.cc:183)
ui::LayerWithDelegateTest::SetUp() (ui/compositor/layer_unittest.cc:435)
Suppression (error hash=#93F054CFB838D43B#):
For more info on using suppressions see
http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Leak
fun:realloc
fun:__vasprintf_chk
fun:g_vasprintf
fun:g_strdup_vprintf
fun:g_strdup_printf
fun:gdk_x_error
fun:_XError
fun:process_responses
fun:_XReply
fun:_XGetWindowAttributes
fun:XGetWindowAttributes
fun:_ZN3gfx25NativeViewGLSurfaceOSMesa6ResizeERKNS_4SizeE
fun:_ZN3gfx15GLSurfaceOSMesa10InitializeEv
fun:_ZN3gfx25NativeViewGLSurfaceOSMesa10InitializeEv
fun:_ZN3gfx9GLSurface19CreateViewGLSurfaceEbm

fun:_ZN6webkit3gpu33WebGraphicsContext3DInProcessImpl15CreateForWindowEN6WebKit20WebGraphicsContext3D10AttributesEmPN3gfx12GLShareGroupE
fun:_ZN2ui21DefaultContextFactory19CreateContextCommonEPNS_10CompositorEb
fun:_ZN2ui21DefaultContextFactory13CreateContextEPNS_10CompositorE
fun:_ZN2ui10Compositor19createOutputSurfaceEv
fun:_ZN6WebKit20WebLayerTreeViewImpl19createOutputSurfaceEv
fun:_ZN2cc13LayerTreeHost13createContextEv
fun:_ZN2cc17SingleThreadProxy17initializeContextEv
}

[chro...@googlecode.com]

Comment #1 on issue 158312 by bugdro...@chromium.org: Memory leak below
XGetWindowAttributes in compositor tests
http://code.google.com/p/chromium/issues/detail?id=158312#c1

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=164650

------------------------------------------------------------------------
r164650 | timu...@chromium.org | 2012-10-29T16:40:58.698112Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=164650&r2=164649&pathrev=164650

Suppress some leaks on the Valgrind bots
BUG=157669,158312,158314
TEST=./tools/valgrind/waterfall.sh fetch+match
TBR=thestig
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11275061
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #2 on issue 158312 by osh...@chromium.org: Memory leak below

XGetWindowAttributes in compositor tests
http://code.google.com/p/chromium/issues/detail?id=158312

This is most likely due to a crash mentioned in crbug.com158357.

[chro...@googlecode.com]

Updates:
Status: WontFix

Comment #3 on issue 158312 by osh...@chromium.org: Memory leak below

XGetWindowAttributes in compositor tests
http://code.google.com/p/chromium/issues/detail?id=158312

This was indeed due to crash.

[chro...@googlecode.com]

Comment #4 on issue 158312 by bugdro...@chromium.org: Memory leak below
XGetWindowAttributes in compositor tests
http://code.google.com/p/chromium/issues/detail?id=158312#c4

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=164866

------------------------------------------------------------------------
r164866 | osh...@chromium.org | 2012-10-30T06:30:23.458428Z

Changed paths:
D
http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/gtest_exclude/compositor_unittests.gtest.txt?r1=164866&r2=164865&pathrev=164866
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=164866&r2=164865&pathrev=164866

Cleanup suppression for compositor test

TBR=timu...@chromium.org
BUG=158357,148477,158314,158312
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11336031
------------------------------------------------------------------------