[Sheriff] It seems - SelectToSpeakKeystrokeSelectionTest.OmniboxPartiallySelectedToEnd - SelectToSpeakKeystrokeSelectionTest.textFieldWithComboBoxSimple - SelectToSpeakKeystrokeSelectionTest.ReorderedSvgIgnoresSelectionStartEnd - SelectToSpeakKeystrokeSelectionTest.StartsReadingAtFirstNodeWithText - SelectToSpeakKeystrokeSelectionTest.HandlesMultipleImagesCorrectlyWithAutomation are flaky as well
lingqi via monorail
unread,
Feb 6, 2023, 1:29:48 AM2/6/23
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
Disables several tests that have been flaky for a long time according to the issue. SelectToSpeakKeystrokeSelectionTest.OmniboxPartiallySelectedToEnd SelectToSpeakKeystrokeSelectionTest.textFieldWithComboBoxSimple SelectToSpeakKeystrokeSelectionTest.ReorderedSvgIgnoresSelectionStartEnd SelectToSpeakKeystrokeSelectionTest.StartsReadingAtFirstNodeWithText SelectToSpeakKeystrokeSelectionTest.HandlesMultipleImagesCorrectlyWithAutomation SelectToSpeakNavigationControlTest.ChangeSpeedWhilePlaying SelectToSpeakNavigationControlTest.PauseResumeFromKeystrokeSelection SelectToSpeakNavigationControlTest.PrevSentence SelectToSpeakNavigationControlTest.PrevSentenceFromMiddleOfSentence SelectToSpeakNavigationControlTest.NavigatesToPreviousParagraph SelectToSpeakNavigationControlTest.NavigatesToNextParagraphQuickly SelectToSpeakNavigationControlTest.NextSentenceAcrossParagraph SelectToSpeakNavigationControlTest.NextSentenceWithinParagraph SelectToSpeakNavigationControlTest.PauseResumeAfterParagraphNavigation SelectToSpeakNavigationControlTest.PauseResumeAfterSentenceNavigation SelectToSpeakNavigationControlTest.ResizeWhilePlaying SelectToSpeakNavigationControlTest.RetainsSpeedChange
Reland "Sheriff: disable some SelectToSpeak tests"
This reverts commit 19fb46df4a4d1e93382f2c65e0158f7707a57e05.
Reason for revert: Tests had been deflaked just 2 days before this change landed but were likely still high in the flaky list from weeks of previous flaking. Speculatively re-enabling to watch them run on the builders for more hours and will track carefully.
After crrev.com/c/4219169 landed on the 3rd, I can see that these tests did stop flaking based on the flake portal. Here's the first several, you can see no failures after the 3rd even though there were multiple daily failures previously: