ax_dump_tree default behavior change

30 views
Skip to first unread message

Alexander Surkov

unread,
Apr 8, 2021, 11:36:14 AM4/8/21
to Chromium Accessibility, Joanmarie Diggs, Dominic Mazzoni, Aaron Leventhal
Hi.

If you run ax_dump_tree as is then it dumps the whole unfiltered tree. If you set up a filter, then it dumps stuff only reflecting the filtering settings. In the first case, it's a lot of information and it's slow. In the latter case, a tree can become quite useless by simply putting a single @DENY instruction.

I was thinking to change ax_dump_tree to include default attributes similar to what ax_dump_testsuite does. It will produce a smaller reasonable trees in both cases: when no filters is specified and when filters are given. So, in other words, the suggestion is let's apply default filterers unless otherwise is specified.

Are there any objections of the change?
Thanks!
Alexander.

Dominic Mazzoni

unread,
Apr 8, 2021, 1:30:19 PM4/8/21
to Alexander Surkov, Chromium Accessibility, Joanmarie Diggs, Aaron Leventhal
No objections, sounds good.

Optionally, one idea is that it could log the filters that were used when run from the command line. We could potentially put logging in stderr and just the tree dump in stdout.

Alexander Surkov

unread,
Apr 8, 2021, 1:52:16 PM4/8/21
to Dominic Mazzoni, Chromium Accessibility, Joanmarie Diggs, Aaron Leventhal


On Thu, Apr 8, 2021 at 1:30 PM Dominic Mazzoni <dmaz...@google.com> wrote:
No objections, sounds good.

ok!


Optionally, one idea is that it could log the filters that were used when run from the command line. We could potentially put logging in stderr and just the tree dump in stdout.

Might be a useful feature. It helps to avoid a black box problems. How about adding a separate argument to dump filters, for example, ax_dump_tree --active-filters will output applied filters rather than accessible trees?

Dominic Mazzoni

unread,
Apr 8, 2021, 1:54:19 PM4/8/21
to Alexander Surkov, Chromium Accessibility, Joanmarie Diggs, Aaron Leventhal
I definitely won't object to any additional useful command-line options. Add whatever you think is helpful.
Reply all
Reply to author
Forward
0 new messages