Starting point of execution

338 views
Skip to first unread message

Milan Karmakar

unread,
Jun 10, 2024, 5:48:47 PM6/10/24
to chrome-up...@chromium.org
Hi,
The code inside chrome/updater folder (e.g. chrome/updater/updater.cc) seems to be disabled. I am not able to put breakpoints on Windows build.

Could you please help.

Regards,
Milan

Sorin Jianu

unread,
Jun 10, 2024, 5:55:47 PM6/10/24
to Milan Karmakar, chrome-up...@chromium.org
On Mon, Jun 10, 2024 at 2:48 PM Milan Karmakar <mbkar...@gmail.com> wrote:
Hi,
The code inside chrome/updater folder (e.g. chrome/updater/updater.cc) seems to be disabled. I am not able to put breakpoints on Windows build.

What target are you trying to debug? The build target for `chrome/updater/updater.cc` is `updater` not `chrome`. I hope this helps.
 

Could you please help.

Regards,
Milan

--
You received this message because you are subscribed to the Google Groups "Chrome Updates Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chrome-updates-...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chrome-updates-dev/CAF21F1JJTJhCZC66NpmVPfqmmijpCaVmTcGxxveXyE_0yJ%3Dytg%40mail.gmail.com.

Milan Karmakar

unread,
Jun 11, 2024, 11:39:15 AM6/11/24
to Sorin Jianu, chrome-up...@chromium.org
thnks lot sorin..

Milan Karmakar

unread,
Jun 13, 2024, 1:32:46 AM6/13/24
to Sorin Jianu, chrome-up...@chromium.org
Hi Sorin,
We are developing a browser based on chromium for Windows and MAC. We need auto upgrade feature.

Steps done til now on Windows:-
1. Generate updater.exe using below mentioned updater target.
2. updater.exe --install -app-id{▪︎▪︎▪︎}
This copies out\Default folder contents inside ChromiumUpdater folder, download crx3 and install updater.

But the problems are:-
1. file version_updater_win.cc is not currently linked to settings/help.
2. Omaha test server is valid for 14 days.

Can you please help me with the source code changes in chromium?

Regards,
Milan

Sorin Jianu

unread,
Jun 14, 2024, 6:09:34 PM6/14/24
to Milan Karmakar, chrome-up...@chromium.org
On Wed, Jun 12, 2024 at 10:20 PM Milan Karmakar <mbkar...@gmail.com> wrote:
Hi Sorin,
We are developing a browser based on chromium for Windows and MAC. We need auto upgrade feature.

Steps done til now on Windows:-
1. Generate updater.exe using below mentioned updater target.
2. updater.exe --install -app-id{▪︎▪︎▪︎}
This copies out\Default folder contents inside ChromiumUpdater folder, download crx3 and install updater.

But the problems are:-
1. file version_updater_win.cc is not currently linked to settings/help.

that file is part of the sources only for Google Chrome branded builds

if (is_chrome_branded) {
sources += [
"webui/help/version_updater_win.cc",
 
2. Omaha test server is valid for 14 days.

Can you please clarify what Omaha test server are you referring to? 

Can you please help me with the source code changes in chromium?

Omaha can update the browser in two ways:
  1. automatic, silent updates.
    For this to work, you'd have to make changes to chrome/installer to make sure running the installer not only installs your browser, but it can update it as well.
    If you are not using chrome/installer for your browser, then it's likely that not many changes to the browser code are needed.
  2. on-demand updates, driven by the browser's `chrome://help`.
    For this one, I suggest using cs.chromium.org, search for hits on `google_update` and understand how the updater and Chrome interoperate.
I hope this helps

Milan Karmakar

unread,
Jun 15, 2024, 1:06:24 AM6/15/24
to Sorin Jianu, chrome-up...@chromium.org
Thanks Sorin.
We are looking for auto update.
1. Omaha server we are using : 
2. In chrome://help I checked only chrome/browser/ui/webui/help/version_updater_basic.cc is used.

Regards,
Milan

Greg Thompson

unread,
Jun 17, 2024, 3:43:11 AM6/17/24
to Milan Karmakar, Sorin Jianu, chrome-up...@chromium.org
Hi Milan.

As Sorin mentioned, Chromium does not integrate with an updater. If you want to make your own fork of Chromium use your own fork of Omaha, then you'll need to look at things like //chrome/browser/ui/BUILD.gn for places where you see that is_chrome_branded is used to conditionally compile in version_updater_basic.cc vs version_updater_win.cc (as just one example). Note that you should not simply set is_chrome_branded=true -- you will need to define your own "brand" for the browser and various updater-related constants (see chrome/install_static). I don't have any other specific guidance -- perhaps other folks who have forked Chromium can give you some advice. You could check on chromium.slack.com or ask on the chromium-dev mailing list for help.

Sorin Jianu

unread,
Jun 18, 2024, 10:37:14 AM6/18/24
to Milan Karmakar, Greg Thompson, chrome-up...@chromium.org
Hi Milan,
I don't know of other options for hosting an update server for Omaha.

On Mon, Jun 17, 2024 at 7:11 PM Milan Karmakar <mbkar...@gmail.com> wrote:
Hi Greg And Sorin,

On demand update is working for me. But is there any other option other than the paid Omaha Server to host?
Currently the following is free for 14 days.
Omaha server we are using : 

Regards,
Milan

On Mon, 17 Jun 2024, 19:35 Milan Karmakar, <mbkar...@gmail.com> wrote:
Thanks Greg for the help.

Basavara...@ril.com

unread,
Jun 18, 2024, 10:37:18 AM6/18/24
to mbkar...@gmail.com, so...@google.com, chrome-up...@chromium.org, Abhishek...@ril.com, Praveen....@ril.com

Hi Michael,

 

I am working along with Milan but for mac,

 

What should be these values ? which are mac specific

 

   keystone_app_name = "ChromiumSoftwareUpdate"

   keystone_bundle_identifier = "org.chromium.Keystone"

   mac_browser_bundle_identifier = "org.chromium.Chromium"

   mac_updater_bundle_identifier = "org.chromium.ChromiumUpdater"

 

 

I always get this below error while connecting to

 

mojo::PlatformChannelEndpoint ConnectToServer server_name: message.header.msgh_local_port: org.chromium.ChromiumUpdater.update

mojo::PlatformChannelEndpoint ConnectToServer err kr: 268435459

 

 

and what should be for below url ?

 

device_management_server_url = https://m.google.com/devicemanagement/data/api

 

 

We changed update_check_url as below

 

-update_check_url = "https://update.googleapis.com/service/update2/json"

+update_check_url = "https://omaha4.omaha-consulting.com/quest-global/service/update2/json"

 

 

 

Thanks & Regards,

Basavaraj

 

From: Milan Karmakar <mbkar...@gmail.com>
Date: Saturday, 15 June 2024 at 12:08 PM
To: Sorin Jianu <so...@google.com>
Cc: "chrome-up...@chromium.org" <chrome-up...@chromium.org>, Abhishek Agarwal <Abhishek...@ril.com>, Basavaraja Sidda <Basavara...@ril.com>, Praveen Akkiraju <Praveen....@ril.com>
Subject: [External]Chromium Upgrade feature

 

Caution: The e-mail below is from an external source. Please do not open attachments or click links unless this email comes from a known sender and you know the content is safe.


 

Hi Sorin,

Thanks for your email.

1. We'll try to enable the flag (is_chrome_branded) for on-demand updates on Windows through settings/help

2. For auto update do we need to use any different flag or target to enable chrome/installer ?


Regards,

Milan


"Confidentiality Warning: This message and any attachments are intended only for the use of the intended recipient(s), are confidential and may be privileged. If you are not the intended recipient, you are hereby notified that any review, re-transmission, conversion to hard copy, copying, circulation or other use of this message and any attachments is strictly prohibited. If you are not the intended recipient, please notify the sender immediately by return email and delete this message and any attachments from your system.

Virus Warning: Although the company has taken reasonable precautions to ensure no viruses are present in this email. The company cannot accept responsibility for any loss or damage arising from the use of this email or attachment."

Milan Karmakar

unread,
Jun 18, 2024, 10:37:31 AM6/18/24
to Sorin Jianu, chrome-up...@chromium.org, Abhishek...@ril.com, Basavara...@ril.com, Praveen....@ril.com
Hi Sorin,
Thanks for your email.
1. We'll try to enable the flag (is_chrome_branded) for on-demand updates on Windows through settings/help
2. For auto update do we need to use any different flag or target to enable chrome/installer ?

Regards,
Milan
On Sat, 15 Jun 2024, 08:45 Milan Karmakar, <mbkar...@gmail.com> wrote:

Milan Karmakar

unread,
Jun 18, 2024, 10:38:13 AM6/18/24
to Greg Thompson, Sorin Jianu, chrome-up...@chromium.org
Thanks Greg for the help.

On Mon, 17 Jun 2024, 13:13 Greg Thompson, <g...@chromium.org> wrote:

Milan Karmakar

unread,
Jun 18, 2024, 10:38:17 AM6/18/24
to Greg Thompson, Sorin Jianu, chrome-up...@chromium.org
Hi Greg And Sorin,

On demand update is working for me. But is there any other option other than the paid Omaha Server to host?
Currently the following is free for 14 days.
Omaha server we are using : 

Regards,
Milan

On Mon, 17 Jun 2024, 19:35 Milan Karmakar, <mbkar...@gmail.com> wrote:
Reply all
Reply to author
Forward
0 new messages