[gtest] Clean up single-arg `Invoke()`s in rest of `//chrome/browser/` [chromium/src : main]

0 views
Skip to first unread message

Jonathan Lee (Gerrit)

unread,
Sep 6, 2025, 12:42:24 AMSep 6
to Darryl James, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, msrame...@chromium.org, dmurph+watc...@chromium.org, milicau+watchlis...@google.com, omnibox-...@chromium.org, derinel+wat...@google.com, chrome-gr...@chromium.org, jdonnel...@chromium.org, kinuko+...@chromium.org, knollr+wat...@chromium.org, zelin+watch-we...@chromium.org, feature-v...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, gcasto+w...@chromium.org, mgiuca...@chromium.org, loyso...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, dtraino...@chromium.org, webauthn...@chromium.org, vasilii+watchlis...@chromium.org, yigu+...@chromium.org, rmcelra...@chromium.org
Attention needed from Darryl James

Jonathan Lee voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7179591b29cab3a94d7d2a7cbd93b44dfecbd0fb
Gerrit-Change-Number: 6920290
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Comment-Date: Sat, 06 Sep 2025 04:42:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Darryl James (Gerrit)

unread,
Sep 8, 2025, 1:28:06 PM (13 days ago) Sep 8
to Jonathan Lee, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, msrame...@chromium.org, dmurph+watc...@chromium.org, milicau+watchlis...@google.com, omnibox-...@chromium.org, derinel+wat...@google.com, chrome-gr...@chromium.org, jdonnel...@chromium.org, kinuko+...@chromium.org, knollr+wat...@chromium.org, zelin+watch-we...@chromium.org, feature-v...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, gcasto+w...@chromium.org, mgiuca...@chromium.org, loyso...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, dtraino...@chromium.org, webauthn...@chromium.org, vasilii+watchlis...@chromium.org, yigu+...@chromium.org, rmcelra...@chromium.org
Attention needed from Jonathan Lee

Darryl James voted and added 1 comment

Votes added by Darryl James

Code-Review+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Darryl James . resolved

lgtm % merge conflicts 👍

Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Lee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7179591b29cab3a94d7d2a7cbd93b44dfecbd0fb
Gerrit-Change-Number: 6920290
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Jonathan Lee <jonath...@google.com>
Gerrit-Comment-Date: Mon, 08 Sep 2025 17:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jonathan Lee (Gerrit)

unread,
Sep 8, 2025, 2:46:27 PM (13 days ago) Sep 8
to Darryl James, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, msrame...@chromium.org, dmurph+watc...@chromium.org, milicau+watchlis...@google.com, omnibox-...@chromium.org, derinel+wat...@google.com, chrome-gr...@chromium.org, jdonnel...@chromium.org, kinuko+...@chromium.org, knollr+wat...@chromium.org, zelin+watch-we...@chromium.org, feature-v...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, gcasto+w...@chromium.org, mgiuca...@chromium.org, loyso...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, dtraino...@chromium.org, webauthn...@chromium.org, vasilii+watchlis...@chromium.org, yigu+...@chromium.org, rmcelra...@chromium.org
Attention needed from Darryl James

Jonathan Lee voted and added 1 comment

Votes added by Jonathan Lee

Auto-Submit+1

1 comment

Patchset-level comments
Darryl James . resolved

lgtm % merge conflicts 👍

Jonathan Lee

@dlj...@chromium.org Lost your CR+1 because of the move in https://crrev.com/c/6909711 (`//c/b/web_applications/isolated_web_apps/{ => update/}isolated_web_app_update_apply_waiter_unittest.cc`). Please restamp, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7179591b29cab3a94d7d2a7cbd93b44dfecbd0fb
Gerrit-Change-Number: 6920290
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Comment-Date: Mon, 08 Sep 2025 18:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Darryl James <dlj...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Darryl James (Gerrit)

unread,
Sep 8, 2025, 2:46:38 PM (13 days ago) Sep 8
to Jonathan Lee, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, msrame...@chromium.org, dmurph+watc...@chromium.org, milicau+watchlis...@google.com, omnibox-...@chromium.org, derinel+wat...@google.com, chrome-gr...@chromium.org, jdonnel...@chromium.org, kinuko+...@chromium.org, knollr+wat...@chromium.org, zelin+watch-we...@chromium.org, feature-v...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, gcasto+w...@chromium.org, mgiuca...@chromium.org, loyso...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, dtraino...@chromium.org, webauthn...@chromium.org, vasilii+watchlis...@chromium.org, yigu+...@chromium.org, rmcelra...@chromium.org

Darryl James voted and added 1 comment

Votes added by Darryl James

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Darryl James . resolved

lgtms

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7179591b29cab3a94d7d2a7cbd93b44dfecbd0fb
Gerrit-Change-Number: 6920290
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Mon, 08 Sep 2025 18:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 8, 2025, 5:03:04 PM (13 days ago) Sep 8
to Jonathan Lee, Darryl James, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, Andrew Rayskiy, AyeAye, msrame...@chromium.org, dmurph+watc...@chromium.org, milicau+watchlis...@google.com, omnibox-...@chromium.org, derinel+wat...@google.com, chrome-gr...@chromium.org, jdonnel...@chromium.org, kinuko+...@chromium.org, knollr+wat...@chromium.org, zelin+watch-we...@chromium.org, feature-v...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, gcasto+w...@chromium.org, mgiuca...@chromium.org, loyso...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, dtraino...@chromium.org, webauthn...@chromium.org, vasilii+watchlis...@chromium.org, yigu+...@chromium.org, rmcelra...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[gtest] Clean up single-arg `Invoke()`s in rest of `//chrome/browser/`

Not needed and deprecated [0]. This CL should be a no-op.

Other `//chrome/browser/*/` are handled in separate CLs.

[0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046
Bug: 439838457
Change-Id: I7179591b29cab3a94d7d2a7cbd93b44dfecbd0fb
Auto-Submit: Jonathan Lee <jonath...@google.com>
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Jonathan Lee <jonath...@google.com>
Commit-Queue: Darryl James <dlj...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1512649}
Files:
  • M chrome/browser/autocomplete/chrome_autocomplete_provider_client_browsertest.cc
  • M chrome/browser/browser_switcher/browser_switcher_prefs_unittest.cc
  • M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
  • M chrome/browser/controlled_frame/controlled_frame_permission_request_browsertest.cc
  • M chrome/browser/devtools/devtools_ui_bindings_unittest.cc
  • M chrome/browser/download/download_target_determiner_unittest.cc
  • M chrome/browser/interstitials/enterprise_util_unittest.cc
  • M chrome/browser/local_discovery/service_discovery_client_unittest.cc
  • M chrome/browser/offline_pages/visuals_decoder_impl_unittest.cc
  • M chrome/browser/os_crypt/app_bound_encryption_provider_win_unittest.cc
  • M chrome/browser/picture_in_picture/picture_in_picture_occlusion_tracker_unittest.cc
  • M chrome/browser/platform_experience/installer/installer_win_unittest.cc
  • M chrome/browser/predictors/loading_predictor_tab_helper_unittest.cc
  • M chrome/browser/resource_coordinator/session_restore_policy_unittest.cc
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
  • M chrome/browser/segmentation_platform/service_browsertest.cc
  • M chrome/browser/serial/serial_chooser_context_unittest.cc
  • M chrome/browser/sessions/session_data_service_unittest.cc
  • M chrome/browser/sharing/sms/sms_remote_fetcher_unittest.cc
  • M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc
  • M chrome/browser/v8_compile_hints/v8_compile_hints_tab_helper_unittest.cc
  • M chrome/browser/vr/test/webxr_vr_browser_test.cc
  • M chrome/browser/web_applications/commands/launch_web_app_command_browsertest.cc
  • M chrome/browser/web_applications/isolated_web_apps/update/isolated_web_app_update_apply_waiter_unittest.cc
  • M chrome/browser/web_applications/web_app_run_on_os_login_manager_browsertest.cc
  • M chrome/browser/webauthn/password_credential_ui_controller_unittest.cc
  • M chrome/browser/win/installer_downloader/installer_downloader_controller_unittest.cc
Change size: L
Delta: 27 files changed, 146 insertions(+), 181 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darryl James
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7179591b29cab3a94d7d2a7cbd93b44dfecbd0fb
Gerrit-Change-Number: 6920290
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages