Reduce the size of generated Mojo files when no interfaces are defined [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Apr 5, 2026, 10:54:46 PMApr 5
to Daniel Cheng, Takuto Ikuta, chromotin...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mathias Bynens, Mike Taylor, Hu, Ningxin, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, Sarah Krakowiak, James Su, Victor Tan, Ian Vollick, Lin, Wanming, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, cros-print...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hayato...@chromium.org, headless...@chromium.org, iclella...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jatapiaro+wat...@google.com, jbauma...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, tgupta...@chromium.org, thiabaud+watch-d...@google.com, titoua...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, trewin...@google.com, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, aixba+wat...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, martijn...@martijnc.be, mek+w...@chromium.org, mgiuca...@chromium.org, mkwst+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, rsleev...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8673e0d9b1f7f5a647afa8da1affbbe8268481b0
Gerrit-Change-Number: 7729944
Gerrit-PatchSet: 11
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Apr 2026 02:54:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Apr 6, 2026, 2:01:03 AMApr 6
to Daniel Cheng, Takuto Ikuta, chromotin...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mathias Bynens, Mike Taylor, Hu, Ningxin, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, Sarah Krakowiak, James Su, Victor Tan, Ian Vollick, Lin, Wanming, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, cros-print...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hayato...@chromium.org, headless...@chromium.org, iclella...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jatapiaro+wat...@google.com, jbauma...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, tgupta...@chromium.org, thiabaud+watch-d...@google.com, titoua...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, trewin...@google.com, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, aixba+wat...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, martijn...@martijnc.be, mek+w...@chromium.org, mgiuca...@chromium.org, mkwst+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, rsleev...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Daniel Cheng voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8673e0d9b1f7f5a647afa8da1affbbe8268481b0
Gerrit-Change-Number: 7729944
Gerrit-PatchSet: 12
Gerrit-Comment-Date: Mon, 06 Apr 2026 06:00:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Apr 6, 2026, 2:08:47 PMApr 6
to Daniel Cheng, Lei Zhang, Takuto Ikuta, chromotin...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mathias Bynens, Mike Taylor, Hu, Ningxin, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, Sarah Krakowiak, James Su, Victor Tan, Ian Vollick, Lin, Wanming, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, cros-print...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hayato...@chromium.org, headless...@chromium.org, iclella...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jatapiaro+wat...@google.com, jbauma...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, tgupta...@chromium.org, thiabaud+watch-d...@google.com, titoua...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, trewin...@google.com, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, aixba+wat...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, martijn...@martijnc.be, mek+w...@chromium.org, mgiuca...@chromium.org, mkwst+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, rsleev...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Lei Zhang . resolved

Thank you for putting this together. I've been trying to do something similar and never got it quite right.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8673e0d9b1f7f5a647afa8da1affbbe8268481b0
Gerrit-Change-Number: 7729944
Gerrit-PatchSet: 12
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Apr 2026 18:08:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 6, 2026, 2:39:18 PMApr 6
to Daniel Cheng, Lei Zhang, Takuto Ikuta, Akihiro Ota, chromotin...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mathias Bynens, Mike Taylor, Hu, Ningxin, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, Sarah Krakowiak, James Su, Victor Tan, Ian Vollick, Lin, Wanming, chromium...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, cros-print...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hayato...@chromium.org, headless...@chromium.org, iclella...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jatapiaro+wat...@google.com, jbauma...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, tgupta...@chromium.org, thiabaud+watch-d...@google.com, titoua...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, trewin...@google.com, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, aixba+wat...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, martijn...@martijnc.be, mek+w...@chromium.org, mgiuca...@chromium.org, mkwst+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, rsleev...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Reduce the size of generated Mojo files when no interfaces are defined

Many headers in the .mojom.cc files are only needed when the .mojom file
defines interfaces; leaving them out reduces compile size inputs by
~1.89GB / ~0.82%.
Bug: 499476145
Change-Id: I8673e0d9b1f7f5a647afa8da1affbbe8268481b0
Reviewed-by: Takuto Ikuta <tik...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1610379}
Files:
  • M mojo/golden/generated/c++/basic_struct.test-mojom.cc.golden
  • M mojo/golden/generated/c++/basic_union.test-mojom.cc.golden
  • M mojo/golden/generated/c++/interface.test-mojom.cc.golden
  • M mojo/golden/generated/c++/optional_primitives.test-mojom.cc.golden
  • M mojo/golden/generated/c++/results.test-mojom.cc.golden
  • M mojo/golden/generated/c++/typemap.test-mojom.cc.golden
  • M mojo/public/tools/bindings/generators/cpp_templates/module-shared.cc.tmpl
  • M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
Change size: M
Delta: 8 files changed, 22 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Takuto Ikuta
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8673e0d9b1f7f5a647afa8da1affbbe8268481b0
Gerrit-Change-Number: 7729944
Gerrit-PatchSet: 13
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages