Add some missing includes of //content/public/browser/page.h [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Aug 27, 2025, 3:53:44 PMAug 27
to Peter Beverloo, Andrew Rayskiy, Simon Hangl, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, performance-m...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chromium-a...@chromium.org, browser-comp...@chromium.org, dmurph+wat...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, chrome-gr...@chromium.org, vakh+safe_br...@chromium.org, android-web...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, loyso...@chromium.org, subresource-f...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, asvitki...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, chromiumme...@microsoft.com, speed-metr...@chromium.org, dmurph+watchi...@chromium.org, bmcquad...@chromium.org, mfoltz...@chromium.org, ortuno...@chromium.org, chrome-intell...@chromium.org, loading-rev...@chromium.org, webap...@microsoft.com, rizvis...@google.com, chrome-intelligence-te...@google.com, thesals...@google.com, speed-metrics...@chromium.org, csharris...@chromium.org, johnyki...@google.com, feature-me...@chromium.org, permissio...@chromium.org, rmcelra...@chromium.org, chfreme...@chromium.org, rrsilva+wat...@google.com
Attention needed from David Sanders

Message from David Sanders

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If0f7c8fc86d26501d1590470f97aee234ef0d1a3
Gerrit-Change-Number: 6780702
Gerrit-PatchSet: 20
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Wed, 27 Aug 2025 19:53:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Aug 27, 2025, 4:03:53 PMAug 27
to David Sanders, Lei Zhang, Peter Beverloo, Andrew Rayskiy, Simon Hangl, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, performance-m...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chromium-a...@chromium.org, browser-comp...@chromium.org, dmurph+wat...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, chrome-gr...@chromium.org, vakh+safe_br...@chromium.org, android-web...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, loyso...@chromium.org, subresource-f...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, asvitki...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, chromiumme...@microsoft.com, speed-metr...@chromium.org, dmurph+watchi...@chromium.org, bmcquad...@chromium.org, mfoltz...@chromium.org, ortuno...@chromium.org, chrome-intell...@chromium.org, loading-rev...@chromium.org, webap...@microsoft.com, rizvis...@google.com, chrome-intelligence-te...@google.com, thesals...@google.com, speed-metrics...@chromium.org, csharris...@chromium.org, johnyki...@google.com, feature-me...@chromium.org, permissio...@chromium.org, rmcelra...@chromium.org, chfreme...@chromium.org, rrsilva+wat...@google.com
Attention needed from David Sanders

Lei Zhang voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If0f7c8fc86d26501d1590470f97aee234ef0d1a3
Gerrit-Change-Number: 6780702
Gerrit-PatchSet: 20
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Wed, 27 Aug 2025 20:03:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 27, 2025, 5:39:55 PMAug 27
to David Sanders, Lei Zhang, Peter Beverloo, Andrew Rayskiy, Simon Hangl, Rijubrata Bhaumik, AyeAye, performance-m...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chromium-a...@chromium.org, browser-comp...@chromium.org, dmurph+wat...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org, chrome-gr...@chromium.org, vakh+safe_br...@chromium.org, android-web...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, loyso...@chromium.org, subresource-f...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, asvitki...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, chromiumme...@microsoft.com, speed-metr...@chromium.org, dmurph+watchi...@chromium.org, bmcquad...@chromium.org, mfoltz...@chromium.org, ortuno...@chromium.org, chrome-intell...@chromium.org, loading-rev...@chromium.org, webap...@microsoft.com, rizvis...@google.com, chrome-intelligence-te...@google.com, thesals...@google.com, speed-metrics...@chromium.org, csharris...@chromium.org, johnyki...@google.com, feature-me...@chromium.org, permissio...@chromium.org, rmcelra...@chromium.org, chfreme...@chromium.org, rrsilva+wat...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add some missing includes of //content/public/browser/page.h
Bug: 40216326
Change-Id: If0f7c8fc86d26501d1590470f97aee234ef0d1a3
Owners-Override: Lei Zhang <the...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Cr-Commit-Position: refs/heads/main@{#1507375}
Files:
  • M android_webview/browser/renderer_host/aw_render_view_host_ext.cc
  • M chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc
  • M chrome/browser/apps/platform_apps/audio_focus_web_contents_observer.cc
  • M chrome/browser/ash/child_accounts/time_limits/web_time_navigation_observer.cc
  • M chrome/browser/glic/host/context/glic_pinned_tab_manager.cc
  • M chrome/browser/glic/host/glic_annotation_manager.cc
  • M chrome/browser/history/history_tab_helper.cc
  • M chrome/browser/login_detection/login_detection_tab_helper.cc
  • M chrome/browser/media/webrtc/same_origin_observer.cc
  • M chrome/browser/metrics/metrics_memory_details.cc
  • M chrome/browser/metrics/tab_stats/tab_stats_tracker.cc
  • M chrome/browser/page_content_annotations/page_content_extraction_service.cc
  • M chrome/browser/page_info/about_this_site_tab_helper.cc
  • M chrome/browser/performance_manager/mechanisms/termination_target_setter_browsertest.cc
  • M chrome/browser/permissions/one_time_permissions_tracker_helper.cc
  • M chrome/browser/resource_coordinator/tab_helper.cc
  • M chrome/browser/safe_browsing/chrome_password_reuse_detection_manager_client.cc
  • M chrome/browser/safe_browsing/tailored_security/tailored_security_url_observer.cc
  • M chrome/browser/signin/logout_tab_helper.cc
  • M chrome/browser/ui/ash/back_gesture/back_gesture_contextual_nudge_delegate.cc
  • M chrome/browser/ui/omnibox/omnibox_tab_helper.cc
  • M chrome/browser/ui/safety_hub/revoked_permissions_service.cc
  • M chrome/browser/ui/webui/inspect/inspect_ui.cc
  • M chrome/browser/v8_compile_hints/v8_compile_hints_tab_helper.cc
  • M chrome/browser/web_applications/web_app_tab_helper.cc
  • M components/dom_distiller/content/browser/distiller_page_web_contents.cc
  • M components/fingerprinting_protection_filter/browser/fingerprinting_protection_web_contents_helper.cc
  • M components/fingerprinting_protection_filter/browser/throttle_manager_unittest.cc
  • M components/optimization_guide/content/browser/page_content_metadata_observer.cc
  • M components/optimization_guide/content/browser/page_text_observer.cc
  • M components/page_load_metrics/browser/metrics_web_contents_observer.cc
  • M components/page_load_metrics/browser/page_load_tracker.cc
  • M components/permissions/permission_indicators_tab_data.cc
  • M components/permissions/permission_recovery_success_rate_tracker.cc
  • M components/safe_browsing/content/browser/triggers/suspicious_site_trigger.cc
  • M components/subresource_filter/content/shared/browser/child_frame_navigation_filtering_throttle.cc
  • M components/webapps/browser/installable/installable_data_fetcher.cc
  • M components/zoom/zoom_controller.cc
  • M content/browser/android/navigation_handle_proxy.cc
  • M content/browser/browsing_topics/browsing_topics_document_host.cc
  • M content/shell/browser/shell.cc
Change size: S
Delta: 41 files changed, 41 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If0f7c8fc86d26501d1590470f97aee234ef0d1a3
Gerrit-Change-Number: 6780702
Gerrit-PatchSet: 21
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages