[bedrock] fix memory/ dependency on android [chromium/src : main]
0 views
Skip to first unread message
Wenbin Zhang (Gerrit)
Mar 17, 2026, 2:54:58 AMMar 17
to Darryl James, Fumitoshi Ukai, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Darryl James and Fumitoshi Ukai
Wenbin Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Darryl James
- Fumitoshi Ukai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wenbin Zhang (Gerrit)
Mar 17, 2026, 3:34:11 AMMar 17
to Chromium LUCI CQ, Darryl James, Fumitoshi Ukai, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Darryl James and Fumitoshi Ukai
Wenbin Zhang voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Darryl James
- Fumitoshi Ukai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fumitoshi Ukai (Gerrit)
Mar 17, 2026, 3:40:02 AMMar 17
to Wenbin Zhang, Fumitoshi Ukai, Chromium LUCI CQ, Darryl James, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Darryl James and Wenbin Zhang
Fumitoshi Ukai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Darryl James
- Wenbin Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Mar 17, 2026, 1:01:52 PMMar 17
to Wenbin Zhang, Fumitoshi Ukai, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Wenbin Zhang
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Wenbin Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wenbin Zhang (Gerrit)
Mar 17, 2026, 1:19:08 PMMar 17
to Darryl James, Fumitoshi Ukai, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Wenbin Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 17, 2026, 1:23:22 PMMar 17
to Wenbin Zhang, Darryl James, Fumitoshi Ukai, chromium...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[bedrock] fix memory/ dependency on android
The issue was that on Android, the link from the code in memory:impl
back to the mojom generator was broken because resource_coordinator
wasn't publicly declaring its mojom dependency. By making this
dependency unconditional and public, we force Ninja to always generate
the headers before compiling any target that transitively includes
utils.h. This explicitly serializes the build and eliminates the race
condition on all platforms.
Bug: 493017566
Change-Id: I1dd317ba957c027e8fe603603aa1bebe96012f3d
Reviewed-by: Fumitoshi Ukai <uk...@google.com>
Auto-Submit: Wenbin Zhang <wenbi...@google.com>
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Wenbin Zhang <wenbi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1600638}
Files:
- M chrome/browser/resource_coordinator/BUILD.gn
Change size: XS
Delta: 1 file changed, 4 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James, +1 by Fumitoshi Ukai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages