Clean up MemoryPressureMonitor [chromium/src : main]
0 views
Skip to first unread message
Patrick Monette (Gerrit)
Mar 2, 2026, 9:30:20 AM (10 days ago) Mar 2
to Francois Pierre Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, tburkar...@chromium.org
Attention needed from Francois Pierre Doray
Patrick Monette added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Mar 2, 2026, 10:13:18 AM (10 days ago) Mar 2
to Patrick Monette, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, tburkar...@chromium.org
Attention needed from Patrick Monette
Francois Pierre Doray voted and added 2 comments![]( "Open in Gerrit")
Votes added by Francois Pierre Doray
| Code-Review | +1 |
| Owners-Override | +1 |
2 comments
Patchset-level comments
Francois Pierre Doray . resolved
LGTM with 1 comment
OO+1 for mechanical changes outside of //base to adapt to a change in //base
File components/memory_pressure/multi_source_memory_pressure_monitor.cc
Line 44, Patchset 6 (Latest):
CHECK(g_monitor);Francois Pierre Doray . unresolved
`CHECK_EQ(g_monitor, this);`
Related details
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Mar 2, 2026, 10:24:19 AM (10 days ago) Mar 2
to Francois Pierre Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, tburkar...@chromium.org
Patrick Monette voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Monette
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File components/memory_pressure/multi_source_memory_pressure_monitor.cc
Line 44, Patchset 6:
CHECK(g_monitor);Francois Pierre Doray . resolved
Patrick Monette`CHECK_EQ(g_monitor, this);`
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Mar 2, 2026, 12:13:05 PM (10 days ago) Mar 2
to Francois Pierre Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, tburkar...@chromium.org
Attention needed from Francois Pierre Doray
Patrick Monette voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 2, 2026, 4:02:18 PM (10 days ago) Mar 2
to Patrick Monette, Francois Pierre Doray, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/memory_pressure/multi_source_memory_pressure_monitor.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Clean up MemoryPressureMonitor
All users of GetCurrentPressureLevel have been migrated to use the
MemoryPressureListener API.
In the future, there will not be a global state for listeners to read,
as policies will be allowed to give a different state to different
listeners.
MultiSourceMemoryPressureMonitor still temporarily exists until its
functionality is migrated to the Memory Coordinator component.
Bug: 462288601
Change-Id: Iae55a351821be1f61acb9a7a2d33af9f8b9fa383
Commit-Queue: Patrick Monette <pmon...@chromium.org>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1592682}
Files:
- M base/BUILD.gn
- D base/memory/memory_pressure_monitor.cc
- D base/memory/memory_pressure_monitor.h
- M chrome/browser/chrome_browser_main_linux.cc
- M chrome/browser/dbus_memory_pressure_evaluator_linux_unittest.cc
- M chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc
- M chrome/browser/glic/glic_profile_manager_interactive_uitest.cc
- M chrome/browser/memory/chrome_browser_main_extra_parts_memory.cc
- M chrome/browser/memory/enterprise_memory_limit_pref_observer.cc
- M chrome/browser/performance_manager/chrome_browser_main_extra_parts_performance_manager.cc
- M chrome/browser/performance_manager/policies/urgent_page_discarding_policy_unittest.cc
- M chrome/browser/resource_coordinator/tab_manager.cc
- M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
- M chrome/browser/sessions/session_restore_browsertest.cc
- M chrome/browser/ui/views/tabs/tab_strip_action_container_browsertest.cc
- M chrome/test/BUILD.gn
- M chromecast/browser/cast_browser_main_parts.cc
- M components/memory_pressure/BUILD.gn
- D components/memory_pressure/fake_memory_pressure_monitor.cc
- D components/memory_pressure/fake_memory_pressure_monitor.h
- M components/memory_pressure/multi_source_memory_pressure_monitor.cc
- M components/memory_pressure/multi_source_memory_pressure_monitor.h
- M components/memory_pressure/system_memory_pressure_evaluator_mac.cc
- M components/omnibox/browser/BUILD.gn
- M components/omnibox/browser/on_device_tail_model_service_unittest.cc
- M components/paint_preview/player/BUILD.gn
- M components/performance_manager/BUILD.gn
- M content/browser/browser_main_loop.cc
- M content/browser/browser_main_loop.h
- M content/browser/preloading/prerender/prerender_host_registry.cc
- M net/quic/quic_session_pool.h
- M net/ssl/ssl_client_session_cache.h
- M testing/variations/fieldtrial_testing_config.json
Change size: L
Delta: 33 files changed, 58 insertions(+), 319 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Francois Pierre Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages