Remove superfluous field_trial_params.h includes from various headers [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Nov 24, 2025, 5:30:48 PM (5 days ago) Nov 24
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, Peter Williamson, Chromium LUCI CQ, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, csharris...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, harringt...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loading...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, ozone-...@chromium.org, petewi...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I96c886cd63a7d87627a3f8d8a10a0a6091eedb9f
Gerrit-Change-Number: 7184936
Gerrit-PatchSet: 4
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 24 Nov 2025 22:30:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Nov 24, 2025, 7:22:28 PM (5 days ago) Nov 24
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, Peter Williamson, Chromium LUCI CQ, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, csharris...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, harringt...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loading...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, ozone-...@chromium.org, petewi...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I96c886cd63a7d87627a3f8d8a10a0a6091eedb9f
Gerrit-Change-Number: 7184936
Gerrit-PatchSet: 4
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 00:22:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Nov 25, 2025, 6:35:10 PM (4 days ago) Nov 25
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, Peter Williamson, Chromium LUCI CQ, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, csharris...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, harringt...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loading...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, ozone-...@chromium.org, petewi...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Lei Zhang . resolved

Another cleanup CL made this CL fail in patch set 5, so had to do one more IWYU which then invalidated the CR+1/OO+1.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I96c886cd63a7d87627a3f8d8a10a0a6091eedb9f
Gerrit-Change-Number: 7184936
Gerrit-PatchSet: 6
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 23:35:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Nov 25, 2025, 9:33:56 PM (4 days ago) Nov 25
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, Peter Williamson, Chromium LUCI CQ, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, csharris...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, harringt...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loading...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, ozone-...@chromium.org, petewi...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I96c886cd63a7d87627a3f8d8a10a0a6091eedb9f
Gerrit-Change-Number: 7184936
Gerrit-PatchSet: 6
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Nov 2025 02:33:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 25, 2025, 9:37:22 PM (4 days ago) Nov 25
to Lei Zhang, Daniel Cheng, Akihiro Ota, chromium...@chromium.org, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, Peter Williamson, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, csharris...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, harringt...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loading...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, ozone-...@chromium.org, petewi...@chromium.org, scheduler-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove superfluous field_trial_params.h includes from various headers

Remove base/metrics/field_trial_params.h includes from headers that do
not reference BASE_DECLARE_FEATURE_PARAM, FieldTrialParam, or
FeatureParam. Then do IWYU to fix the build.
Bug: 40318405
Change-Id: I96c886cd63a7d87627a3f8d8a10a0a6091eedb9f
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1550194}
Files:
  • M chrome/browser/actor/actor_test_util.h
  • M chrome/browser/component_updater/wasm_tts_engine_component_installer.cc
  • M chrome/browser/lookalikes/lookalike_url_service.h
  • M chrome/browser/resource_coordinator/tab_manager_features.h
  • M chrome/browser/ui/toasts/toast_features.h
  • M components/assist_ranker/predictor_config_definitions.h
  • M components/compose/core/browser/compose_features.h
  • M components/cronet/url_request_context_config.h
  • M components/download/public/common/download_features.h
  • M components/error_page/common/alt_game_image_data.h
  • M components/feed/feed_feature_list.h
  • M components/history_clusters/core/on_device_clustering_features.h
  • M components/messages/android/messages_feature.h
  • M components/metrics/metrics_features.h
  • M components/metrics/metrics_service_client.cc
  • M components/metrics/metrics_service_client.h
  • M components/metrics/structured/structured_metrics_features.cc
  • M components/metrics/structured/structured_metrics_features.h
  • M components/page_load_metrics/browser/observers/ad_metrics/ads_page_load_metrics_observer.h
  • M components/push_messaging/push_messaging_features.h
  • M components/safe_browsing/content/renderer/phishing_classifier/features.h
  • M components/services/storage/service_worker/service_worker_storage.h
  • M components/sharing_message/features.cc
  • M components/sharing_message/features.h
  • M components/translate/core/common/translate_util.h
  • M components/trusted_vault/features.h
  • M components/viz/service/performance_hint/boost_manager.h
  • M content/browser/interest_group/interest_group_auction_reporter.h
  • M content/browser/loader/keep_alive_url_loader.h
  • M content/browser/service_worker/service_worker_registry.h
  • M ios/chrome/app/chrome_main.mm
  • M ios/chrome/browser/composebox/public/features.h
  • M ios/chrome/browser/intelligence/features/features.h
  • M ios/chrome/browser/reader_mode/model/features.h
  • M media/capabilities/webrtc_video_stats_db_impl.h
  • M media/mojo/services/webrtc_video_perf_history.h
  • M third_party/blink/renderer/core/loader/anchor_element_interaction_tracker.h
  • M third_party/blink/renderer/modules/peerconnection/peer_connection_features.h
  • M third_party/blink/renderer/platform/scheduler/common/features.h
  • M ui/accessibility/accessibility_features.cc
  • M ui/accessibility/accessibility_features.h
  • M ui/events/ozone/evdev/touch_event_converter_evdev.h
  • M ui/events/ozone/evdev/touch_filter/palm_detection_filter_factory.h
Change size: S
Delta: 43 files changed, 8 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I96c886cd63a7d87627a3f8d8a10a0a6091eedb9f
Gerrit-Change-Number: 7184936
Gerrit-PatchSet: 7
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages