Migrate base::Contains() to std::ranges::contains() in services [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Jan 13, 2026, 11:01:50 AM (4 days ago) Jan 13
to Daniel Cheng, Hu, Ningxin, Jiewei Qian, Raphael Kubo da Costa, (Julie)Jeongeun Kim, Lin, Wanming, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, olka+...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, chfreme...@chromium.org, odejesu...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, chrome-gr...@chromium.org, katie...@chromium.org, josiah...@chromium.org, mattreyno...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, mkwst+w...@chromium.org, yuzo+...@chromium.org, network-ser...@chromium.org, marinacio...@chromium.org
Attention needed from Daniel Cheng

Victor Vianna voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84b3f6d245d62ea4d7a1e812104132b40dff62df
Gerrit-Change-Number: 7461025
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 16:01:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 13, 2026, 2:49:16 PM (4 days ago) Jan 13
to Victor Vianna, Daniel Cheng, Hu, Ningxin, Jiewei Qian, Raphael Kubo da Costa, (Julie)Jeongeun Kim, Lin, Wanming, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, olka+...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, chfreme...@chromium.org, odejesu...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, chrome-gr...@chromium.org, katie...@chromium.org, josiah...@chromium.org, mattreyno...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, mkwst+w...@chromium.org, yuzo+...@chromium.org, network-ser...@chromium.org, marinacio...@chromium.org
Attention needed from Victor Vianna

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84b3f6d245d62ea4d7a1e812104132b40dff62df
Gerrit-Change-Number: 7461025
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:49:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 13, 2026, 3:04:20 PM (4 days ago) Jan 13
to Victor Vianna, Daniel Cheng, Hu, Ningxin, Akihiro Ota, Jiewei Qian, Raphael Kubo da Costa, (Julie)Jeongeun Kim, Lin, Wanming, Rijubrata Bhaumik, AyeAye, olka+...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, chfreme...@chromium.org, odejesu...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, chrome-gr...@chromium.org, katie...@chromium.org, josiah...@chromium.org, mattreyno...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, mkwst+w...@chromium.org, yuzo+...@chromium.org, network-ser...@chromium.org, marinacio...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Migrate base::Contains() to std::ranges::contains() in services

base::Contains() is an alias to std::ranges::contains() since
crrev.com/c/7415207, so this CL has no behavior change.
Bug: 470391351
Change-Id: I84b3f6d245d62ea4d7a1e812104132b40dff62df
Auto-Submit: Victor Vianna <victor...@google.com>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568616}
Files:
  • M services/accessibility/android/auto_complete_handler_unittest.cc
  • M services/audio/output_controller.cc
  • M services/device/generic_sensor/platform_sensor_provider_chromeos.cc
  • M services/device/hid/hid_connection.cc
  • M services/device/hid/hid_connection_win.cc
  • M services/device/public/cpp/hid/hid_blocklist.cc
  • M services/device/public/cpp/hid/hid_report_utils.cc
  • M services/device/usb/usb_service_android.cc
  • M services/device/usb/usb_service_impl.cc
  • M services/image_annotation/annotator.cc
  • M services/image_annotation/annotator_unittest.cc
  • M services/network/accept_ch_frame_interceptor.cc
  • M services/network/cors/cors_url_loader.cc
  • M services/network/device_bound_session_manager.cc
  • M services/network/prefetch_matches.cc
  • M services/network/public/cpp/content_security_policy/content_security_policy.cc
  • M services/network/public/cpp/content_security_policy/content_security_policy_unittest.cc
  • M services/network/public/cpp/content_security_policy/csp_context.cc
  • M services/network/public/cpp/is_potentially_trustworthy.cc
  • M services/network/public/cpp/parsed_headers.cc
  • M services/network/public/cpp/permissions_policy/permissions_policy.cc
  • M services/network/public/cpp/sri_message_signatures.cc
  • M services/network/public/cpp/timing_allow_origin_parser.cc
  • M services/network/shared_storage/shared_storage_request_helper.cc
  • M services/network/trust_tokens/expiry_inspecting_record_expiry_delegate.cc
  • M services/network/trust_tokens/trust_token_store.cc
  • M services/resource_coordinator/memory_instrumentation/graph.cc
  • M services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
  • M services/service_manager/public/cpp/service_executable/main.cc
  • M services/video_capture/device_factory_impl.cc
  • M services/video_capture/public/cpp/mock_video_frame_handler.cc
  • M services/video_capture/shared_memory_virtual_device_mojo_adapter.cc
  • M services/video_capture/test/virtual_device_unittest.cc
  • M services/viz/public/cpp/compositing/compositor_frame_metadata_mojom_traits.cc
  • M services/webnn/public/cpp/graph_validation_utils.cc
  • M services/webnn/webnn_graph_impl_unittest.cc
Change size: M
Delta: 36 files changed, 120 insertions(+), 110 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84b3f6d245d62ea4d7a1e812104132b40dff62df
Gerrit-Change-Number: 7461025
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages