Avoid continuously reparsing NTP url [chromium/src : main]

0 views
Skip to first unread message

Antonio Sartori (Gerrit)

unread,
Apr 20, 2026, 11:33:59 AM (5 days ago) Apr 20
to Marc Treib, chromium...@chromium.org, cros-print...@google.com, chrome-gr...@chromium.org, browser-comp...@chromium.org, subresource-f...@chromium.org, print-rev...@chromium.org
Attention needed from Marc Treib

Antonio Sartori has uploaded the change for review

Antonio Sartori would like Marc Treib to review this change.

Commit message

Avoid continuously reparsing NTP url

This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in ['chrome/browser', 'chrome/browser/first_run', 'chrome/browser/history', 'chrome/browser/printing', 'chrome/browser/privacy_sandbox', 'chrome/browser/resource_coordinator', 'chrome/browser/subresource_filter'], avoiding
parsing GURL again and again.

This CL was uploaded by git cl split.

R=tr...@chromium.org
Bug: 503370195
Change-Id: I74c0ac447e2c9c0ae7f6190e3b0986891e6ac5e6

Change diff


Change information

Files:
  • M chrome/browser/browser_process_platform_part_ash_browsertest.cc
  • M chrome/browser/chrome_content_browser_client.cc
  • M chrome/browser/chrome_content_browser_client_browsertest.cc
  • M chrome/browser/chrome_content_browser_client_unittest.cc
  • M chrome/browser/first_run/first_run_browsertest.cc
  • M chrome/browser/history/history_browsertest.cc
  • M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
  • M chrome/browser/privacy_sandbox/notice/desktop_entrypoint_handlers_helper.cc
  • M chrome/browser/resource_coordinator/tab_manager_unittest.cc
  • M chrome/browser/subresource_filter/subresource_filter_disabled_reason_uma_browsertest.cc
Change size: S
Delta: 10 files changed, 20 insertions(+), 19 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Marc Treib
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I74c0ac447e2c9c0ae7f6190e3b0986891e6ac5e6
Gerrit-Change-Number: 7775560
Gerrit-PatchSet: 1
Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
Gerrit-Attention: Marc Treib <tr...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Marc Treib (Gerrit)

unread,
Apr 20, 2026, 12:01:48 PM (5 days ago) Apr 20
to Antonio Sartori, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, cros-print...@google.com, print-rev...@chromium.org, subresource-f...@chromium.org
Attention needed from Antonio Sartori

Marc Treib voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Antonio Sartori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I74c0ac447e2c9c0ae7f6190e3b0986891e6ac5e6
Gerrit-Change-Number: 7775560
Gerrit-PatchSet: 1
Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Apr 2026 16:01:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 20, 2026, 1:01:47 PM (5 days ago) Apr 20
to Antonio Sartori, Marc Treib, chromium...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, cros-print...@google.com, print-rev...@chromium.org, subresource-f...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Avoid continuously reparsing NTP url

This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in ['chrome/browser', 'chrome/browser/first_run', 'chrome/browser/history', 'chrome/browser/printing', 'chrome/browser/privacy_sandbox', 'chrome/browser/resource_coordinator', 'chrome/browser/subresource_filter'], avoiding
parsing GURL again and again.

This CL was uploaded by git cl split.

R=tr...@chromium.org
Bug: 503370195
Change-Id: I74c0ac447e2c9c0ae7f6190e3b0986891e6ac5e6
Commit-Queue: Marc Treib <tr...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617570}
Files:
  • M chrome/browser/browser_process_platform_part_ash_browsertest.cc
  • M chrome/browser/chrome_content_browser_client.cc
  • M chrome/browser/chrome_content_browser_client_browsertest.cc
  • M chrome/browser/chrome_content_browser_client_unittest.cc
  • M chrome/browser/first_run/first_run_browsertest.cc
  • M chrome/browser/history/history_browsertest.cc
  • M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
  • M chrome/browser/privacy_sandbox/notice/desktop_entrypoint_handlers_helper.cc
  • M chrome/browser/resource_coordinator/tab_manager_unittest.cc
  • M chrome/browser/subresource_filter/subresource_filter_disabled_reason_uma_browsertest.cc
Change size: S
Delta: 10 files changed, 20 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Marc Treib
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I74c0ac447e2c9c0ae7f6190e3b0986891e6ac5e6
Gerrit-Change-Number: 7775560
Gerrit-PatchSet: 2
Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages