[Desktop android] Implement DiscardTab [chromium/src : main]
0 views
Skip to first unread message
Kelvin Jiang (Gerrit)
Dec 30, 2025, 5:24:40 PM12/30/25
to David Pennington, AyeAye, Chromium LUCI CQ, Alison Gale, chromium...@chromium.org, chrome-gr...@chromium.org, permissio...@chromium.org
Attention needed from David Pennington
Kelvin Jiang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kelvin Jiang
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kelvin Jiang . resolved
Quick fix by componentizing tab_lifecycle_unit_external.h out of c/b/BUILD
+David for BUILD OWNERs stamp (c/b/permissions and c/b/resource_coordinator)
Related details
Attention is currently required from:
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Pennington (Gerrit)
Dec 30, 2025, 5:43:38 PM12/30/25
to Kelvin Jiang, AyeAye, Chromium LUCI CQ, Alison Gale, chromium...@chromium.org, chrome-gr...@chromium.org, permissio...@chromium.org
Attention needed from Kelvin Jiang
David Pennington added 4 comments![]( "Open in Gerrit")
Commit Message
File chrome/browser/permissions/BUILD.gn
Line 65, Patchset 2 (Latest):
"//chrome/browser/resource_coordinator",David Pennington . unresolved
does this need to be in public deps? could it just go in the non-public deps?
File chrome/browser/resource_coordinator/BUILD.gn
Line 21, Patchset 2 (Latest):
"tab_lifecycle_unit_external.h",David Pennington . unresolved
how does this apply to android if it's removed from the andriod source set?
File chrome/browser/ui/tabs/tab_list_bridge.cc
Line 112, Patchset 2 (Latest):
content::WebContents* contents = tab_strip_->GetWebContentsAt(index);David Pennington . unresolved
could we use the tabHandles TabInterface instead of getting the index and then getting the tab from the index?
Related details
Attention is currently required from:
- Kelvin Jiang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kelvin Jiang (Gerrit)
Jan 5, 2026, 3:58:10 PM (12 days ago) Jan 5
to David Pennington, AyeAye, Chromium LUCI CQ, Alison Gale, chromium...@chromium.org, chrome-gr...@chromium.org, permissio...@chromium.org
Attention needed from David Pennington
Kelvin Jiang voted and added 4 comments![]( "Open in Gerrit")
Votes added by Kelvin Jiang
| Auto-Submit | +1 |
| Commit-Queue | +1 |
4 comments
Commit Message
File chrome/browser/permissions/BUILD.gn
does this need to be in public deps? could it just go in the non-public deps?
Kelvin Jiang
Done
File chrome/browser/resource_coordinator/BUILD.gn
how does this apply to android if it's removed from the andriod source set?
Kelvin Jiang
It... doesn't since I'm just filling out TabListBridge which is the desktop (non Android) implementation of TabListInterface
Going to change the CL title to reflect this
File chrome/browser/ui/tabs/tab_list_bridge.cc
Line 112, Patchset 2:
content::WebContents* contents = tab_strip_->GetWebContentsAt(index);David Pennington . resolved
could we use the tabHandles TabInterface instead of getting the index and then getting the tab from the index?
Attention is currently required from:
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Pennington (Gerrit)
Jan 5, 2026, 4:35:53 PM (12 days ago) Jan 5
to Kelvin Jiang, AyeAye, Chromium LUCI CQ, Alison Gale, chromium...@chromium.org, chrome-gr...@chromium.org, permissio...@chromium.org
Attention needed from Kelvin Jiang
David Pennington voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kelvin Jiang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kelvin Jiang (Gerrit)
Jan 6, 2026, 12:36:24 PM (11 days ago) Jan 6
to David Pennington, AyeAye, Chromium LUCI CQ, Alison Gale, chromium...@chromium.org, chrome-gr...@chromium.org, permissio...@chromium.org
Kelvin Jiang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 6, 2026, 12:39:39 PM (11 days ago) Jan 6
to Kelvin Jiang, David Pennington, AyeAye, Alison Gale, chromium...@chromium.org, chrome-gr...@chromium.org, permissio...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[TabListBridge] Implement DiscardTab
Implement DiscardTab inside TabListBridge (TabListInterface's desktop
implementation). This CL also spins out tab_lifecycle_unit_external.h
into the chrome/browser/resource_coordinator BUILD file
Bug: 460650221
Change-Id: Ifd72923e5633ed23eafa004836169998f8ac8563
Reviewed-by: David Pennington <dpen...@chromium.org>
Commit-Queue: Kelvin Jiang <kelvi...@chromium.org>
Auto-Submit: Kelvin Jiang <kelvi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1565061}
Files:
- M chrome/browser/BUILD.gn
- M chrome/browser/permissions/BUILD.gn
- M chrome/browser/resource_coordinator/BUILD.gn
- M chrome/browser/ui/tabs/BUILD.gn
- M chrome/browser/ui/tabs/organization/BUILD.gn
- M chrome/browser/ui/tabs/tab_list_bridge.cc
- M chrome/browser/ui/tabs/tab_list_bridge_browsertest.cc
Change size: M
Delta: 7 files changed, 49 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Pennington
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages