Remove TabLoader based tab restore code [3/3] [chromium/src : main]
0 views
Skip to first unread message
Joe Mason (Gerrit)
Jan 15, 2026, 2:47:57 PMJan 15
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Darryl James
Joe Mason voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Jan 15, 2026, 3:08:34 PMJan 15
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Joe Mason
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Jan 19, 2026, 12:11:04 PMJan 19
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Joe Mason voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 19, 2026, 12:50:56 PMJan 19
to Darryl James, chromium...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove TabLoader based tab restore code [3/3]
Now that BackgroundTabLoadingFromPerformanceManager has launched, the
older tab restore code path can be removed.
This removes TabLoader, which is now unused, and classes that are only
used to support it: TabLoaderDelegate, TabLoaderTester, and
SessionRestorePolicy.
Bug: 427952137
Fixed: 427952137
Change-Id: Ia0714cf346ece9cfdfdbc80fd44e4ca0a6a03727
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Joe Mason <joenot...@google.com>
Cr-Commit-Position: refs/heads/main@{#1571266}
Files:
- M chrome/browser/BUILD.gn
- D chrome/browser/resource_coordinator/session_restore_policy.cc
- D chrome/browser/resource_coordinator/session_restore_policy.h
- D chrome/browser/resource_coordinator/session_restore_policy_unittest.cc
- M chrome/browser/resource_coordinator/tab_manager_unittest.cc
- M chrome/browser/sessions/session_restore_browsertest.cc
- M chrome/browser/sessions/session_restore_stats_collector.h
- M chrome/browser/sessions/session_restore_test_utils.cc
- M chrome/browser/sessions/session_restore_test_utils.h
- M chrome/browser/sessions/session_service_log_browsertest.cc
- D chrome/browser/sessions/tab_loader.cc
- D chrome/browser/sessions/tab_loader.h
- D chrome/browser/sessions/tab_loader_delegate.cc
- D chrome/browser/sessions/tab_loader_delegate.h
- D chrome/browser/sessions/tab_loader_tester.cc
- D chrome/browser/sessions/tab_loader_tester.h
- D chrome/browser/sessions/tab_loader_unittest.cc
- M chrome/browser/ui/browser_tabrestore_browsertest.cc
- M chrome/test/BUILD.gn
Change size: XL
Delta: 19 files changed, 9 insertions(+), 3606 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages