[base] Use ByteCount in SmapsRollup [chromium/src : main]

0 views
Skip to first unread message

Thiabaud Engelbrecht (Gerrit)

unread,
Aug 8, 2025, 12:07:06 PM8/8/25
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Francois Pierre Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I33859fb23a3378ce3f81b9c4dc6d6358bd678e2d
Gerrit-Change-Number: 6764412
Gerrit-PatchSet: 2
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Fri, 08 Aug 2025 16:06:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Aug 12, 2025, 10:13:22 AM8/12/25
to Thiabaud Engelbrecht, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Thiabaud Engelbrecht

Francois Pierre Doray voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I33859fb23a3378ce3f81b9c4dc6d6358bd678e2d
Gerrit-Change-Number: 6764412
Gerrit-PatchSet: 2
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 14:13:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thiabaud Engelbrecht (Gerrit)

unread,
Aug 12, 2025, 10:19:30 AM8/12/25
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org

Thiabaud Engelbrecht voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I33859fb23a3378ce3f81b9c4dc6d6358bd678e2d
Gerrit-Change-Number: 6764412
Gerrit-PatchSet: 2
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 14:19:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 12, 2025, 11:18:31 AM8/12/25
to Thiabaud Engelbrecht, Francois Pierre Doray, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[base] Use ByteCount in SmapsRollup
Bug: 429140103
Change-Id: I33859fb23a3378ce3f81b9c4dc6d6358bd678e2d
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Commit-Queue: Thiabaud Engelbrecht <thia...@google.com>
Cr-Commit-Position: refs/heads/main@{#1500159}
Files:
  • M base/android/self_compaction_manager.cc
  • M base/android/self_compaction_manager.h
  • M base/debug/proc_maps_linux.cc
  • M base/debug/proc_maps_linux.h
  • M base/debug/proc_maps_linux_unittest.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_linux.cc
Change size: M
Delta: 6 files changed, 39 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I33859fb23a3378ce3f81b9c4dc6d6358bd678e2d
Gerrit-Change-Number: 6764412
Gerrit-PatchSet: 3
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages