Victor, could you take a look? Thanks.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
How was this change written?
I ran a local script which was generated by Gemini. Then I verified the change in local build and CQ (sorry the previous description missed "Test" field).
Originally the script was for the ash refactoring (reducing the dependency between ash and browser). While I'm doing it, I'm cleaning up the other directories.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
This CL removes:Yoshiki IGUCHIHow was this change written?
I ran a local script which was generated by Gemini. Then I verified the change in local build and CQ (sorry the previous description missed "Test" field).
Originally the script was for the ash refactoring (reducing the dependency between ash and browser). While I'm doing it, I'm cleaning up the other directories.
Sorry, this CL slipped my mind, in the future feel free to ping after 24h.
It looks like you only remove string headers. I expected you to be doing that based on the absence of "IDS_" in those files, but it looks like some of them do have string usages
$ git show HEAD --name-only --pretty="" | xargs git grep -l IDS_
chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc
chrome/browser/chooser_controller/title_util_unittest.cc
chrome/browser/chrome_browser_main.cc
chrome/browser/contextual_cueing/contextual_cueing_menu_model.cc
chrome/browser/device_notifications/device_status_icon_renderer.cc
chrome/browser/download/download_item_model.cc
chrome/browser/enterprise/data_controls/android_data_controls_dialog.cc
chrome/browser/enterprise/data_controls/desktop_data_controls_dialog.cc
chrome/browser/extensions/api/autofill_private/autofill_util.cc
chrome/browser/extensions/api/developer_private/extension_info_generator.cc
chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
chrome/browser/extensions/api/webstore_private/extension_install_status_unittest.cc
chrome/browser/glic/selection/selection_overlay_untrusted_ui.cc
chrome/browser/history/top_sites_factory.cc
chrome/browser/keyboard_accessory/android/address_accessory_controller_impl_unittest.cc
chrome/browser/lookalikes/safety_tip_message_delegate_android.cc
chrome/browser/lookalikes/safety_tip_message_delegate_android_unittest.cc
chrome/browser/new_tab_page/modules/v2/most_relevant_tab_resumption/most_relevant_tab_resumption_page_handler.cc
chrome/browser/new_tab_page/ntp_promo/ntp_promo_interactive_uitest.cc
chrome/browser/notifications/win/notification_template_builder.cc
chrome/browser/password_manager/android/auto_signin_prompt_controller.cc
chrome/browser/prefs/chrome_pref_service_factory.cc
chrome/browser/profiles/batch_upload/batch_upload_browsertest.cc
chrome/browser/sharing/sms/sms_remote_fetcher_ui_controller.cc
chrome/browser/signin/signin_util.cc
chrome/browser/ssl/known_interception_disclosure_message_delegate.cc
chrome/browser/task_manager/task_manager_browsertest.cc
chrome/browser/win/installer_downloader/installer_downloader_infobar_delegate.cc
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
This CL removes:I wrote a script that checks the remaining strings are not in the removed headers, so LGTM
They are including other strings headers and using strings in these header file. For example, the first `browsing_data_counter_utils.cc` includes "components/strings/grit/components_strings.h".
---
Just in case, I double-checked it:
Only the following 7 header files includes "chrome/grit/generated_resources.h"
```
$ git grep -l "chrome/grit/generated_resources.h" | grep '\.h$'
chrome/browser/importer/importer_lock_dialog.h
chrome/browser/new_tab_page/chrome_colors/selected_colors_info.h
chrome/browser/task_manager/mock_web_contents_task_manager.h
chrome/browser/ui/task_manager/task_manager_columns.h
chrome/browser/ui/views/glic/glic_actor_task_icon.h
chrome/browser/ui/views/glic/glic_button.h
chrome/browser/ui/views/importer/import_lock_dialog_view.h
```
And any of your listed files don't include any the above header files:
```
$ git show HEAD --name-only --pretty="" | xargs git grep -l IDS_ | xargs grep -E 'chrome/browser/importer/importer_lock_dialog\.h|chrome/browser/new_tab_page/chrome_colors/selected_colors_info\.h|chrome/browser/task_manager/mock_web_contents_task_manager\.h|chrome/browser/ui/task_manager/task_manager_columns\.h|chrome/browser/ui/views/glic/glic_actor_task_icon\.h|chrome/browser/ui/views/glic/glic_button\.h|chrome/browser/ui/views/importer/import_lock_dialog_view\.h' | wc -l
0
```
Ah, I sent a reply before reading the your second comment. Thank you for your double checking!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Clean up 100 includes and dependencies in C/B
This CL removes:
- 87 unnecessary includes from 83 .cc files
- 23 unnecessary deps from 20 BUILD.gn files
- 1 unnecessary deps from 1 DEPS files
The following directories are processed separately:
- chrome/browser/ash/: crrev.com/c/7877944
- chrome/browser/ui/ash: crrev.com/c/7882518
- chrome/browser/ui/views: crrev.com/c/7882777
- chrome/browser/webui/ash: crrev.com/c/7881202
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |