Clean up 100 includes and dependencies in C/B [chromium/src : main]

0 views
Skip to first unread message

Yoshiki IGUCHI (Gerrit)

unread,
Jun 9, 2026, 1:29:42 AMJun 9
to Yoshiki IGUCHI, Victor Vianna, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org
Attention needed from Victor Vianna

Yoshiki IGUCHI added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Yoshiki IGUCHI . resolved

Victor, could you take a look? Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibe1562e46d704a0371a9ef982c0cdd9e5509740b
Gerrit-Change-Number: 7885043
Gerrit-PatchSet: 7
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Di Wu <di...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 05:29:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Jun 9, 2026, 4:34:28 AMJun 9
to Yoshiki IGUCHI, SLSA Policy Verification Service, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org
Attention needed from Yoshiki IGUCHI

Victor Vianna added 1 comment

Commit Message
Line 9, Patchset 7 (Latest):This CL removes:
Victor Vianna . unresolved

How was this change written?

Open in Gerrit

Related details

Attention is currently required from:
  • Yoshiki IGUCHI
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibe1562e46d704a0371a9ef982c0cdd9e5509740b
    Gerrit-Change-Number: 7885043
    Gerrit-PatchSet: 7
    Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Di Wu <di...@google.com>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Yoshiki IGUCHI <yos...@chromium.org>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 08:34:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yoshiki IGUCHI (Gerrit)

    unread,
    Jun 9, 2026, 4:43:52 AMJun 9
    to Yoshiki IGUCHI, SLSA Policy Verification Service, Victor Vianna, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org
    Attention needed from Victor Vianna

    Yoshiki IGUCHI added 1 comment

    Commit Message
    Line 9, Patchset 7:This CL removes:
    Victor Vianna . resolved

    How was this change written?

    Yoshiki IGUCHI

    I ran a local script which was generated by Gemini. Then I verified the change in local build and CQ (sorry the previous description missed "Test" field).

    Originally the script was for the ash refactoring (reducing the dependency between ash and browser). While I'm doing it, I'm cleaning up the other directories.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Victor Vianna
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ibe1562e46d704a0371a9ef982c0cdd9e5509740b
      Gerrit-Change-Number: 7885043
      Gerrit-PatchSet: 8
      Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
      Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
      Gerrit-Reviewer: Victor Vianna <victor...@google.com>
      Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Di Wu <di...@google.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Victor Vianna <victor...@google.com>
      Gerrit-Comment-Date: Tue, 09 Jun 2026 08:43:20 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Victor Vianna <victor...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Victor Vianna (Gerrit)

      unread,
      Jun 16, 2026, 10:58:08 AM (11 days ago) Jun 16
      to Yoshiki IGUCHI, Code Review Nudger, SLSA Policy Verification Service, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org
      Attention needed from Yoshiki IGUCHI

      Victor Vianna added 1 comment

      Commit Message
      Line 9, Patchset 7:This CL removes:
      Victor Vianna . unresolved

      How was this change written?

      Yoshiki IGUCHI

      I ran a local script which was generated by Gemini. Then I verified the change in local build and CQ (sorry the previous description missed "Test" field).

      Originally the script was for the ash refactoring (reducing the dependency between ash and browser). While I'm doing it, I'm cleaning up the other directories.

      Victor Vianna

      Sorry, this CL slipped my mind, in the future feel free to ping after 24h.
      It looks like you only remove string headers. I expected you to be doing that based on the absence of "IDS_" in those files, but it looks like some of them do have string usages

      $ git show HEAD --name-only --pretty="" | xargs git grep -l IDS_
      chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc
      chrome/browser/chooser_controller/title_util_unittest.cc
      chrome/browser/chrome_browser_main.cc
      chrome/browser/contextual_cueing/contextual_cueing_menu_model.cc
      chrome/browser/device_notifications/device_status_icon_renderer.cc
      chrome/browser/download/download_item_model.cc
      chrome/browser/enterprise/data_controls/android_data_controls_dialog.cc
      chrome/browser/enterprise/data_controls/desktop_data_controls_dialog.cc
      chrome/browser/extensions/api/autofill_private/autofill_util.cc
      chrome/browser/extensions/api/developer_private/extension_info_generator.cc
      chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
      chrome/browser/extensions/api/webstore_private/extension_install_status_unittest.cc
      chrome/browser/glic/selection/selection_overlay_untrusted_ui.cc
      chrome/browser/history/top_sites_factory.cc
      chrome/browser/keyboard_accessory/android/address_accessory_controller_impl_unittest.cc
      chrome/browser/lookalikes/safety_tip_message_delegate_android.cc
      chrome/browser/lookalikes/safety_tip_message_delegate_android_unittest.cc
      chrome/browser/new_tab_page/modules/v2/most_relevant_tab_resumption/most_relevant_tab_resumption_page_handler.cc
      chrome/browser/new_tab_page/ntp_promo/ntp_promo_interactive_uitest.cc
      chrome/browser/notifications/win/notification_template_builder.cc
      chrome/browser/password_manager/android/auto_signin_prompt_controller.cc
      chrome/browser/prefs/chrome_pref_service_factory.cc
      chrome/browser/profiles/batch_upload/batch_upload_browsertest.cc
      chrome/browser/sharing/sms/sms_remote_fetcher_ui_controller.cc
      chrome/browser/signin/signin_util.cc
      chrome/browser/ssl/known_interception_disclosure_message_delegate.cc
      chrome/browser/task_manager/task_manager_browsertest.cc
      chrome/browser/win/installer_downloader/installer_downloader_infobar_delegate.cc

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Yoshiki IGUCHI
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ibe1562e46d704a0371a9ef982c0cdd9e5509740b
        Gerrit-Change-Number: 7885043
        Gerrit-PatchSet: 8
        Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
        Gerrit-Reviewer: Victor Vianna <victor...@google.com>
        Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: Di Wu <di...@google.com>
        Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
        Gerrit-CC: Peter Beverloo <pe...@chromium.org>
        Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
        Gerrit-CC: Simon Hangl <sim...@google.com>
        Gerrit-Attention: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-Comment-Date: Tue, 16 Jun 2026 14:57:50 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Yoshiki IGUCHI <yos...@chromium.org>
        Comment-In-Reply-To: Victor Vianna <victor...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Victor Vianna (Gerrit)

        unread,
        Jun 16, 2026, 11:11:11 AM (11 days ago) Jun 16
        to Yoshiki IGUCHI, Code Review Nudger, SLSA Policy Verification Service, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org
        Attention needed from Yoshiki IGUCHI

        Victor Vianna voted and added 1 comment

        Votes added by Victor Vianna

        Code-Review+1

        1 comment

        Commit Message
        Line 9, Patchset 7:This CL removes:
        Victor Vianna . resolved
        Victor Vianna

        I wrote a script that checks the remaining strings are not in the removed headers, so LGTM

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Yoshiki IGUCHI
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Gerrit-Comment-Date: Tue, 16 Jun 2026 15:10:45 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Yoshiki IGUCHI (Gerrit)

        unread,
        Jun 16, 2026, 11:25:33 AM (11 days ago) Jun 16
        to Yoshiki IGUCHI, Victor Vianna, Code Review Nudger, SLSA Policy Verification Service, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org
        Attention needed from Victor Vianna

        Yoshiki IGUCHI added 1 comment

        Commit Message
        Yoshiki IGUCHI

        They are including other strings headers and using strings in these header file. For example, the first `browsing_data_counter_utils.cc` includes "components/strings/grit/components_strings.h".

        ---

        Just in case, I double-checked it:

        Only the following 7 header files includes "chrome/grit/generated_resources.h"
        ```
        $ git grep -l "chrome/grit/generated_resources.h" | grep '\.h$'
        chrome/browser/importer/importer_lock_dialog.h
        chrome/browser/new_tab_page/chrome_colors/selected_colors_info.h
        chrome/browser/task_manager/mock_web_contents_task_manager.h
        chrome/browser/ui/task_manager/task_manager_columns.h
        chrome/browser/ui/views/glic/glic_actor_task_icon.h
        chrome/browser/ui/views/glic/glic_button.h
        chrome/browser/ui/views/importer/import_lock_dialog_view.h
        ```

        And any of your listed files don't include any the above header files:
        ```
        $ git show HEAD --name-only --pretty="" | xargs git grep -l IDS_ | xargs grep -E 'chrome/browser/importer/importer_lock_dialog\.h|chrome/browser/new_tab_page/chrome_colors/selected_colors_info\.h|chrome/browser/task_manager/mock_web_contents_task_manager\.h|chrome/browser/ui/task_manager/task_manager_columns\.h|chrome/browser/ui/views/glic/glic_actor_task_icon\.h|chrome/browser/ui/views/glic/glic_button\.h|chrome/browser/ui/views/importer/import_lock_dialog_view\.h' | wc -l
        0
        ```

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Victor Vianna
        Gerrit-Attention: Victor Vianna <victor...@google.com>
        Gerrit-Comment-Date: Tue, 16 Jun 2026 15:24:47 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy

        Victor Vianna (Gerrit)

        unread,
        Jun 16, 2026, 11:26:29 AM (11 days ago) Jun 16
        to Yoshiki IGUCHI, Code Review Nudger, SLSA Policy Verification Service, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org
        Attention needed from Yoshiki IGUCHI

        Victor Vianna added 1 comment

        Commit Message
        Victor Vianna

        Ack, thanks for checking

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Yoshiki IGUCHI
        Gerrit-Attention: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-Comment-Date: Tue, 16 Jun 2026 15:26:05 +0000
        satisfied_requirement
        open
        diffy

        Yoshiki IGUCHI (Gerrit)

        unread,
        Jun 16, 2026, 11:27:47 AM (11 days ago) Jun 16
        to Yoshiki IGUCHI, Code Review Nudger, SLSA Policy Verification Service, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org

        Yoshiki IGUCHI added 1 comment

        Commit Message
        Yoshiki IGUCHI

        Ah, I sent a reply before reading the your second comment. Thank you for your double checking!

        Open in Gerrit

        Related details

        Attention set is empty
        Gerrit-Comment-Date: Tue, 16 Jun 2026 15:26:54 +0000
        satisfied_requirement
        open
        diffy

        Yoshiki IGUCHI (Gerrit)

        unread,
        Jun 16, 2026, 11:41:58 AM (11 days ago) Jun 16
        to Yoshiki IGUCHI, SLSA Policy Verification Service, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org

        Yoshiki IGUCHI voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ibe1562e46d704a0371a9ef982c0cdd9e5509740b
        Gerrit-Change-Number: 7885043
        Gerrit-PatchSet: 9
        Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
        Gerrit-Reviewer: Victor Vianna <victor...@google.com>
        Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: Di Wu <di...@google.com>
        Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
        Gerrit-CC: Peter Beverloo <pe...@chromium.org>
        Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
        Gerrit-CC: Simon Hangl <sim...@google.com>
        Gerrit-Comment-Date: Tue, 16 Jun 2026 15:41:21 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jun 16, 2026, 12:57:50 PM (11 days ago) Jun 16
        to Yoshiki IGUCHI, SLSA Policy Verification Service, Victor Vianna, Code Review Nudger, Di Wu, chromium...@chromium.org, Permissions Reviews, Akihiro Ota, Peter Beverloo, (Julie)Jeongeun Kim, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, dmurph+wat...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, msrame...@chromium.org, yuzo+...@chromium.org, andysjl...@chromium.org, zackha...@chromium.org, abigailbk...@google.com, jeffreycohen+watc...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, zelin+watch-we...@chromium.org, dewitt...@chromium.org, xinghui...@chromium.org, chfreme...@chromium.org, dtraino...@chromium.org, kuragin+web-ap...@chromium.org, mattreyno...@chromium.org, yhanada+...@chromium.org, josiah...@chromium.org, francisjp...@google.com, browser-comp...@chromium.org, arc-review...@google.com, mfoltz+wa...@chromium.org, nwoked...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, vasilii+watchlis...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jdeblas...@chromium.org, gcasto+w...@chromium.org, aashna...@google.com, odejesu...@chromium.org, yigu+...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, chrome-intell...@chromium.org, dmurph+watc...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, hidehik...@chromium.org, oshima...@chromium.org, mgiuca...@chromium.org, chromium-a...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, knollr+wat...@chromium.org, chrome-intelligence-te...@google.com, dullweb...@chromium.org

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        8 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        Clean up 100 includes and dependencies in C/B

        This CL removes:
        - 87 unnecessary includes from 83 .cc files
        - 23 unnecessary deps from 20 BUILD.gn files
        - 1 unnecessary deps from 1 DEPS files

        The following directories are processed separately:
        - chrome/browser/ash/: crrev.com/c/7877944
        - chrome/browser/ui/ash: crrev.com/c/7882518
        - chrome/browser/ui/views: crrev.com/c/7882777
        - chrome/browser/webui/ash: crrev.com/c/7881202
        Bug: None
        Test: Ran `autoninja -C out/Release chrome views_unittests`
        Test: CQ passed
        Change-Id: Ibe1562e46d704a0371a9ef982c0cdd9e5509740b
        SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>
        Reviewed-by: Victor Vianna <victor...@google.com>
        Commit-Queue: Yoshiki IGUCHI <yos...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1647666}
        Files:
        • M chrome/browser/actor/ui/handoff_button_controller_interactive_uitest.cc
        • M chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_controller.cc
        • M chrome/browser/android/BUILD.gn
        • M chrome/browser/android/browsing_data/browsing_data_bridge.cc
        • M chrome/browser/android/quick_delete/quick_delete_bridge.cc
        • M chrome/browser/android/send_tab_to_self/BUILD.gn
        • M chrome/browser/apps/app_service/publishers/BUILD.gn
        • M chrome/browser/apps/app_service/publishers/publisher_unittest.cc
        • M chrome/browser/autofill/BUILD.gn
        • M chrome/browser/background/glic/glic_status_icon_win.cc
        • M chrome/browser/background/glic/os_icon_provider_mac.mm
        • M chrome/browser/browser_switcher/BUILD.gn
        • M chrome/browser/browser_switcher/alternative_browser_driver_posix.cc
        • M chrome/browser/browser_switcher/alternative_browser_driver_unittest.cc
        • M chrome/browser/browser_switcher/alternative_browser_driver_win.cc
        • M chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc
        • M chrome/browser/chooser_controller/BUILD.gn
        • M chrome/browser/chooser_controller/title_util_unittest.cc
        • M chrome/browser/chrome_browser_main.cc
        • M chrome/browser/chrome_browser_main_linux.cc
        • M chrome/browser/chromeos/arc/start_smart_selection_action_menu.cc
        • M chrome/browser/contextual_cueing/contextual_cueing_menu_model.cc
        • M chrome/browser/contextual_tasks/contextual_tasks_page_handler.cc
        • M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc
        • M chrome/browser/device_notifications/BUILD.gn
        • M chrome/browser/device_notifications/device_status_icon_renderer.cc
        • M chrome/browser/device_notifications/device_system_tray_icon_unittest.cc
        • M chrome/browser/download/android/dangerous_download_dialog_bridge.cc
        • M chrome/browser/download/android/download_controller.cc
        • M chrome/browser/download/android/download_utils.cc
        • M chrome/browser/download/android/duplicate_download_dialog_bridge.cc
        • M chrome/browser/download/android/duplicate_download_dialog_bridge_delegate.cc
        • M chrome/browser/download/android/insecure_download_dialog_bridge.cc
        • M chrome/browser/download/android/open_download_dialog_bridge.cc
        • M chrome/browser/download/android/open_download_dialog_bridge_delegate.cc
        • M chrome/browser/download/android/policy_warning_download_dialog_bridge.cc
        • M chrome/browser/download/download_browsertest.cc
        • M chrome/browser/download/download_item_model.cc
        • M chrome/browser/download/download_permission_request.cc
        • M chrome/browser/enterprise/connectors/analysis/content_analysis_dialog_controller.cc
        • M chrome/browser/enterprise/data_controls/BUILD.gn
        • M chrome/browser/enterprise/data_controls/android_data_controls_dialog.cc
        • M chrome/browser/enterprise/data_controls/desktop_data_controls_dialog.cc
        • M chrome/browser/enterprise/reporting/extension_request/extension_request_notification_browsertest.cc
        • M chrome/browser/extensions/api/autofill_private/autofill_util.cc
        • M chrome/browser/extensions/api/developer_private/extension_info_generator.cc
        • M chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
        • M chrome/browser/extensions/api/webstore_private/extension_install_status_unittest.cc
        • M chrome/browser/extensions/extension_uninstall_dialog.cc
        • M chrome/browser/extensions/external_install_error_browsertest.cc
        • M chrome/browser/glic/fre/BUILD.gn
        • M chrome/browser/glic/selection/selection_overlay_untrusted_ui.cc
        • M chrome/browser/history/top_sites_factory.cc
        • M chrome/browser/image_decoder/BUILD.gn
        • M chrome/browser/image_decoder/DEPS
        • M chrome/browser/image_decoder/image_decoder_browsertest.cc
        • M chrome/browser/infobars/BUILD.gn
        • M chrome/browser/keyboard_accessory/android/address_accessory_controller_impl_unittest.cc
        • M chrome/browser/lookalikes/BUILD.gn
        • M chrome/browser/lookalikes/safety_tip_message_delegate_android.cc
        • M chrome/browser/lookalikes/safety_tip_message_delegate_android_unittest.cc
        • M chrome/browser/media/webrtc/desktop_media_picker_controller.cc
        • M chrome/browser/memory_details_linux.cc
        • M chrome/browser/memory_details_mac.cc
        • M chrome/browser/memory_details_win.cc
        • M chrome/browser/new_tab_page/chrome_colors/BUILD.gn
        • M chrome/browser/new_tab_page/modules/v2/most_relevant_tab_resumption/most_relevant_tab_resumption_page_handler.cc
        • M chrome/browser/new_tab_page/new_tab_page_util_browsertest.cc
        • M chrome/browser/new_tab_page/ntp_promo/ntp_promo_interactive_uitest.cc
        • M chrome/browser/new_tab_page/promos/promo_service.cc
        • M chrome/browser/new_tab_page/promos/promo_service_unittest.cc
        • M chrome/browser/notifications/win/notification_template_builder.cc
        • M chrome/browser/password_edit_dialog/android/BUILD.gn
        • M chrome/browser/password_manager/BUILD.gn
        • M chrome/browser/password_manager/android/auto_signin_prompt_controller.cc
        • M chrome/browser/password_manager/password_change_browsertest.cc
        • M chrome/browser/password_manager/password_manager_util_mac.mm
        • M chrome/browser/permissions/permission_blocked_dialog_controller_android.cc
        • M chrome/browser/prefs/chrome_pref_service_factory.cc
        • M chrome/browser/profiles/avatar_menu.cc
        • M chrome/browser/profiles/batch_upload/batch_upload_browsertest.cc
        • M chrome/browser/profiles/profile_impl.cc
        • M chrome/browser/profiles/profile_list_desktop_unittest.cc
        • M chrome/browser/push_messaging/push_messaging_service_impl.cc
        • M chrome/browser/renderer_context_menu/accessibility_labels_menu_observer.cc
        • M chrome/browser/renderer_host/javascript_optimizer_feature_browsertest.cc
        • M chrome/browser/resource_coordinator/BUILD.gn
        • M chrome/browser/safe_browsing/android/notification_content_detection_manager_android.cc
        • M chrome/browser/sharesheet/BUILD.gn
        • M chrome/browser/sharesheet/share_action/share_action_unittest.cc
        • M chrome/browser/sharesheet/sharesheet_service.cc
        • M chrome/browser/sharing/sms/BUILD.gn
        • M chrome/browser/sharing/sms/sms_remote_fetcher_ui_controller.cc
        • M chrome/browser/signin/signin_util.cc
        • M chrome/browser/ssl/known_interception_disclosure_message_delegate.cc
        • M chrome/browser/task_manager/providers/vm/vm_process_task.cc
        • M chrome/browser/task_manager/providers/web_contents/guest_task_mparch.cc
        • M chrome/browser/task_manager/task_manager_browsertest.cc
        • M chrome/browser/vr/BUILD.gn
        • M chrome/browser/web_applications/commands/web_install_from_url_command_browsertest.cc
        • M chrome/browser/web_applications/web_app_provider.cc
        • M chrome/browser/win/installer_downloader/BUILD.gn
        • M chrome/browser/win/installer_downloader/installer_downloader_infobar_delegate.cc
        Change size: M
        Delta: 103 files changed, 1 insertion(+), 113 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Victor Vianna
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ibe1562e46d704a0371a9ef982c0cdd9e5509740b
        Gerrit-Change-Number: 7885043
        Gerrit-PatchSet: 10
        Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
        Gerrit-Reviewer: Victor Vianna <victor...@google.com>
        Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages