Add metrics for MemoryDumpProviders [1/n] [chromium/src : main]

0 views
Skip to first unread message

Joe Mason (Gerrit)

unread,
Dec 3, 2025, 11:42:00 AMDec 3
to Etienne Pierre-Doray, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, Chromium LUCI CQ, chrome-gr...@chromium.org, agriev...@chromium.org, asvitkine...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, drott+bl...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, vaapi-...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Etienne Pierre-Doray

Joe Mason added 3 comments

Patchset-level comments
File-level comment, Patchset 4:
Joe Mason . resolved

Review note: the only significant changes are in

base/
media/base/
tools/metrics/
services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
third_party/blink/renderer/platform/media/web_media_player_impl.cc

The others are all just changing strings to fit the histogram format.

etiennep, can you review the above files? I'll send the rest of the changes to individual OWNER's to make sure the specific new names for MemoryDumpProviders don't have side effects (eg. if there are analysis scripts that use the old names).

File base/trace_event/memory_dump_manager_unittest.cc
Line 69, Patchset 4:constexpr char kAllowlistedMDPName[] = "TestDumpProvider.Allowlisted";
Joe Mason . resolved

Review note: changed this to `TestDumpProvider.*` so that all the Test strings sort together in the variants list.

File content/browser/tracing/memory_tracing_browsertest.cc
Line 111, Patchset 4: mock_dump_provider_.get(), "TestDumpProvider", nullptr);
Joe Mason . resolved

Review note: renamed this to `TestDumpProvider` which is also used in memory_dump_manager_unittest.cc to minimize the number of test-only variants.

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id39c782f1730939bd333f3421168d5d093309a80
Gerrit-Change-Number: 7217451
Gerrit-PatchSet: 9
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Dec 2025 16:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages