[bedrock] Use GetWindow()->Close()/Hide() in chrome/ [chromium/src : main]

0 views
Skip to first unread message

Neil Bao (Gerrit)

unread,
Jun 8, 2026, 8:48:17 PMJun 8
to Thomas Lukaszewicz, Qikai Zhong, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, SLSA Policy Verification Service, aixba+wat...@chromium.org, armalhotra+a...@google.com, ashleydp+fe...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, csharrison+...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xiangdongkong+...@google.com, ydago...@chromium.org, yigu+...@chromium.org, yyhyyh+fee...@google.com, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong and Thomas Lukaszewicz

Neil Bao voted and added 1 comment

Votes added by Neil Bao

Auto-Submit+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Neil Bao . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7349f3e17400f91d79d35637fc16b3b4352b1e14
Gerrit-Change-Number: 7902143
Gerrit-PatchSet: 2
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 00:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
Jun 8, 2026, 9:22:31 PMJun 8
to Neil Bao, Qikai Zhong, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, SLSA Policy Verification Service, aixba+wat...@chromium.org, armalhotra+a...@google.com, ashleydp+fe...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, csharrison+...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xiangdongkong+...@google.com, ydago...@chromium.org, yigu+...@chromium.org, yyhyyh+fee...@google.com, zelin+watch-we...@chromium.org
Attention needed from Neil Bao and Qikai Zhong

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
Thomas Lukaszewicz . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
  • Qikai Zhong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7349f3e17400f91d79d35637fc16b3b4352b1e14
Gerrit-Change-Number: 7902143
Gerrit-PatchSet: 2
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Neil Bao <nei...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 01:21:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Qikai Zhong (Gerrit)

unread,
Jun 8, 2026, 9:40:57 PMJun 8
to Neil Bao, Thomas Lukaszewicz, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, SLSA Policy Verification Service, aixba+wat...@chromium.org, armalhotra+a...@google.com, ashleydp+fe...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, csharrison+...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xiangdongkong+...@google.com, ydago...@chromium.org, yigu+...@chromium.org, yyhyyh+fee...@google.com, zelin+watch-we...@chromium.org
Attention needed from Neil Bao

Qikai Zhong voted and added 1 comment

Votes added by Qikai Zhong

Code-Review+1

1 comment

Patchset-level comments
Qikai Zhong . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7349f3e17400f91d79d35637fc16b3b4352b1e14
    Gerrit-Change-Number: 7902143
    Gerrit-PatchSet: 2
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Neil Bao <nei...@microsoft.com>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 01:40:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 8, 2026, 10:55:45 PMJun 8
    to Neil Bao, Qikai Zhong, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, SLSA Policy Verification Service, aixba+wat...@chromium.org, armalhotra+a...@google.com, ashleydp+fe...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, csharrison+...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xiangdongkong+...@google.com, ydago...@chromium.org, yigu+...@chromium.org, yyhyyh+fee...@google.com, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bedrock] Use GetWindow()->Close()/Hide() in chrome/

    Phase 1 (cont.): replace browser->window()->Close() and
    browser->window()->Hide() with browser->GetWindow()->Close() / Hide()
    across chrome/.

    Step toward eliminating Browser::window(). GetWindow() returns
    ui::BaseWindow*, which is sufficient for Close()/Hide() callers. No
    behavior change.
    Bug: 496674143
    Change-Id: I7349f3e17400f91d79d35637fc16b3b4352b1e14
    SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Auto-Submit: Neil Bao <nei...@microsoft.com>
    Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
    Commit-Queue: Neil Bao <nei...@microsoft.com>
    Reviewed-by: Qikai Zhong <qikai...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1643638}
    Files:
    • M chrome/browser/actor/actor_keyed_service_browsertest.cc
    • M chrome/browser/ash/app_mode/test/kiosk_browsertest.cc
    • M chrome/browser/ash/boca/on_task/on_task_locked_session_window_tracker_browsertest.cc
    • M chrome/browser/ash/boca/on_task/on_task_system_web_app_manager_impl.cc
    • M chrome/browser/ash/browser_delegate/browser_delegate_impl.cc
    • M chrome/browser/ash/integration_tests/screenshot_integration_test.cc
    • M chrome/browser/ash/integration_tests/web_handwriting_integration_test.cc
    • M chrome/browser/ash/os_feedback/chrome_os_feedback_delegate_browsertest.cc
    • M chrome/browser/ash/policy/dlp/dlp_content_manager_ash_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/boca_app_integration_browsertest.cc
    • M chrome/browser/chrome_navigation_browsertest.cc
    • M chrome/browser/chromeos/app_mode/kiosk_browser_window_handler.cc
    • M chrome/browser/chromeos/tablet_mode/tablet_mode_page_behavior_browsertest.cc
    • M chrome/browser/extensions/api/messaging/native_messaging_apitest.cc
    • M chrome/browser/extensions/api/web_request/web_request_apitest.cc
    • M chrome/browser/extensions/extension_install_prompt_browsertest.cc
    • M chrome/browser/extensions/extension_service_browsertest.cc
    • M chrome/browser/lifetime/browser_close_manager_browsertest.cc
    • M chrome/browser/sessions/session_restore_browsertest.cc
    • M chrome/browser/ui/ash/shelf/app_service/web_app_shelf_browsertest.cc
    • M chrome/browser/ui/ash/shell_delegate/tab_scrubber_browsertest.cc
    • M chrome/browser/ui/autofill/payments/desktop_bnpl_ui_delegate_browsertest.cc
    • M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
    • M chrome/browser/ui/browser_browsertest.cc
    • M chrome/browser/ui/browser_tab_strip_model_delegate.cc
    • M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
    • M chrome/browser/ui/extensions/extension_uninstall_dialog_impl_browsertest.cc
    • M chrome/browser/ui/native_window_tracker_browsertest.cc
    • M chrome/browser/ui/startup/startup_browser_creator_impl.cc
    • M chrome/browser/ui/tabs/pinned_tab_service_browsertest.cc
    • M chrome/browser/ui/user_education/show_promo_in_page_interactive_uitest.cc
    • M chrome/browser/ui/views/autofill/payments/autofill_error_dialog_view_native_views_browsertest.cc
    • M chrome/browser/ui/views/autofill/payments/autofill_progress_dialog_views_browsertest.cc
    • M chrome/browser/ui/views/autofill/payments/card_unmask_authentication_selection_dialog_browsertest.cc
    • M chrome/browser/ui/views/autofill/payments/card_unmask_otp_input_dialog_browsertest.cc
    • M chrome/browser/ui/views/autofill/payments/payments_window_user_consent_dialog_browsertest.cc
    • M chrome/browser/ui/views/autofill/payments/webauthn_dialog_browsertest.cc
    • M chrome/browser/ui/views/data_sharing/collaboration_controller_delegate_desktop_interactive_uitest.cc
    • M chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_frame_view_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_widget_browsertest.cc
    • M chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
    • M chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
    • M chrome/browser/ui/views/occlusion_visibility_interactive_uitest.cc
    • M chrome/browser/ui/views/passwords/password_bubble_interactive_uitest.cc
    • M chrome/browser/ui/views/profiles/dice_web_signin_interception_bubble_view_browsertest.cc
    • M chrome/browser/ui/views/toolbar/webui_toolbar_web_view_browsertest.cc
    • M chrome/browser/ui/views/user_education/custom_webui_help_bubble_interactive_uitest.cc
    • M chrome/browser/ui/views/user_education/impl/browser_feature_promo_controller_interactive_uitest.cc
    • M chrome/browser/ui/views/web_apps/frame_toolbar/web_app_frame_toolbar_browsertest.cc
    • M chrome/browser/ui/views/web_apps/web_app_integration_test_driver.cc
    • M chrome/browser/ui/views/web_apps/web_app_uninstall_dialog_browsertest.cc
    • M chrome/browser/ui/views/web_dialog_view_interactive_uitest.cc
    • M chrome/browser/ui/views/webid/fedcm_account_selection_view_desktop_browsertest.cc
    • M chrome/browser/ui/web_applications/test/system_web_app_interactive_uitest.cc
    • M chrome/browser/ui/web_applications/web_app_uninstall_browsertest.cc
    • M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog_browsertest.cc
    • M chrome/browser/web_applications/isolated_web_apps/update/isolated_web_app_update_manager_browsertest.cc
    • M chrome/browser/web_applications/sub_apps/sub_app_update_browsertest.cc
    Change size: M
    Delta: 59 files changed, 102 insertions(+), 102 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Qikai Zhong, +1 by Thomas Lukaszewicz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7349f3e17400f91d79d35637fc16b3b4352b1e14
    Gerrit-Change-Number: 7902143
    Gerrit-PatchSet: 3
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages