[resource coordinator] Remove DiscardTabImpl unused argument [chromium/src : main]

0 views
Skip to first unread message

Vovo Yang (Gerrit)

unread,
Nov 6, 2025, 4:46:18 AMNov 6
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Francois Pierre Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98dec0faa447701b040aa652597f4a3483a7611e
Gerrit-Change-Number: 7126702
Gerrit-PatchSet: 1
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Nov 2025 09:45:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Mason (Gerrit)

unread,
Nov 6, 2025, 10:22:47 AMNov 6
to Vovo Yang, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Vovo Yang

Joe Mason voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vovo Yang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98dec0faa447701b040aa652597f4a3483a7611e
Gerrit-Change-Number: 7126702
Gerrit-PatchSet: 1
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Vovo Yang <vo...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Nov 2025 15:22:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Vovo Yang (Gerrit)

unread,
Nov 6, 2025, 4:18:10 PMNov 6
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Vovo Yang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98dec0faa447701b040aa652597f4a3483a7611e
Gerrit-Change-Number: 7126702
Gerrit-PatchSet: 1
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Nov 2025 21:17:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 6, 2025, 4:21:50 PMNov 6
to Vovo Yang, chromium...@chromium.org, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[resource coordinator] Remove DiscardTabImpl unused argument
Bug: 394889323
Change-Id: I98dec0faa447701b040aa652597f4a3483a7611e
Commit-Queue: Vovo Yang <vo...@chromium.org>
Reviewed-by: Joe Mason <joenot...@google.com>
Cr-Commit-Position: refs/heads/main@{#1541411}
Files:
  • M chrome/browser/resource_coordinator/tab_manager.cc
  • M chrome/browser/resource_coordinator/tab_manager.h
  • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
Change size: S
Delta: 3 files changed, 2 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joe Mason
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98dec0faa447701b040aa652597f4a3483a7611e
Gerrit-Change-Number: 7126702
Gerrit-PatchSet: 2
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages