[bedrock] Migrate tab_lifecycle_unit_source.cc away from BrowserListObserver. [chromium/src : main]
0 views
Skip to first unread message
Glenn Hartmann (Gerrit)
Dec 12, 2025, 4:07:44 PMDec 12
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, stluon...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Attention needed from Francois Pierre Doray
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Dec 15, 2025, 9:39:13 AM (13 days ago) Dec 15
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, stluon...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Attention needed from Francois Pierre Doray
Glenn Hartmann added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 17 (Latest):
Glenn Hartmann . resolved
seems there are some new test failures. I'll look into these and add you back as a reviewer once they're fixed. Apologies for the noise
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Dec 15, 2025, 11:37:19 AM (13 days ago) Dec 15
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, stluon...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Attention needed from Francois Pierre Doray
Glenn Hartmann added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Glenn Hartmann . resolved
seems there are some new test failures. I'll look into these and add you back as a reviewer once they're fixed. Apologies for the noise
Glenn Hartmann
fixed, it was just a rebase error
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Dec 16, 2025, 11:50:36 AM (12 days ago) Dec 16
to Glenn Hartmann, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, stluon...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Attention needed from Glenn Hartmann
Francois Pierre Doray voted and added 2 comments![]( "Open in Gerrit")
Votes added by Francois Pierre Doray
| Code-Review | +1 |
2 comments
Patchset-level comments
File chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
Line 346, Patchset 19 (Latest):
// An active browser may be removed without OnBrowserDidBecomeActive() beingFrancois Pierre Doray . unresolved
not the right method name?
Related details
Attention is currently required from:
- Glenn Hartmann
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Dec 16, 2025, 12:35:41 PM (12 days ago) Dec 16
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, stluon...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Glenn Hartmann added 1 comment![]( "Open in Gerrit")
File chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
Line 346, Patchset 19:
// An active browser may be removed without OnBrowserDidBecomeActive() beingFrancois Pierre Doray . resolved
not the right method name?
Glenn Hartmann
yep good catch, thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Dec 16, 2025, 12:35:45 PM (12 days ago) Dec 16
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, stluon...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Glenn Hartmann voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 16, 2025, 1:43:45 PM (12 days ago) Dec 16
to Glenn Hartmann, Francois Pierre Doray, AyeAye, chromium...@chromium.org, stluon...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
19 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
Insertions: 1, Deletions: 1.
@@ -343,7 +343,7 @@
}
void TabLifecycleUnitSource::OnBrowserClosed(BrowserWindowInterface* browser) {
- // An active browser may be removed without OnBrowserDidBecomeActive() being
+ // An active browser may be removed without OnBrowserActivated() being
// invoked. crbug.com/1206458
UpdateFocusedTab();
}
```
Change information
Commit message:
[bedrock] Migrate tab_lifecycle_unit_source.cc away from BrowserListObserver.
This migration is part of project bedrock to reduce the dependencies on
Browser and BrowserList. See https://crbug.com/431671320 for more info.
Bug: 459777668
Change-Id: I1752bbdc10228ad785f69178e3024c086a6a6964
Commit-Queue: Glenn Hartmann <hart...@chromium.org>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559453}
Files:
- M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
- M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
Change size: S
Delta: 2 files changed, 24 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Francois Pierre Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages