Have TabLifeCycleUnit subscribe for audible state change [chromium/src : main]
0 views
Skip to first unread message
Joe Mason (Gerrit)
Jun 18, 2026, 4:35:08 PM (5 days ago) Jun 18
to Steven Luong, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Steven Luong
Joe Mason voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Steven Luong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Luong (Gerrit)
Jun 19, 2026, 1:13:55 AM (5 days ago) Jun 19
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Steven Luong voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 19, 2026, 1:55:50 AM (5 days ago) Jun 19
to Steven Luong, chromium...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Have TabLifeCycleUnit subscribe for audible state change
The TabLifecycleUnitSource was observing the TabStripModel and being
notified every time there was a data change for any tab and updating
it's corresponding tab's recently audible state. This CL makes it
so that the TabLifecycleUnit directly subscribe so it doesn't need
to make unnecessary updates.
Bug: 447214891
Change-Id: I2006646515ee1d1b39043efeae868e84a6243d5b
Reviewed-by: Joe Mason <joenot...@google.com>
Commit-Queue: Steven Luong <stl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1649499}
Files:
- M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
- M chrome/browser/resource_coordinator/tab_lifecycle_unit.h
- M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
- M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
Change size: S
Delta: 4 files changed, 23 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Mason
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages