[bedrock] Migrate network_profile_bubble.cc away from BrowserListObserver. [chromium/src : main]
0 views
Skip to first unread message
Glenn Hartmann (Gerrit)
Dec 19, 2025, 12:25:24 PM (9 days ago) Dec 19
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mgiuca...@chromium.org, rginda...@chromium.org, trewin...@google.com, webap...@microsoft.com
Attention needed from Tom Lukaszewicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Dec 21, 2025, 12:54:01 PM (7 days ago) Dec 21
to Glenn Hartmann, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mgiuca...@chromium.org, rginda...@chromium.org, trewin...@google.com, webap...@microsoft.com
Attention needed from Glenn Hartmann
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Glenn Hartmann
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 21, 2025, 1:24:51 PM (7 days ago) Dec 21
to Glenn Hartmann, Tom Lukaszewicz, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mgiuca...@chromium.org, rginda...@chromium.org, trewin...@google.com, webap...@microsoft.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[bedrock] Migrate network_profile_bubble.cc away from BrowserListObserver.
This migration is part of project bedrock to reduce the dependencies on
Browser and BrowserList. See https://crbug.com/431671320 for more info.
Bug: 459777668
Change-Id: I2a665f101847f8323a6ec731001d1ec26a6a6964
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561645}
Files:
- M chrome/browser/ui/network_profile_bubble.cc
- M chrome/browser/ui/network_profile_bubble.h
- M chrome/browser/ui/views/network_profile_bubble_view.cc
Change size: M
Delta: 3 files changed, 32 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages