Remove stale chrome/browser/ui/browser_list* dependencies [chromium/src : main]

0 views
Skip to first unread message

Georg Neis (Gerrit)

unread,
Apr 7, 2026, 4:24:59 AMApr 7
to Erik Chen, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Avi Drissman, Andrew Rayskiy, (Julie)Jeongeun Kim, Enterprise Policy Reviews, Rijubrata Bhaumik, Peter Beverloo, Simon Hangl, AyeAye, lwinston+watc...@google.com, zackha...@chromium.org, trewin...@google.com, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, jatapiaro+wat...@google.com, mickeybu...@chromium.org, jeffreycohen+watc...@chromium.org, tgupta...@chromium.org, mattreyno...@chromium.org, cros-setti...@google.com, odejesu...@chromium.org, chungshe...@google.com, nicolas...@chromium.org, asvitki...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, rginda...@chromium.org, zelin+watch-we...@chromium.org, feature-me...@chromium.org, abigailbk...@google.com, omnibox-...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, chlily...@chromium.org, creis...@chromium.org, bmcquad...@chromium.org, vasilii+watchlis...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, dibyapal+wa...@chromium.org, tburkar...@chromium.org, dmurph+wat...@chromium.org, yhanada+...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, csharris...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, extension...@chromium.org, arc-review...@google.com, loading...@chromium.org, loyso...@chromium.org, speed-metr...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, xinghui...@chromium.org, oshima...@chromium.org, dennyh...@google.com, speed-metrics...@chromium.org, dmurph+watc...@chromium.org, dewitt...@chromium.org, mac-r...@chromium.org, cwp-review...@google.com, rrsilva+wat...@google.com, gavin...@chromium.org, dtraino...@chromium.org, mek+w...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, siashah+au...@chromium.org, dtseng...@chromium.org, croissant-...@chromium.org, ajwong...@chromium.org, menghua...@google.com, webap...@microsoft.com, kuragin+web-ap...@chromium.org, dmurph+watchin...@chromium.org, weiluanw...@google.com, ydago...@chromium.org, mgiuca...@chromium.org, estali...@chromium.org, steimel+...@chromium.org, chromiumme...@microsoft.com, japhet+...@chromium.org, net-r...@chromium.org, loading-rev...@chromium.org, chfreme...@chromium.org, shgar+aut...@google.com, vinnypersky+...@google.com, aixba+wat...@chromium.org, yuzo+...@chromium.org, mfoltz+wa...@chromium.org, rmcelra...@chromium.org, print-revi...@chromium.org, mdjone...@chromium.org, chromeos-kio...@google.com, siyua+aut...@chromium.org, jdonnel...@chromium.org, yuezhang...@chromium.org, josiah...@chromium.org, performance-m...@chromium.org, dfried...@chromium.org, osaul+aut...@google.com, csharrison+...@chromium.org, grt+...@chromium.org
Attention needed from Erik Chen

Georg Neis voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ide74f5d18e8c4ea096e790d122727edf238ce64d
Gerrit-Change-Number: 7728863
Gerrit-PatchSet: 7
Gerrit-Owner: Georg Neis <ne...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Erik Chen <erik...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Apr 2026 08:24:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Chen (Gerrit)

unread,
Apr 7, 2026, 11:27:48 AMApr 7
to Georg Neis, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Avi Drissman, Andrew Rayskiy, (Julie)Jeongeun Kim, Enterprise Policy Reviews, Rijubrata Bhaumik, Peter Beverloo, Simon Hangl, AyeAye, lwinston+watc...@google.com, zackha...@chromium.org, trewin...@google.com, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, jatapiaro+wat...@google.com, mickeybu...@chromium.org, jeffreycohen+watc...@chromium.org, tgupta...@chromium.org, mattreyno...@chromium.org, cros-setti...@google.com, odejesu...@chromium.org, chungshe...@google.com, nicolas...@chromium.org, asvitki...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, rginda...@chromium.org, zelin+watch-we...@chromium.org, feature-me...@chromium.org, abigailbk...@google.com, omnibox-...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, chlily...@chromium.org, creis...@chromium.org, bmcquad...@chromium.org, vasilii+watchlis...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, dibyapal+wa...@chromium.org, tburkar...@chromium.org, dmurph+wat...@chromium.org, yhanada+...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, csharris...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, extension...@chromium.org, arc-review...@google.com, loading...@chromium.org, loyso...@chromium.org, speed-metr...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, xinghui...@chromium.org, oshima...@chromium.org, dennyh...@google.com, speed-metrics...@chromium.org, dmurph+watc...@chromium.org, dewitt...@chromium.org, mac-r...@chromium.org, cwp-review...@google.com, rrsilva+wat...@google.com, gavin...@chromium.org, dtraino...@chromium.org, mek+w...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, siashah+au...@chromium.org, dtseng...@chromium.org, croissant-...@chromium.org, ajwong...@chromium.org, menghua...@google.com, webap...@microsoft.com, kuragin+web-ap...@chromium.org, dmurph+watchin...@chromium.org, weiluanw...@google.com, ydago...@chromium.org, mgiuca...@chromium.org, estali...@chromium.org, steimel+...@chromium.org, chromiumme...@microsoft.com, japhet+...@chromium.org, net-r...@chromium.org, loading-rev...@chromium.org, chfreme...@chromium.org, shgar+aut...@google.com, vinnypersky+...@google.com, aixba+wat...@chromium.org, yuzo+...@chromium.org, mfoltz+wa...@chromium.org, rmcelra...@chromium.org, print-revi...@chromium.org, mdjone...@chromium.org, chromeos-kio...@google.com, siyua+aut...@chromium.org, jdonnel...@chromium.org, yuezhang...@chromium.org, josiah...@chromium.org, performance-m...@chromium.org, dfried...@chromium.org, osaul+aut...@google.com, csharrison+...@chromium.org, grt+...@chromium.org
Attention needed from Georg Neis

Erik Chen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Georg Neis
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ide74f5d18e8c4ea096e790d122727edf238ce64d
    Gerrit-Change-Number: 7728863
    Gerrit-PatchSet: 7
    Gerrit-Owner: Georg Neis <ne...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Georg Neis <ne...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Apr 2026 15:27:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Georg Neis (Gerrit)

    unread,
    Apr 7, 2026, 10:16:32 PMApr 7
    to Erik Chen, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Avi Drissman, Andrew Rayskiy, (Julie)Jeongeun Kim, Enterprise Policy Reviews, Rijubrata Bhaumik, Peter Beverloo, Simon Hangl, AyeAye, lwinston+watc...@google.com, zackha...@chromium.org, trewin...@google.com, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, jatapiaro+wat...@google.com, mickeybu...@chromium.org, jeffreycohen+watc...@chromium.org, tgupta...@chromium.org, mattreyno...@chromium.org, cros-setti...@google.com, odejesu...@chromium.org, chungshe...@google.com, nicolas...@chromium.org, asvitki...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, rginda...@chromium.org, zelin+watch-we...@chromium.org, feature-me...@chromium.org, abigailbk...@google.com, omnibox-...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, chlily...@chromium.org, creis...@chromium.org, bmcquad...@chromium.org, vasilii+watchlis...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, dibyapal+wa...@chromium.org, tburkar...@chromium.org, dmurph+wat...@chromium.org, yhanada+...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, csharris...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, extension...@chromium.org, arc-review...@google.com, loading...@chromium.org, loyso...@chromium.org, speed-metr...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, xinghui...@chromium.org, oshima...@chromium.org, dennyh...@google.com, speed-metrics...@chromium.org, dmurph+watc...@chromium.org, dewitt...@chromium.org, mac-r...@chromium.org, cwp-review...@google.com, rrsilva+wat...@google.com, gavin...@chromium.org, dtraino...@chromium.org, mek+w...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, siashah+au...@chromium.org, dtseng...@chromium.org, croissant-...@chromium.org, ajwong...@chromium.org, menghua...@google.com, webap...@microsoft.com, kuragin+web-ap...@chromium.org, dmurph+watchin...@chromium.org, weiluanw...@google.com, ydago...@chromium.org, mgiuca...@chromium.org, estali...@chromium.org, steimel+...@chromium.org, chromiumme...@microsoft.com, japhet+...@chromium.org, net-r...@chromium.org, loading-rev...@chromium.org, chfreme...@chromium.org, shgar+aut...@google.com, vinnypersky+...@google.com, aixba+wat...@chromium.org, yuzo+...@chromium.org, mfoltz+wa...@chromium.org, rmcelra...@chromium.org, print-revi...@chromium.org, mdjone...@chromium.org, chromeos-kio...@google.com, siyua+aut...@chromium.org, jdonnel...@chromium.org, yuezhang...@chromium.org, josiah...@chromium.org, performance-m...@chromium.org, dfried...@chromium.org, osaul+aut...@google.com, csharrison+...@chromium.org, grt+...@chromium.org

    Georg Neis voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Wed, 08 Apr 2026 02:15:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 7, 2026, 10:21:08 PMApr 7
    to Georg Neis, Erik Chen, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Akihiro Ota, Avi Drissman, Andrew Rayskiy, (Julie)Jeongeun Kim, Enterprise Policy Reviews, Rijubrata Bhaumik, Peter Beverloo, Simon Hangl, AyeAye, lwinston+watc...@google.com, zackha...@chromium.org, trewin...@google.com, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, jatapiaro+wat...@google.com, mickeybu...@chromium.org, jeffreycohen+watc...@chromium.org, tgupta...@chromium.org, mattreyno...@chromium.org, cros-setti...@google.com, odejesu...@chromium.org, chungshe...@google.com, nicolas...@chromium.org, asvitki...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, rginda...@chromium.org, zelin+watch-we...@chromium.org, feature-me...@chromium.org, abigailbk...@google.com, omnibox-...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, chlily...@chromium.org, creis...@chromium.org, bmcquad...@chromium.org, vasilii+watchlis...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, dibyapal+wa...@chromium.org, tburkar...@chromium.org, dmurph+wat...@chromium.org, yhanada+...@chromium.org, philli...@chromium.org, dullweb...@chromium.org, csharris...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, extension...@chromium.org, arc-review...@google.com, loading...@chromium.org, loyso...@chromium.org, speed-metr...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, xinghui...@chromium.org, oshima...@chromium.org, dennyh...@google.com, speed-metrics...@chromium.org, dmurph+watc...@chromium.org, dewitt...@chromium.org, mac-r...@chromium.org, cwp-review...@google.com, rrsilva+wat...@google.com, gavin...@chromium.org, dtraino...@chromium.org, mek+w...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, siashah+au...@chromium.org, dtseng...@chromium.org, croissant-...@chromium.org, ajwong...@chromium.org, menghua...@google.com, webap...@microsoft.com, kuragin+web-ap...@chromium.org, dmurph+watchin...@chromium.org, weiluanw...@google.com, ydago...@chromium.org, mgiuca...@chromium.org, estali...@chromium.org, steimel+...@chromium.org, chromiumme...@microsoft.com, japhet+...@chromium.org, net-r...@chromium.org, loading-rev...@chromium.org, chfreme...@chromium.org, shgar+aut...@google.com, vinnypersky+...@google.com, aixba+wat...@chromium.org, yuzo+...@chromium.org, mfoltz+wa...@chromium.org, rmcelra...@chromium.org, print-revi...@chromium.org, mdjone...@chromium.org, chromeos-kio...@google.com, siyua+aut...@chromium.org, jdonnel...@chromium.org, yuezhang...@chromium.org, josiah...@chromium.org, performance-m...@chromium.org, dfried...@chromium.org, osaul+aut...@google.com, csharrison+...@chromium.org, grt+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove stale chrome/browser/ui/browser_list* dependencies

    Remove includes of browser_list.h and browser_list_observer.h where they
    are not used. Similarly remove obsolete DEPS and BUILD.gn entries.
    AX-Relnotes: n/a.
    Change-Id: Ide74f5d18e8c4ea096e790d122727edf238ce64d
    Reviewed-by: Erik Chen <erik...@chromium.org>
    Commit-Queue: Georg Neis <ne...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1611147}
    Files:
    • M chrome/browser/actor/BUILD.gn
    • M chrome/browser/apps/app_shim/BUILD.gn
    • M chrome/browser/apps/app_shim/app_shim_manager_mac.cc
    • M chrome/browser/apps/platform_apps/BUILD.gn
    • M chrome/browser/apps/platform_apps/app_window_interactive_uitest.cc
    • M chrome/browser/background/glic/BUILD.gn
    • M chrome/browser/browser_process_platform_part_ash.cc
    • M chrome/browser/browser_process_platform_part_ash_browsertest.cc
    • M chrome/browser/browsing_data/chrome_browsing_data_lifetime_manager_browsertest.cc
    • M chrome/browser/browsing_data/navigation_entry_remover_browsertest.cc
    • M chrome/browser/captive_portal/BUILD.gn
    • M chrome/browser/chrome_content_browser_client.cc
    • M chrome/browser/chrome_content_browser_client_unittest.cc
    • M chrome/browser/chromeos/app_mode/BUILD.gn
    • M chrome/browser/chromeos/app_mode/DEPS
    • M chrome/browser/chromeos/app_mode/kiosk_browser_session_unittest.cc
    • M chrome/browser/chromeos/cros_apps/api/DEPS
    • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_access_control_browsertest.cc
    • M chrome/browser/chromeos/extensions/odfs_config_private/DEPS
    • M chrome/browser/chromeos/extensions/odfs_config_private/odfs_config_private_api_browsertest.cc
    • M chrome/browser/chromeos/extensions/telemetry/api/common/DEPS
    • M chrome/browser/chromeos/extensions/telemetry/api/events/DEPS
    • M chrome/browser/chromeos/extensions/telemetry/api/events/event_manager_unittest.cc
    • M chrome/browser/chromeos/extensions/telemetry/api/events/events_api_browsertest.cc
    • M chrome/browser/device_notifications/device_connection_tracker_unittest.cc
    • M chrome/browser/devtools/BUILD.gn
    • M chrome/browser/devtools/protocol/browser_handler.cc
    • M chrome/browser/devtools/protocol/target_handler.cc
    • M chrome/browser/devtools/protocol/target_handler.h
    • M chrome/browser/devtools/remote_debugging_server.cc
    • M chrome/browser/download/download_browsertest.cc
    • M chrome/browser/download/download_status_updater_win.cc
    • M chrome/browser/download/download_ui_controller.cc
    • M chrome/browser/enterprise/idle/idle_service.cc
    • M chrome/browser/enterprise/signin/enterprise_signin_service_browsertest.cc
    • M chrome/browser/extensions/BUILD.gn
    • M chrome/browser/extensions/api/management/management_apitest.cc
    • M chrome/browser/extensions/api/messaging/native_messaging_apitest.cc
    • M chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
    • M chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
    • M chrome/browser/extensions/api/web_navigation/BUILD.gn
    • M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
    • M chrome/browser/extensions/extension_tab_util_browsertest.cc
    • M chrome/browser/extensions/window_open_apitest.cc
    • M chrome/browser/glic/glic_profile_manager_browsertest.cc
    • M chrome/browser/glic/host/context/glic_focused_tab_manager.cc
    • M chrome/browser/glic/host/context/glic_focused_tab_manager.h
    • M chrome/browser/glic/host/glic_actor_window_management_tool_interactive_uitest.cc
    • M chrome/browser/glic/host/glic_page_handler.cc
    • M chrome/browser/glic/service/glic_instance_impl.cc
    • M chrome/browser/glic/test_support/interactive_glic_test.h
    • M chrome/browser/glic/widget/glic_instance_coordinator_interactive_uitest.cc
    • M chrome/browser/glic/widget/glic_view.cc
    • M chrome/browser/lifetime/browser_close_manager.cc
    • M chrome/browser/loader/keep_alive_category_request_browsertest.cc
    • M chrome/browser/media/media_engagement_contents_observer.cc
    • M chrome/browser/media/webrtc/BUILD.gn
    • M chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
    • M chrome/browser/metrics/desktop_platform_features_metrics_provider.cc
    • M chrome/browser/metrics/desktop_session_duration/BUILD.gn
    • M chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
    • M chrome/browser/metrics/perf/perf_events_collector.cc
    • M chrome/browser/metrics/usage_scenario/tab_usage_scenario_tracker_browsertest.cc
    • M chrome/browser/net/profile_network_context_service_test_utils.cc
    • M chrome/browser/notifications/platform_notification_service_impl.cc
    • M chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.cc
    • M chrome/browser/page_load_metrics/observers/tab_strip_page_load_metrics_observer.cc
    • M chrome/browser/performance_manager/background_tab_loading_policy_browsertest.cc
    • M chrome/browser/policy/profile_policy_connector.cc
    • M chrome/browser/policy/profile_policy_connector.h
    • M chrome/browser/preloading/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc
    • M chrome/browser/profile_resetter/profile_resetter.cc
    • M chrome/browser/profiles/BUILD.gn
    • M chrome/browser/profiles/profile_activity_metrics_recorder_unittest.cc
    • M chrome/browser/profiles/profile_window_browsertest.cc
    • M chrome/browser/push_messaging/push_messaging_notification_manager.cc
    • M chrome/browser/renderer_context_menu/render_view_context_menu.cc
    • M chrome/browser/resource_coordinator/tab_manager.cc
    • M chrome/browser/safe_browsing/BUILD.gn
    • M chrome/browser/segmentation_platform/client_util/local_tab_handler.cc
    • M chrome/browser/segmentation_platform/client_util/local_tab_handler_unittest.cc
    • M chrome/browser/sessions/app_session_service.cc
    • M chrome/browser/sessions/better_session_restore_browsertest.cc
    • M chrome/browser/sessions/exit_type_service_browsertest.cc
    • M chrome/browser/sessions/session_restore_browsertest.cc
    • M chrome/browser/sessions/session_restore_interactive_uitest.cc
    • M chrome/browser/sessions/session_service.cc
    • M chrome/browser/sessions/session_service_log_browsertest.cc
    • M chrome/browser/signin/BUILD.gn
    • M chrome/browser/signin/chrome_signin_and_sync_status_metrics_provider.cc
    • M chrome/browser/signin/dice_web_signin_interceptor.cc
    • M chrome/browser/signin/dice_web_signin_interceptor_browsertest.cc
    • M chrome/browser/signin/force_signin_verifier.cc
    • M chrome/browser/signin/signin_util_win.cc
    • M chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • M chrome/browser/sync/BUILD.gn
    • M chrome/browser/sync/sessions/browser_list_router_helper_unittest.cc
    • M chrome/browser/task_manager/providers/worker_task_provider_browsertest.cc
    • M chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc
    • M chrome/browser/ui/ash/arc/DEPS
    • M chrome/browser/ui/ash/arc/arc_open_url_delegate_impl_browsertest.cc
    • M chrome/browser/ui/ash/assistant/DEPS
    • M chrome/browser/ui/ash/birch/DEPS
    • M chrome/browser/ui/ash/birch/birch_coral_provider_browsertest.cc
    • M chrome/browser/ui/ash/boca/DEPS
    • M chrome/browser/ui/ash/boca/chrome_tab_strip_delegate_browsertest.cc
    • M chrome/browser/ui/ash/boca/chrome_tab_strip_delegate_unittest.cc
    • M chrome/browser/ui/ash/desks/BUILD.gn
    • M chrome/browser/ui/ash/multi_user/DEPS
    • M chrome/browser/ui/ash/multi_user/multi_user_window_manager_browser_adaptor_unittest.cc
    • M chrome/browser/ui/ash/new_window/DEPS
    • M chrome/browser/ui/ash/new_window/chrome_new_window_client_browsertest.cc
    • M chrome/browser/ui/ash/projector/DEPS
    • M chrome/browser/ui/ash/projector/projector_navigation_throttle_browsertest.cc
    • M chrome/browser/ui/ash/shelf/DEPS
    • M chrome/browser/ui/ash/shelf/app_service/BUILD.gn
    • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_browsertest.cc
    • M chrome/browser/ui/ash/shell_delegate/BUILD.gn
    • M chrome/browser/ui/ash/system_web_apps/BUILD.gn
    • M chrome/browser/ui/ash/test/DEPS
    • M chrome/browser/ui/ash/wm/BUILD.gn
    • M chrome/browser/ui/ash/wm/DEPS
    • M chrome/browser/ui/ash/wm/coral_browsertest.cc
    • M chrome/browser/ui/autofill/payments/virtual_card_enroll_bubble_controller_impl_unittest.cc
    • M chrome/browser/ui/blocked_content/BUILD.gn
    • M chrome/browser/ui/blocked_content/popunder_preventer.cc
    • M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
    • M chrome/browser/ui/bookmarks/BUILD.gn
    • M chrome/browser/ui/bookmarks/bookmark_browsertest.cc
    • M chrome/browser/ui/browser_command_controller_browsertest.cc
    • M chrome/browser/ui/browser_finder.cc
    • M chrome/browser/ui/browser_navigator_browsertest.cc
    • M chrome/browser/ui/browser_tab_menu_model_delegate.cc
    • M chrome/browser/ui/browser_tab_restorer.cc
    • M chrome/browser/ui/browser_tab_strip_model_delegate.cc
    • M chrome/browser/ui/browser_window/public/browser_window_interface_iterator_browsertest.cc
    • M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm
    • M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm
    • M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
    • M chrome/browser/ui/cocoa/share_menu_controller_browsertest.mm
    • M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
    • M chrome/browser/ui/extensions/BUILD.gn
    • M chrome/browser/ui/extensions/application_launch.cc
    • M chrome/browser/ui/fullscreen_keyboard_browsertest_base.cc
    • M chrome/browser/ui/global_media_controls/BUILD.gn
    • M chrome/browser/ui/global_media_controls/media_notification_service.cc
    • M chrome/browser/ui/javascript_dialogs/BUILD.gn
    • M chrome/browser/ui/network_profile_bubble.cc
    • M chrome/browser/ui/omnibox/BUILD.gn
    • M chrome/browser/ui/omnibox/chrome_omnibox_client.cc
    • M chrome/browser/ui/read_anything/BUILD.gn
    • M chrome/browser/ui/sad_tab.cc
    • M chrome/browser/ui/send_tab_to_self/BUILD.gn
    • M chrome/browser/ui/settings_window_manager_browsertest_chromeos.cc
    • M chrome/browser/ui/signin/promos/bubble_sign_in_promo_delegate_browsertest.cc
    • M chrome/browser/ui/singleton_tabs.cc
    • M chrome/browser/ui/startup/default_browser_prompt/BUILD.gn
    • M chrome/browser/ui/startup/default_browser_prompt/default_browser_prompt_manager_unittest.cc
    • M chrome/browser/ui/startup/focus/BUILD.gn
    • M chrome/browser/ui/startup/focus/focus_handler_browsertest.cc
    • M chrome/browser/ui/startup/profile_launch_observer.cc
    • M chrome/browser/ui/startup/startup_browser_creator.cc
    • M chrome/browser/ui/startup/startup_browser_creator_impl.cc
    • M chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc
    • M chrome/browser/ui/startup/startup_launch_infobar_delegate.cc
    • M chrome/browser/ui/startup/web_app_info_recorder_utils.cc
    • M chrome/browser/ui/tab_contents/BUILD.gn
    • M chrome/browser/ui/tab_contents/chrome_web_contents_menu_helper_browsertest.cc
    • M chrome/browser/ui/tab_contents/core_tab_helper.cc
    • M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
    • M chrome/browser/ui/tabs/BUILD.gn
    • M chrome/browser/ui/tabs/existing_tab_group_sub_menu_model_browsertest.cc
    • M chrome/browser/ui/tabs/existing_window_sub_menu_model_browsertest.cc
    • M chrome/browser/ui/tabs/pinned_tab_codec.cc
    • M chrome/browser/ui/tabs/pinned_tab_service_browsertest.cc
    • M chrome/browser/ui/tabs/saved_tab_groups/BUILD.gn
    • M chrome/browser/ui/tabs/saved_tab_groups/saved_tab_group_utils.cc
    • M chrome/browser/ui/tabs/saved_tab_groups/tab_group_sync_delegate_desktop.cc
    • M chrome/browser/ui/tabs/split_tab_menu_model.cc
    • M chrome/browser/ui/tabs/tab_list_bridge_browsertest.cc
    • M chrome/browser/ui/tabs/tab_strip_model_stats_recorder.cc
    • M chrome/browser/ui/tabs/tab_strip_model_unittest.cc
    • M chrome/browser/ui/thumbnails/BUILD.gn
    • M chrome/browser/ui/toolbar/BUILD.gn
    • M chrome/browser/ui/toolbar/app_menu_model.cc
    • M chrome/browser/ui/toolbar/app_menu_model_interactive_uitest.cc
    • M chrome/browser/ui/uma_browsing_activity_observer.cc
    • M chrome/browser/ui/user_education/BUILD.gn
    • M chrome/browser/ui/user_education/polling_idle_observer.cc
    • M chrome/browser/ui/views/accessibility/accessibility_util.cc
    • M chrome/browser/ui/views/bookmarks/bookmark_account_storage_move_dialog_interactive_uitest.cc
    • M chrome/browser/ui/views/bubble/BUILD.gn
    • M chrome/browser/ui/views/download/BUILD.gn
    • M chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller.cc
    • M chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_frame_view_chromeos_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_view_unittest.cc
    • M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
    • M chrome/browser/ui/views/frame/immersive_mode_controller_chromeos_browsertest.cc
    • M chrome/browser/ui/views/frame/multi_contents_view_tab_drag_interactive_uitest.cc
    • M chrome/browser/ui/views/frame/webui_tab_strip_container_view.cc
    • M chrome/browser/ui/views/frame/webui_tab_strip_container_view_browsertest.cc
    • M chrome/browser/ui/views/location_bar/intent_chip_button_browsertest.cc
    • M chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
    • M chrome/browser/ui/views/media_router/web_contents_display_observer_view.cc
    • M chrome/browser/ui/views/passwords/manage_passwords_view_unittest.cc
    • M chrome/browser/ui/views/profiles/avatar_toolbar_button_state_manager.cc
    • M chrome/browser/ui/views/profiles/profile_menu_view.cc
    • M chrome/browser/ui/views/profiles/profile_menu_view_browsertest.cc
    • M chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_unittest.cc
    • M chrome/browser/ui/views/save_to_drive/account_chooser_controller_interactive_uitest.cc
    • M chrome/browser/ui/views/session_restore_infobar/BUILD.gn
    • M chrome/browser/ui/views/side_panel/BUILD.gn
    • M chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc
    • M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc
    • M chrome/browser/ui/views/tab_sharing/tab_sharing_ui_views.cc
    • M chrome/browser/ui/views/tab_sharing/tab_sharing_ui_views_browsertest.cc
    • M chrome/browser/ui/views/tabs/dragging/tab_drag_controller.cc
    • M chrome/browser/ui/views/tabs/groups/tab_group_editor_bubble_view.cc
    • M chrome/browser/ui/views/tabs/groups/tab_group_editor_bubble_view_browsertest.cc
    • M chrome/browser/ui/views/web_apps/file_handler_launch_dialog_browsertest.cc
    • M chrome/browser/ui/views/web_apps/web_app_blocked_migration_infobar_delegate_browsertest.cc
    • M chrome/browser/ui/views/web_apps/web_app_integration_test_driver.cc
    • M chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
    • M chrome/browser/ui/web_applications/app_browser_controller.cc
    • M chrome/browser/ui/web_applications/app_browser_controller_browsertest_chromeos.cc
    • M chrome/browser/ui/web_applications/navigation_capturing_process.cc
    • M chrome/browser/ui/web_applications/test/system_web_app_interactive_uitest.cc
    • M chrome/browser/ui/web_applications/web_app_browsertest.cc
    • M chrome/browser/ui/web_applications/web_app_engagement_browsertest.cc
    • M chrome/browser/ui/web_applications/web_app_launch_handler_browsertest.cc
    • M chrome/browser/ui/web_applications/web_app_launch_utils.cc
    • M chrome/browser/ui/web_applications/web_app_navigate_browsertest.cc
    • M chrome/browser/ui/web_applications/web_app_protocol_handling_browsertest.cc
    • M chrome/browser/ui/web_applications/web_app_ui_manager_impl_browsertest.cc
    • M chrome/browser/ui/webui/accessibility/BUILD.gn
    • M chrome/browser/ui/webui/ash/kerberos/DEPS
    • M chrome/browser/ui/webui/ash/settings/integration_tests/device_page/DEPS
    • M chrome/browser/ui/webui/ash/settings/integration_tests/device_page/device_settings_interactive_uitest.cc
    • M chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate_browsertest.cc
    • M chrome/browser/ui/webui/new_tab_page/new_tab_page_ui.cc
    • M chrome/browser/ui/webui/print_preview/print_preview_chromeos_interactive_uitest.cc
    • M chrome/browser/ui/webui/settings/site_settings_handler.cc
    • M chrome/browser/ui/webui/side_panel/reading_list/reading_list_page_handler_unittest.cc
    • M chrome/browser/ui/webui/signin/BUILD.gn
    • M chrome/browser/ui/webui/tab_search/tab_search_page_handler_unittest.cc
    • M chrome/browser/ui/webui/tab_strip/tab_strip_page_handler.cc
    • M chrome/browser/ui/webui/tab_strip_internals/BUILD.gn
    • M chrome/browser/ui/webui/webui_util_desktop.cc
    • M chrome/browser/ui/webui/whats_new/BUILD.gn
    • M chrome/browser/ui/webui_browser/webui_browser_window.cc
    • M chrome/browser/ui/window_sizer/BUILD.gn
    • M chrome/browser/ui/window_sizer/window_sizer.cc
    • M chrome/browser/upgrade_detector/BUILD.gn
    • M chrome/browser/usb/BUILD.gn
    • M chrome/browser/usb/web_usb_detector_browsertest.cc
    • M chrome/browser/web_applications/commands/launch_web_app_command_browsertest.cc
    • M chrome/browser/web_applications/isolated_web_apps/isolated_web_app_link_capturing_browsertest.cc
    • M chrome/browser/web_applications/isolated_web_apps/window_management/isolated_web_apps_window_open_permission_service_browsertest.cc
    • M chrome/browser/web_applications/isolated_web_apps/window_management/isolated_web_apps_window_open_permission_service_delegate.cc
    • M chrome/browser/web_applications/isolated_web_apps/window_management/isolated_web_apps_window_open_permission_service_factory.cc
    • M chrome/browser/web_applications/web_app_navigation_capturing_browsertest_base.cc
    • M chrome/test/base/ash/interactive/DEPS
    • M chrome/test/base/ash/interactive/interactive_ash_test.cc
    • M chrome/test/base/dialog_test_browser_window.cc
    • M chrome/test/base/ui_test_utils.cc
    • M chrome/test/interaction/interactive_browser_test_internal.cc
    Change size: L
    Delta: 267 files changed, 6 insertions(+), 298 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Erik Chen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ide74f5d18e8c4ea096e790d122727edf238ce64d
    Gerrit-Change-Number: 7728863
    Gerrit-PatchSet: 8
    Gerrit-Owner: Georg Neis <ne...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Georg Neis <ne...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages