Remove superfluous mojom includes in //chrome headers [chromium/src : main]
0 views
Skip to first unread message
Avi Drissman (Gerrit)
Oct 6, 2025, 8:28:41 PM (5 days ago) Oct 6
to Lei Zhang, Avi Drissman, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Simon Hangl, aashna...@google.com, abigailbk...@google.com, arc-review...@google.com, boujan...@google.com, byronle...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chrstn...@google.com, chungshe...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, dennyh...@google.com, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jatapiaro+wat...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kenok...@google.com, khorimoto+w...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Oct 7, 2025, 1:23:31 PM (5 days ago) Oct 7
to Lei Zhang, Avi Drissman, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Simon Hangl, aashna...@google.com, abigailbk...@google.com, arc-review...@google.com, boujan...@google.com, byronle...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chrstn...@google.com, chungshe...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, dennyh...@google.com, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jatapiaro+wat...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kenok...@google.com, khorimoto+w...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Chromium LUCI CQ (Gerrit)
Oct 7, 2025, 2:03:53 PM (4 days ago) Oct 7
to Lei Zhang, Avi Drissman, AyeAye, Akihiro Ota, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Simon Hangl, aashna...@google.com, abigailbk...@google.com, arc-review...@google.com, boujan...@google.com, byronle...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chrstn...@google.com, chungshe...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, dennyh...@google.com, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jatapiaro+wat...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kenok...@google.com, khorimoto+w...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove superfluous mojom includes in //chrome headers
Since mojom code have "mojom::" in the their namespace, headers without
that string do not need to include mojom headers. Remove them and do
IWYU to fix the build.
Bug: 40318405
Change-Id: Id58d6e1cdfb340d2175548b5a0674e5cef4af870
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1526413}
Files:
- M chrome/browser/actor/tools/attempt_login_tool_request.h
- M chrome/browser/actor/tools/history_tool_request.h
- M chrome/browser/actor/tools/navigate_tool_request.h
- M chrome/browser/actor/tools/wait_tool_request.h
- M chrome/browser/actor/ui/actor_ui_tab_controller.h
- M chrome/browser/actor/ui/actor_ui_tab_controller_interface.h
- M chrome/browser/ai/ai_data_keyed_service.h
- M chrome/browser/ai/built_in_ai_logger.h
- M chrome/browser/apps/almanac_api_client/almanac_api_util.h
- M chrome/browser/apps/app_service/webapk/webapk_manager.h
- M chrome/browser/apps/app_service/webapk/webapk_metrics.h
- M chrome/browser/ash/arc/accessibility/arc_accessibility_util.h
- M chrome/browser/ash/arc/window_predictor/window_predictor_utils.h
- M chrome/browser/ash/chromebox_for_meetings/artemis/command_source.h
- M chrome/browser/ash/chromebox_for_meetings/artemis/log_source.h
- M chrome/browser/ash/extensions/file_manager/private_api_drive.h
- M chrome/browser/ash/file_manager/copy_or_move_encrypted_hook_delegate.h
- M chrome/browser/ash/input_method/native_input_method_engine.h
- M chrome/browser/ash/mahi/media_app/mahi_media_app_content_manager_impl.h
- M chrome/browser/ash/mahi/web_contents/mahi_web_contents_manager_impl.h
- M chrome/browser/ash/mahi/web_contents/test_support/fake_mahi_web_contents_manager.h
- M chrome/browser/ash/net/network_diagnostics/udp_prober.h
- M chrome/browser/ash/policy/reporting/metrics_reporting/fatal_crash/fatal_crash_events_observer_reported_local_id_manager.h
- M chrome/browser/ash/policy/scheduled_task_handler/device_scheduled_reboot_handler.h
- M chrome/browser/ash/policy/scheduled_task_handler/device_scheduled_update_checker.h
- M chrome/browser/ash/video_conference/video_conference_ash_feature_client.h
- M chrome/browser/browser_process_impl.h
- M chrome/browser/browsing_data/counters/site_data_counting_helper.h
- M chrome/browser/chromeos/extensions/telemetry/api/common/hardware_info_delegate.h
- M chrome/browser/content_extraction/inner_html.h
- M chrome/browser/devtools/device/tcp_device_provider.h
- M chrome/browser/digital_credentials/digital_identity_provider_android.h
- M chrome/browser/enterprise/connectors/analysis/content_analysis_dialog_controller.h
- M chrome/browser/enterprise/data_controls/desktop_data_controls_dialog.h
- M chrome/browser/media/router/test/provider_test_helpers.h
- M chrome/browser/media/webrtc/webrtc_event_log_uploader.h
- M chrome/browser/net/stub_resolver_config_reader.h
- M chrome/browser/new_tab_page/chrome_colors/chrome_colors_service.h
- M chrome/browser/notifications/mac/notification_dispatcher_mac.h
- M chrome/browser/on_device_translation/translation_manager_util.h
- M chrome/browser/password_manager/android/password_generation_controller.h
- M chrome/browser/performance_manager/mechanisms/working_set_trimmer_chromeos.h
- M chrome/browser/performance_manager/policies/page_discarding_helper.h
- M chrome/browser/printing/print_job_worker.h
- M chrome/browser/privacy_sandbox/incognito/privacy_sandbox_whats_new_survey_service.h
- M chrome/browser/profiling_host/profiling_process_host.h
- M chrome/browser/push_messaging/push_messaging_refresher.h
- M chrome/browser/resource_coordinator/tab_manager.h
- M chrome/browser/ui/exclusive_access/exclusive_access_permission_manager.h
- M chrome/browser/ui/lens/lens_session_metrics_logger.h
- M chrome/browser/ui/performance_controls/memory_saver_chip_tab_helper.h
- M chrome/browser/ui/tabs/tab_strip_api/adapters/tree_builder/walker_factory.h
- M chrome/browser/ui/tabs/tab_strip_api/event_broadcaster.h
- M chrome/browser/ui/views/new_tab_footer/footer_web_view.cc
- M chrome/browser/ui/views/new_tab_footer/footer_web_view.h
- M chrome/browser/ui/views/tabs/vertical/root_tab_collection_node.h
- M chrome/browser/ui/web_applications/web_app_launch_utils.h
- M chrome/browser/ui/webui/app_management/app_management_shelf_delegate_chromeos.h
- M chrome/browser/ui/webui/ash/floating_workspace/floating_workspace_dialog.h
- M chrome/browser/ui/webui/ash/settings/pages/multidevice/multidevice_handler.h
- M chrome/browser/ui/webui/certificate_manager/chrome_root_store_cert_source.h
- M chrome/browser/ui/webui/certificate_manager/enterprise_cert_sources.h
- M chrome/browser/vr/browser_renderer.h
- M chrome/browser/web_applications/commands/install_from_info_command.h
- M chrome/browser/web_applications/icons/trusted_icon_filter.h
- M chrome/browser/web_applications/isolated_web_apps/commands/install_isolated_web_app_command.h
- M chrome/browser/web_applications/isolated_web_apps/commands/isolated_web_app_prepare_and_store_update_command.h
- M chrome/browser/web_applications/web_app_navigation_capturing_browsertest_base.h
- M chrome/browser/webid/federated_identity_identity_provider_signin_status_context.h
- M chrome/browser/webid/federated_identity_permission_context.h
- M chrome/renderer/accessibility/read_anything/read_aloud_traversal_utils.h
- M chrome/services/file_util/single_file_tar_reader.h
- M chrome/test/base/ash/interactive/hotspot/hotspot_config_observer.h
- M chrome/test/base/ash/web_ui_browser_test.h
Change size: M
Delta: 74 files changed, 3 insertions(+), 78 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages