[bedrock] Use GetWindow()->Get{,Restored}Bounds()/SetBounds() in chrome/ [chromium/src : main]

0 views
Skip to first unread message

Neil Bao (Gerrit)

unread,
Jun 8, 2026, 8:50:51 PMJun 8
to Thomas Lukaszewicz, Qikai Zhong, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, aixba+wat...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, shend...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong and Thomas Lukaszewicz

Neil Bao voted and added 1 comment

Votes added by Neil Bao

Auto-Submit+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Neil Bao . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I416c1d1e26dfa54bf600954605b8414eba16ffa3
Gerrit-Change-Number: 7901982
Gerrit-PatchSet: 1
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 00:50:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
Jun 8, 2026, 9:28:56 PMJun 8
to Neil Bao, Qikai Zhong, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, aixba+wat...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, shend...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Neil Bao and Qikai Zhong

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
Thomas Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
  • Qikai Zhong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I416c1d1e26dfa54bf600954605b8414eba16ffa3
Gerrit-Change-Number: 7901982
Gerrit-PatchSet: 1
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Neil Bao <nei...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 01:28:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Qikai Zhong (Gerrit)

unread,
Jun 8, 2026, 9:59:07 PMJun 8
to Neil Bao, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, aixba+wat...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, shend...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Neil Bao

Qikai Zhong voted and added 1 comment

Votes added by Qikai Zhong

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Qikai Zhong . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416c1d1e26dfa54bf600954605b8414eba16ffa3
    Gerrit-Change-Number: 7901982
    Gerrit-PatchSet: 1
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Josh Karlin <jka...@chromium.org>
    Gerrit-CC: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Neil Bao <nei...@microsoft.com>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 01:58:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Neil Bao (Gerrit)

    unread,
    Jun 8, 2026, 10:54:14 PMJun 8
    to Qikai Zhong, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, aixba+wat...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, shend...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Qikai Zhong

    Neil Bao voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Qikai Zhong
    Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 02:53:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 8, 2026, 11:16:49 PMJun 8
    to Neil Bao, Qikai Zhong, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, aixba+wat...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, shend...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bedrock] Use GetWindow()->Get{,Restored}Bounds()/SetBounds() in chrome/

    Phase 1 (cont.): replace browser->window()->{GetBounds,GetRestoredBounds,
    GetRestoredState,SetBounds}() with the equivalent GetWindow() form across
    chrome/.

    Step toward eliminating Browser::window(). GetWindow() returns
    ui::BaseWindow*, which is sufficient for these bounds/state accessors.
    No behavior change.
    Bug: 496674143
    Change-Id: I416c1d1e26dfa54bf600954605b8414eba16ffa3
    Reviewed-by: Qikai Zhong <qikai...@microsoft.com>
    Commit-Queue: Neil Bao <nei...@microsoft.com>
    Auto-Submit: Neil Bao <nei...@microsoft.com>
    Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1643650}
    Files:
    • M chrome/browser/accessibility/live_caption/live_caption_surface_browsertest.cc
    • M chrome/browser/ash/accessibility/accessibility_live_site_browsertest.cc
    • M chrome/browser/ash/app_restore/full_restore_app_launch_handler_browsertest.cc
    • M chrome/browser/ash/browser_delegate/browser_delegate_impl.cc
    • M chrome/browser/ash/extensions/windows_bounds_changed_event_browsertest.cc
    • M chrome/browser/ash/magic_boost/magic_boost_browsertest.cc
    • M chrome/browser/ash/policy/dlp/dlp_content_manager_ash_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/eche_app_integration_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/help_app/help_app_integration_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/os_feedback_app_integration_browsertest.cc
    • M chrome/browser/ash/system_web_apps/system_web_app_manager_browsertest.cc
    • M chrome/browser/devtools/devtools_interactive_uitest.cc
    • M chrome/browser/extensions/api/identity/identity_apitest.cc
    • M chrome/browser/extensions/api/identity/launch_web_auth_flow_delegate_ash_browsertest.cc
    • M chrome/browser/glic/widget/glic_instance_coordinator_interactive_uitest.cc
    • M chrome/browser/metrics/tab_stats/tab_stats_tracker_browsertest.cc
    • M chrome/browser/mouse_events_interactive_uitest.cc
    • M chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc
    • M chrome/browser/performance_manager/policies/page_discarding_helper_browsertest.cc
    • M chrome/browser/picture_in_picture/auto_picture_in_picture_window_occlusion_interactive_uitest.cc
    • M chrome/browser/prefs/pref_service_browsertest.cc
    • M chrome/browser/privacy_sandbox/browsing_topics_settings_interactive_uitest.cc
    • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
    • M chrome/browser/sessions/session_restore_interactive_uitest.cc
    • M chrome/browser/sessions/session_service_base.cc
    • M chrome/browser/sessions/tab_restore_browsertest.cc
    • M chrome/browser/ui/ash/back_gesture/back_gesture_browsertest.cc
    • M chrome/browser/ui/ash/keyboard/keyboard_end_to_end_browsertest.cc
    • M chrome/browser/ui/ash/shell_delegate/tab_scrubber_browsertest.cc
    • M chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc
    • M chrome/browser/ui/browser_browsertest.cc
    • M chrome/browser/ui/browser_tabrestore.cc
    • M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
    • M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
    • M chrome/browser/ui/navigator/browser_navigator_browsertest.cc
    • M chrome/browser/ui/startup/default_browser_prompt/default_browser_modal_dialog_manager_interactive_uitest.cc
    • M chrome/browser/ui/test/popup_browsertest.cc
    • M chrome/browser/ui/test/popup_multiscreen_interactive_uitest.cc
    • M chrome/browser/ui/toolbar/app_menu_fullscreen_interactive_uitest.cc
    • M chrome/browser/ui/views/accessibility/caption_bubble_controller_views_browsertest.cc
    • M chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
    • M chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc
    • M chrome/browser/ui/views/frame/vertical_tab_strip_region_view_browsertest.cc
    • M chrome/browser/ui/views/occlusion_visibility_interactive_uitest.cc
    • M chrome/browser/ui/views/omnibox/omnibox_popup_view_views_browsertest.cc
    • M chrome/browser/ui/views/omnibox/omnibox_popup_view_webui_interactive_uitest.cc
    • M chrome/browser/ui/views/tabs/dragging/tab_drag_controller.cc
    • M chrome/browser/ui/views/tabs/dragging/tab_drag_controller_interactive_uitest.cc
    • M chrome/browser/ui/views/tabs/groups/tab_group_editor_bubble_view_browsertest.cc
    • M chrome/browser/ui/views/tabs/hovercard/tab_hover_card_controller_interactive_uitest.cc
    • M chrome/browser/ui/views/tabs/projects/projects_panel_view_interactive_uitest.cc
    • M chrome/browser/ui/views/toolbar/toolbar_controller_interactive_uitest.cc
    • M chrome/browser/ui/views/web_apps/frame_toolbar/web_app_frame_toolbar_browsertest.cc
    • M chrome/browser/ui/views/web_dialog_view_interactive_uitest.cc
    • M chrome/browser/ui/web_applications/app_browser_controller_browsertest_chromeos.cc
    • M chrome/browser/ui/web_applications/web_app_browsertest.cc
    • M chrome/browser/ui/web_applications/web_app_tab_restore_browsertest.cc
    • M chrome/browser/ui/webui/searchbox/webui_omnibox_interactive_uitest.cc
    • M chrome/browser/ui/webui/skills/skills_page_interactive_uitest.cc
    • M chrome/browser/window_management/window_management_browsertest.cc
    • M chrome/test/interaction/webcontents_interaction_test_util_interactive_uitest.cc
    Change size: L
    Delta: 61 files changed, 238 insertions(+), 236 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Qikai Zhong, +1 by Thomas Lukaszewicz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416c1d1e26dfa54bf600954605b8414eba16ffa3
    Gerrit-Change-Number: 7901982
    Gerrit-PatchSet: 2
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages