chrome/browser: Migrate BASE_FEATURE macros to 2-argument version [chromium/src : main]

0 views

Skip to first unread message

Xiaohan Wang (Gerrit)

unread,

Sep 13, 2025, 1:59:30 AM (9 days ago) Sep 13

to Daniel Cheng, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, ajayramamurth...@google.com, ananyasee...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, crisrael+w...@google.com, cros-report...@google.com, dclasson+w...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, iclella...@chromium.org, jackshira+w...@google.com, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rmcelra...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Daniel Cheng

Xiaohan Wang voted and added 1 comment

Votes added by Xiaohan Wang

Auto-Submit

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Xiaohan Wang . resolved

dcheng: Same question here. Do you prefer this large CL, or I should split it up?

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Sep 13, 2025, 8:05:12 PM (8 days ago) Sep 13

Attention needed from Xiaohan Wang

Daniel Cheng voted and added 2 comments

Votes added by Daniel Cheng

Code-Review	+1
Commit-Queue	+2
Owners-Override	+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Daniel Cheng . resolved

LGTM

File chrome/browser/ash/policy/reporting/metrics_reporting/metric_reporting_manager.cc

Line 107, Patchset 3 (Latest): "EnableFatalCrashEventsObserver",

Daniel Cheng . unresolved

This could probably be manually cleaned up in a followup? Not sure why the script skipped this one (or maybe it just got introduced later)

Open in Gerrit

Related details

Attention is currently required from:

Xiaohan Wang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Sep 13, 2025, 8:46:40 PM (8 days ago) Sep 13

Attention needed from Xiaohan Wang

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Commit-Queue

1 comment

File chrome/browser/ash/policy/reporting/metrics_reporting/metric_reporting_manager.cc

Line 107, Patchset 3 (Latest): "EnableFatalCrashEventsObserver",

Daniel Cheng . resolved

This could probably be manually cleaned up in a followup? Not sure why the script skipped this one (or maybe it just got introduced later)

Daniel Cheng

Hmph. Resolving for now.

Open in Gerrit

Related details

Attention is currently required from:

Xiaohan Wang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 13, 2025, 8:53:15 PM (8 days ago) Sep 13

to Daniel Cheng, Alexei Svitkine, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, ajayramamurth...@google.com, ananyasee...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, crisrael+w...@google.com, cros-report...@google.com, dclasson+w...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, iclella...@chromium.org, jackshira+w...@google.com, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rmcelra...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

chrome/browser: Migrate BASE_FEATURE macros to 2-argument version

This CL migrates three-argument BASE_FEATURE macros in //chrome/browser
to the new two-argument version where the C++ identifier and the string
feature name match.

This automated refactoring helps ensure that the C++ identifier and the
string feature name always match, reducing potential errors.

The following features could not be migrated automatically and may
require manual intervention:

   * kFileSystemAccessPersistentPermissions vs "kFileSystemAccessPersistentPermissions"
       * Name has k prefix.

   * kExtensionTelemetryIncludePolicyData vs "SafeBrowsingExtensionTelemetryIncludePolicyData"
       * Name has SafeBrowsing prefix.

   * kOfferPinToTaskbarWhenSettingToDefault vs "OfferPinToTaskbarWhenSettingDefault"
       * To vs When.

   * kScrollableTabStripWithDragging vs "kScrollableTabStripWithDragging"
       * Name has k prefix.

   * kScrollableTabStripOverflow vs "kScrollableTabStripOverflow"
       * Name has k prefix.

   * kForceEnabled vs "WhatsNewForceEnabled"
       * Name has WhatsNew prefix.

   * kSkipDiscardsDrivenByStaleSignal vs "SkipDiscardDrivenByStaleSignal"
       * Discards vs Discard.

   * kAnnouncementNotification vs "AnnouncementNotificationService"
       * Name has Service suffix.

   * kDiyAppsDefaultCaptureForcedOff vs "capture_forced_off_diy_apps"
       * Case and kebab-case mismatch.

   * kNavigationCapturingOnExistingFrames vs "NavigationCapturingOnCurrentFrames"
       * Existing vs Current.

   * kIconDownloaderTimeout vs "WebAppIconDownloaderTimeout"
       * Name has WebApp prefix.

   * kAILanguageModelOverrideConfiguration vs "kAILanguageModelOverrideConfiguration"
       * Name has k prefix.

   * kAIModelUnloadableProgress vs "kAIModelUnloadableProgress"
       * Name has k prefix.

   * kReportKeyCredentialManagerSupportWinFeature vs "ReportKeyCredentialManagerSupportWin"
       * Identifier has Feature suffix.

   * kMetricsReportingFeature vs "MetricsReporting"
       * Identifier has Feature suffix.

   * kPostFREFixMetricsReportingFeature vs "PostFREFixMetricsReporting"
       * Identifier has Feature suffix.

   * kDsePreload2OnSuggestNonDefalutMatch vs "kDsePreload2OnSuggestNonDefalutMatch"
       * Name has k prefix.

   * kKcerWithoutNss vs "kKcerWithoutNss"
       * Name has k prefix.

   * kLauncherImageSearchDebug vs "kLauncherImageSearchDebug"
       * Name has k prefix.

   * kLauncherSearchFileScan vs "kLauncherSearchFileScan"
       * Name has k prefix.

   * kTopicsConsentDesktopModalFeature vs "TopicsConsentDesktopModal"
       * Identifier has Feature suffix.

   * kTopicsConsentModalClankBrAppFeature vs "TopicsConsentModalClankBrApp"
       * Identifier has Feature suffix.

   * kTopicsConsentModalClankCCTFeature vs "TopicsConsentModalClankCCT"
       * Identifier has Feature suffix.

   * kProtectedAudienceMeasurementNoticeModalFeature vs "ProtectedAudienceMeasurementNoticeModal"
       * Identifier has Feature suffix.

   * kProtectedAudienceMeasurementNoticeModalClankBrAppFeature vs "ProtectedAudienceMeasurementNoticeModalClankBrApp"
       * Identifier has Feature suffix.

   * kProtectedAudienceMeasurementNoticeModalClankCCTFeature vs "ProtectedAudienceMeasurementNoticeModalClankCCT"
       * Identifier has Feature suffix.

   * kThreeAdsAPIsNoticeModalFeature vs "ThreeAdsAPIsNoticeModal"
       * Identifier has Feature suffix.

   * kThreeAdsAPIsNoticeModalClankBrAppFeature vs "ThreeAdsAPIsNoticeModalClankBrApp"
       * Identifier has Feature suffix.

   * kThreeAdsAPIsNoticeModalClankCCTFeature vs "ThreeAdsAPIsNoticeModalClankCCT"
       * Identifier has Feature suffix.

   * kMeasurementNoticeModalFeature vs "MeasurementNoticeModal"
       * Identifier has Feature suffix.

   * kMeasurementNoticeModalClankBrAppFeature vs "MeasurementNoticeModalClankBrApp"
       * Identifier has Feature suffix.

   * kMeasurementNoticeModalClankCCTFeature vs "MeasurementNoticeModalClankCCT"
       * Identifier has Feature suffix.

   * kNoticeFrameworkTopicsApiFeature vs "PSNoticeFrameworkTopicsApi"
       * Name has PS prefix.

   * kNoticeFrameworkProtectedAudienceApiFeature vs "PSNoticeFrameworkProtectedAudienceApi"
       * Name has PS prefix.

   * kNoticeFrameworkMeasurementApiFeature vs "PSNoticeFrameworkMeasurementApi"
       * Name has PS prefix.

   * kTranslateStreamingBySentence vs "kTranslateStreamingBySentence"
       * Name has k prefix.

   * kAndroidTabSkipSaveTabsKillswitch vs "AndroidTabSkipSaveTabsTaskKillswitch"
       * Name has Task prefix.

   * kAndroidXRUsesSurfaceControl vs "AndroidWindowPopupResizeAfterSpawn"
       * Identifier has different name.

   * kAndroidSearchInSettings vs "SearchInSettings"
       * Identifier has Android prefix.

   * kUmaBackgroundSessions vs "UMABackgroundSessions"
       * Case difference.

   * kCastAllowAllIPsFeature vs "CastAllowAllIPs"
       * Identifier has Feature suffix.

   * kOidcEnrollmentTimeout vs "kOidcEnrollmentTimeout"
       * Name has k prefix.

   * kEnableOidcProfileRemoteCommands vs "kEnableOidcProfileRemoteCommands"
       * Name has k prefix.

Enabled-by-default-reason: refactor
NO_IFTTT=refactor, no functionality change

Bug: 436274260

Change-Id: Ie1e197db899530edefc2d00ea0a8e2b4ceea85f3

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6943827

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Auto-Submit: Xiaohan Wang <xhw...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1515263}

Files:

M chrome/browser/actor/actor_features.cc
M chrome/browser/ai/ai_data_keyed_service.cc
M chrome/browser/android/webapk/webapk_features.cc
M chrome/browser/apps/app_preload_service/app_preload_service.cc
M chrome/browser/apps/app_service/chrome_app_deprecation/chrome_app_deprecation.cc
M chrome/browser/ash/app_list/search/search_features.cc
M chrome/browser/ash/cert_provisioning/cert_provisioning_common.cc
M chrome/browser/ash/file_suggest/item_suggest_cache.cc
M chrome/browser/ash/ownership/owner_key_loader.cc
M chrome/browser/ash/policy/core/device_cloud_policy_manager_ash.cc
M chrome/browser/ash/policy/reporting/app_install_event_log_manager_wrapper.cc
M chrome/browser/ash/policy/reporting/metrics_reporting/metric_reporting_manager.cc
M chrome/browser/background_sync/periodic_background_sync_permission_context.cc
M chrome/browser/browser_features.cc
M chrome/browser/chrome_content_browser_client.cc
M chrome/browser/component_updater/iwa_key_distribution_component_installer.cc
M chrome/browser/contextmenu/context_menu_features.cc
M chrome/browser/contextual_cueing/contextual_cueing_features.cc
M chrome/browser/device_identity/chromeos/device_oauth2_token_store_chromeos.cc
M chrome/browser/devtools/features.cc
M chrome/browser/digital_credentials/digital_credentials_keyed_service.cc
M chrome/browser/enterprise/connectors/analysis/content_analysis_features.cc
M chrome/browser/enterprise/connectors/device_trust/device_trust_features.cc
M chrome/browser/enterprise/connectors/reporting/telomere_event_router.cc
M chrome/browser/enterprise/data_protection/data_protection_features.cc
M chrome/browser/enterprise/platform_auth/platform_auth_features.cc
M chrome/browser/enterprise/profile_management/profile_management_features.cc
M chrome/browser/enterprise/remote_commands/user_remote_commands_service_factory.cc
M chrome/browser/enterprise/reporting/cloud_profile_reporting_service.cc
M chrome/browser/enterprise/watermark/watermark_features.cc
M chrome/browser/enterprise/webstore/features.cc
M chrome/browser/extensions/bookmarks/bookmarks_features.cc
M chrome/browser/extensions/component_loader.cc
M chrome/browser/extensions/cws_info_service.cc
M chrome/browser/extensions/extension_management.cc
M chrome/browser/extensions/extension_webkit_preferences.cc
M chrome/browser/fast_checkout/fast_checkout_tab_helper.cc
M chrome/browser/file_system_access/file_system_access_features.cc
M chrome/browser/first_run/first_run_features.cc
M chrome/browser/flags/android/chrome_feature_list.cc
M chrome/browser/gcm/gcm_profile_service_factory.cc
M chrome/browser/glic/fre/glic_fre_controller.cc
M chrome/browser/glic/media/glic_media_link_helper.cc
M chrome/browser/history_embeddings/history_embeddings_utils.cc
M chrome/browser/login_detection/login_detection_util.cc
M chrome/browser/mac/code_sign_clone_manager.mm
M chrome/browser/media/router/media_router_feature.cc
M chrome/browser/media/webrtc/desktop_media_picker.cc
M chrome/browser/media/webrtc/display_media_access_handler.cc
M chrome/browser/media/webrtc/thumbnail_capturer_mac.mm
M chrome/browser/media/webrtc/webrtc_log_uploader.cc
M chrome/browser/metrics/antivirus_metrics_provider_win.cc
M chrome/browser/navigation_predictor/navigation_predictor_features.cc
M chrome/browser/navigation_predictor/search_engine_preconnector.cc
M chrome/browser/nearby_sharing/common/nearby_share_features.cc
M chrome/browser/net/stub_resolver_config_reader.cc
M chrome/browser/net/system_network_context_manager.cc
M chrome/browser/notifications/chime/android/features.cc
M chrome/browser/notifications/scheduler/public/features.cc
M chrome/browser/os_crypt/app_bound_encryption_provider_win.cc
M chrome/browser/os_crypt/app_bound_encryption_win.cc
M chrome/browser/page_content_annotations/multi_source_page_context_fetcher.cc
M chrome/browser/page_info/page_info_features.cc
M chrome/browser/performance_manager/policies/discard_eligibility_policy.cc
M chrome/browser/performance_manager/policies/policy_features.cc
M chrome/browser/platform_experience/features.cc
M chrome/browser/platform_util_win.cc
M chrome/browser/policy/messaging_layer/upload/configuration_file_controller.cc
M chrome/browser/policy/messaging_layer/upload/record_upload_request_builder.cc
M chrome/browser/policy/messaging_layer/util/reporting_server_connector.cc
M chrome/browser/predictors/lcp_critical_path_predictor/lcp_critical_path_predictor_util.cc
M chrome/browser/predictors/loading_predictor.cc
M chrome/browser/predictors/predictors_features.cc
M chrome/browser/preloading/prefetch/search_prefetch/field_trial_settings.cc
M chrome/browser/preloading/preloading_features.cc
M chrome/browser/preloading/search_preload/search_preload_features.cc
M chrome/browser/privacy_sandbox/incognito/privacy_sandbox_incognito_features.cc
M chrome/browser/resource_coordinator/tab_manager_features.cc
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
M chrome/browser/search/instant_service_factory.cc
M chrome/browser/serial/serial_blocklist.cc
M chrome/browser/sharing_hub/sharing_hub_features.cc
M chrome/browser/signin/bound_session_credentials/bound_session_cookie_refresh_service_impl.cc
M chrome/browser/signin/bound_session_credentials/bound_session_registration_fetcher_param.cc
M chrome/browser/signin/signin_manager.cc
M chrome/browser/task_manager/common/task_manager_features.cc
M chrome/browser/themes/theme_service_factory.cc
M chrome/browser/tracing/tracing_features.cc
M chrome/browser/ui/ash/app_icon_color_cache/app_icon_color_cache.cc
M chrome/browser/ui/ash/focus_mode/chrome_focus_mode_delegate.cc
M chrome/browser/ui/startup/infobar_utils.cc
M chrome/browser/ui/tab_ui_helper.cc
M chrome/browser/ui/tabs/features.cc
M chrome/browser/ui/toasts/toast_features.cc
M chrome/browser/ui/ui_features.cc
M chrome/browser/ui/views/desktop_capture/desktop_media_delegated_source_list_view.cc
M chrome/browser/ui/views/desktop_capture/desktop_media_permission_pane_view_mac.mm
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
M chrome/browser/ui/views/desktop_capture/screen_capture_permission_checker_mac.mm
M chrome/browser/ui/views/frame/browser_frame_view_win.cc
M chrome/browser/ui/views/tab_sharing/tab_sharing_ui_views.cc
M chrome/browser/ui/webui/new_tab_page/composebox/variations/aim_entrypoint_fieldtrial.cc
M chrome/browser/ui/webui/new_tab_page/composebox/variations/composebox_fieldtrial.cc
M chrome/browser/ui/webui/policy/policy_ui_handler.cc
M chrome/browser/ui/webui/signin/dice_web_signin_intercept_handler.cc
M chrome/browser/user_education/user_education_service.cc
M chrome/browser/web_applications/isolated_web_apps/policy/isolated_web_app_policy_manager.cc
M chrome/browser/web_applications/isolated_web_apps/window_management/isolated_web_apps_opened_tabs_counter_service_factory.cc
M chrome/browser/web_applications/os_integration/mac/web_app_shortcut_creator.mm
M chrome/browser/web_applications/policy/web_app_policy_manager.cc
M chrome/browser/web_applications/preinstalled_app_install_features.cc
M chrome/browser/web_applications/preinstalled_web_apps/preinstalled_web_apps.cc
M chrome/browser/web_applications/visited_manifest_manager.cc
M chrome/browser/web_applications/web_app_provider.cc
M chrome/browser/web_applications/web_app_registrar.cc
M chrome/browser/web_applications/web_app_sync_bridge.cc
M chrome/browser/win/cloud_synced_folder_checker.cc
M chrome/browser/win/installer_downloader/installer_downloader_feature.cc
M chrome/browser/win/mica_titlebar.cc

Change size: XL

Delta: 119 files changed, 383 insertions(+), 1326 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages