Thomas Lukaszewicz (Gerrit)

unread,

Jul 8, 2026, 2:49:29 PM (7 days ago) Jul 8

to Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sarah Krakowiak, abigailbk...@google.com, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-regionalc...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, jeffreycohen+watc...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, nwoked...@chromium.org, rhalava...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Avi Drissman

Thomas Lukaszewicz added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Thomas Lukaszewicz . resolved

Avi ptal (sorry for the large diff, purely mechanical)

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Jul 8, 2026, 2:52:29 PM (7 days ago) Jul 8

to Thomas Lukaszewicz, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sarah Krakowiak, abigailbk...@google.com, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-regionalc...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, jeffreycohen+watc...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, nwoked...@chromium.org, rhalava...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Thomas Lukaszewicz

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Thomas Lukaszewicz (Gerrit)

unread,

Jul 8, 2026, 3:52:35 PM (7 days ago) Jul 8

to Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sarah Krakowiak, abigailbk...@google.com, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-regionalc...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, jeffreycohen+watc...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, nwoked...@chromium.org, rhalava...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Thomas Lukaszewicz voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 8, 2026, 3:56:11 PM (7 days ago) Jul 8

to Thomas Lukaszewicz, Avi Drissman, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Sarah Krakowiak, abigailbk...@google.com, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-regionalc...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, jeffreycohen+watc...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, nwoked...@chromium.org, rhalava...@chromium.org, tgupta...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Convert profile() to GetProfile() (Part 12)

No expected behavior changes. This CL updates calls to
Browser::profile() to instead be BrowserWindowInterface::GetProfile().

This change contains only the rename + reformat (if necessary)

Bug: 532248264

Change-Id: Ib7328e68e0a8388d327589ebb14d4621591b612d

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8061687

Reviewed-by: Avi Drissman <a...@chromium.org>

Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1659007}

Files:

M chrome/browser/reduce_accept_language/reduce_accept_language_browsertest.cc
M chrome/browser/regional_capabilities/regional_capabilities_service_factory_browsertest.cc
M chrome/browser/renderer_context_menu/accessibility_labels_bubble_model_browsertest.cc
M chrome/browser/renderer_context_menu/link_to_text_menu_observer_interactive_uitest.cc
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
M chrome/browser/renderer_context_menu/render_view_context_menu_interactive_uitest.cc
M chrome/browser/renderer_context_menu/spelling_bubble_model_browsertest.cc
M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
M chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc
M chrome/browser/safe_browsing/client_side_detection_host_browsertest.cc
M chrome/browser/safe_browsing/cloud_content_scanning/cloud_binary_upload_service_browsertest.cc
M chrome/browser/safe_browsing/download_protection/deep_scanning_browsertest.cc
M chrome/browser/safe_browsing/extension_telemetry/extension_telemetry_service_browsertest.cc
M chrome/browser/safe_browsing/gemini_antiscam_protection/gemini_antiscam_protection_service_browsertest.cc
M chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_browsertest.cc
M chrome/browser/safe_browsing/ohttp_key_service_browsertest.cc
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
M chrome/browser/safe_browsing/test_safe_browsing_navigation_observer_manager.cc
M chrome/browser/safe_browsing/url_lookup_service_browsertest.cc
M chrome/browser/save_to_drive/save_to_drive_flow_browsertest.cc
M chrome/browser/screen_ai/main_content_extraction_browsertest.cc
M chrome/browser/screen_ai/optical_character_recognizer_browsertest.cc
M chrome/browser/screen_ai/screen_ai_service_router_browsertest.cc
M chrome/browser/search/background/wallpaper_search/wallpaper_search_browsertest.cc
M chrome/browser/search/instant_browsertest_base.cc
M chrome/browser/search/instant_service_browsertest.cc
M chrome/browser/search_engine_choice/search_engine_choice_dialog_browsertest.cc
M chrome/browser/search_engine_choice/search_engine_choice_dialog_interactive_uitest.cc
M chrome/browser/search_engine_choice/search_engine_choice_service_browsertest.cc
M chrome/browser/search_engines/template_url_scraper_browsertest.cc
M chrome/browser/search_engines/template_url_service_browsertest.cc
M chrome/browser/segmentation_platform/client_util/local_tab_handler_browsertest.cc
M chrome/browser/send_tab_to_self/send_tab_to_self_scroll_observer_browsertest.cc
M chrome/browser/serial/chrome_serial_browsertest.cc
M chrome/browser/sessions/better_session_restore_browsertest.cc
M chrome/browser/sessions/encrypted_session_storage_browsertest.cc
M chrome/browser/sessions/exit_type_service_browsertest.cc
M chrome/browser/sessions/session_restore_browsertest.cc
M chrome/browser/sessions/session_restore_browsertest_chromeos.cc
M chrome/browser/sessions/session_restore_interactive_uitest.cc

Change size: L

Delta: 42 files changed, 307 insertions(+), 296 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Avi Drissman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Convert profile() to GetProfile() (Part 12) [chromium/src : main]

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz added 1 comment

Related details

Avi Drissman (Gerrit)

Avi Drissman voted Code-Review+1

Related details

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information