Add null check on TabLifecycleUnitExternal before usage [chromium/src : main]

0 views

Skip to first unread message

Devlin Cronin (Gerrit)

unread,

Feb 4, 2026, 4:16:22 PMFeb 4

to Utkarsh Patankar, Patrick Monette, Devlin Cronin, Chromium LUCI CQ, AyeAye, chrome-gr...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Patrick Monette and Utkarsh Patankar

Devlin Cronin added 1 comment

File chrome/browser/extensions/api/tabs/tabs_api.cc

Line 2328, Patchset 5: if (!tab_lifecycle_unit_external) {

Devlin Cronin . unresolved

in which scenario can this happen? Can we:
a) Document it in a comment
b) Add a regression test?

Utkarsh Patankar

I'm not sure in which scenario this can happen but I was able to add a regression test to simulate this scenario and test the fix.

Devlin Cronin

I think we should figure out if this is something that can happen in Chromium today (where extensions are only supported in android on the experimental desktop android build). If it is an issue there, we should fix it (and the fix might be different). Is this is only something that can happen because of the ways in which Edge leverages this code, I'm not sure it makes sense to upstream this patch.

Calder, you recently chimed in on the [similar CL here](https://chromium-review.googlesource.com/c/chromium/src/+/7509428); do you happen to know if we always expect TabLifecycle to be associated with a WebContents on desktop android?

Open in Gerrit

Related details

Attention is currently required from:

Patrick Monette
Utkarsh Patankar

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages