Update copyright headers in chrome [chromium/src : main]

0 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
Sep 8, 2022, 4:56:51 PM9/8/22
to Mark Mentovai, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Avi Drissman

Avi Drissman (Gerrit)

unread,
Sep 8, 2022, 4:57:30 PM9/8/22
to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

Attention is currently required from: Mark Mentovai.

Patch set 1:Auto-Submit +1Owners-Override +1

View Change

1 comment:

To view, visit change 3884228. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I14e9cf8eb187810a77bdc0b109e0efa371d6831e
Gerrit-Change-Number: 3884228
Gerrit-PatchSet: 1
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Charlie Hu <chen...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Dominic Schulz <domini...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Michael Moss <mm...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Sep 2022 20:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Elly Fong-Jones (Gerrit)

unread,
Sep 8, 2022, 5:36:12 PM9/8/22
to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Elly Fong-Jones, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

Attention is currently required from: Avi Drissman, Mark Mentovai.

Patch set 1:Code-Review +1

View Change

1 comment:

To view, visit change 3884228. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I14e9cf8eb187810a77bdc0b109e0efa371d6831e
Gerrit-Change-Number: 3884228
Gerrit-PatchSet: 1
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Elly Fong-Jones <elly...@chromium.org>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Sep 2022 21:35:17 +0000

Avi Drissman (Gerrit)

unread,
Sep 9, 2022, 1:33:17 PM9/9/22
to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Elly Fong-Jones, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

Avi Drissman abandoned this change.

View Change

Abandoned merge conflict; will re-create
Gerrit-MessageType: abandon

Avi Drissman (Gerrit)

unread,
Sep 9, 2022, 2:07:33 PM9/9/22
to Mark Mentovai, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Avi Drissman

Avi Drissman (Gerrit)

unread,
Sep 9, 2022, 2:08:26 PM9/9/22
to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

Attention is currently required from: Mark Mentovai.

Patch set 1:Auto-Submit +1Owners-Override +1

View Change

    To view, visit change 3888258. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5caf6b21db9c12bea71258223f59c1ac4313a738
    Gerrit-Change-Number: 3888258
    Gerrit-PatchSet: 1
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Charlie Hu <chen...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Dominic Schulz <domini...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Michael Moss <mm...@chromium.org>
    Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Ryan Sultanem <rs...@google.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Tommy Li <tomm...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Sep 2022 18:07:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Mark Mentovai (Gerrit)

    unread,
    Sep 9, 2022, 3:08:00 PM9/9/22
    to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

    Attention is currently required from: Avi Drissman.

    Patch set 2:Code-Review +1Commit-Queue +2

    View Change

    19 comments:

    • Patchset:

      • Patch Set #2:

        I’m going to C-Q this now because I know you’ll want to address all of the concerns I’m raising that you agree need fixing in a follow-up.

    • File chrome/android/features/start_surface/java/res/values/ids.xml:

      • Patch Set #1, Line 4:

        44 files including this one have an incorrect blank line in the middle of the boilerplate.

        chrome/android/features/start_surface/java/res/values/ids.xml
        chrome/android/features/tab_ui/java/res/values/ids.xml
        chrome/android/features/tab_ui/java/res/values/styles.xml
        chrome/android/feed/core/java/res/values/ids.xml
        chrome/android/java/res/anim/accelerate_quart.xml
        chrome/android/java/res/anim/activity_close_exit.xml
        chrome/android/java/res/anim/activity_open_enter.xml
        chrome/android/java/res/anim/decelerate_quart.xml
        chrome/android/java/res/drawable-ldrtl-v17/btn_back.xml
        chrome/android/java/res/drawable-ldrtl-v17/btn_forward.xml
        chrome/android/java/res/drawable-v23/distilled_page_pref_background.xml
        chrome/android/java/res/drawable/accessibility_tab_switcher_divider.xml
        chrome/android/java/res/drawable/btn_back.xml
        chrome/android/java/res/drawable/btn_bg_holo.xml
        chrome/android/java/res/drawable/btn_bg_holo_active.xml
        chrome/android/java/res/drawable/btn_forward.xml
        chrome/android/java/res/drawable/distilled_page_prefs_button_bg.xml
        chrome/android/java/res/drawable/store_locally_tooltip_background.xml
        chrome/android/java/res/layout/accessibility_tab_switcher.xml
        chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml
        chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
        chrome/android/java/res/layout/distilled_page_prefs_view.xml
        chrome/android/java/res/layout/fre_tosanduma.xml
        chrome/android/java/res/layout/lightweight_fre_tos.xml
        chrome/android/java/res/layout/password_generation_popup_explanation.xml
        chrome/android/java/res/layout/suspended_tab.xml
        chrome/android/java/res/values-h600dp/dimens.xml
        chrome/android/java/res/values-hdpi/dimens.xml
        chrome/android/java/res/values-sw600dp/values.xml
        chrome/android/java/res/values-xhdpi/dimens.xml
        chrome/android/java/res/values/ids.xml
        chrome/android/java/res/values/strings.xml
        chrome/android/webapk/libs/common/res_splash/layout/webapp_splash_screen_large.xml
        chrome/android/webapk/libs/common/res_splash/layout/webapp_splash_screen_no_icon.xml
        chrome/android/webapk/shell_apk/res/values-v24/default_enabled_activity.xml
        chrome/android/webapk/shell_apk/res/values/default_enabled_activity.xml
        chrome/browser/content_creation/notes/internal/android/java/res/values/styles.xml
        chrome/browser/search_engines/android/java/res/values/ids.xml
        chrome/browser/tab/java/res/layout/sad_tab.xml
        chrome/browser/ui/android/appmenu/internal/java/res/layout/icon_row_menu_item.xml
        chrome/browser/ui/android/appmenu/internal/java/res/layout/menu_item.xml
        chrome/browser/ui/android/appmenu/internal/java/res/layout/menu_item_start_with_icon.xml
        chrome/browser/ui/android/appmenu/internal/java/res/layout/title_button_menu_item.xml
        chrome/browser/ui/android/omnibox/java/res/values/ids.xml
        chrome/browser/ui/android/toolbar/java/res/values/ids.xml

    • File chrome/android/java/src/org/chromium/chrome/browser/customtabs/content/CustomTabActivityTabProvider.java:

      • Patch Set #1, Line 2: 

         * Copyright 2019 The Chromium Authors
         * Use of this source code is governed by a BSD-style license that can be
         * found in the LICENSE file.

        Our Java source seems to always use `//` comments for the boilerplate, this is a lone outlier (in chrome).

    • File chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.cc:

      • Patch Set #1, Line 2: 

         * Copyright 2013 The Chromium Authors
         * Use of this source code is governed by a BSD-style license that can be
         * found in the LICENSE file.

        In 4 files including this one, a very unusual `/* */` comment style for our C++ code.

        chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.cc
        chrome/test/data/nacl/exit_status/pm_exit_status_test.cc
        chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc
        chrome/test/data/nacl/sysconf_nprocessors_onln/sysconf_nprocessors_onln_test.cc

    • File chrome/browser/feed/android/java/res/values-night/colors.xml:

      • Patch Set #1, Line 4: found in the LICENSE file.-->

        In 5 files including this one, the `-->` is butted right up against the `.`, which is contrary to the way we usually do these.

        chrome/browser/feed/android/java/res/values-night/colors.xml
        chrome/browser/feed/android/java/res/values/colors.xml
        chrome/browser/resources/browsing_topics/browsing_topics_internals.html
        chrome/browser/share/android/java/res/values-night/colors.xml
        chrome/browser/share/android/java/res/values/colors.xml

    • File chrome/browser/resources/gaia_auth_host/saml_username_autofill_test.unitjs:

      • File chrome/browser/resources/invalidations/BUILD.gn:

        • Patch Set #1, Line 3: # found in the LICENSE file

          In 2 files including this one, this line does not end with a period as it’s supposed to.

          chrome/browser/resources/invalidations/BUILD.gn
          chrome/browser/resources/net_internals/BUILD.gn

      • File chrome/browser/ui/android/appmenu/internal/test/java/res/layout/test_menu_footer.xml:

        • Patch Set #1, Line 1: <?xml version="1.0" encoding="utf-8"?><!-- Copyright 2019 The Chromium Authors

          The boilerplate comment is butted up against the `<?xml>`, unusual.

      • File chrome/browser/ui/webui/signin/signin_ui_error.cc:

        • Patch Set #1, Line 1: /// Copyright 2021 The Chromium Authors

          In 4 files including this one, too many slashes on this line:

          chrome/browser/ui/webui/signin/signin_ui_error.cc
          chrome/browser/ui/webui/signin/signin_ui_error.h
          chrome/test/base/profile_waiter.cc
          chrome/test/base/profile_waiter.h

      • File chrome/chrome_cleaner/test/resources/resource_ids:

      • File chrome/common/chrome_version.h.in:

        • Patch Set #1, Line 2: // Use of this source is governed by a BSD-style license that can be

          This line is missing the word “code” after “source”.

      • File chrome/common/win/eventlog_messages.mc and b/chrome/common/win/eventlog_messages.mc:

        • File chrome/test/android/browsertests_apk/AndroidManifest.xml.jinja2:

        • File chrome/test/data/cast/cast_mirroring_performance_browsertest.css:

          • Patch Set #1, Line 2: * Use of this source code is governed by a BSD-style license that can be

            There’s an extra space before “Use”.

        • File chrome/test/data/extensions/api_test/content_settings/incognitoisolation/test.html:

          • Patch Set #1, Line 3: 

             * Use of this source code is governed by a BSD-style license that can be found
             * in the LICENSE file.

            In 4 files including this one, this line was rewrapped contrary to our standard. The break should be after the word “be”.

            chrome/test/data/extensions/api_test/content_settings/incognitoisolation/test.html
            chrome/test/data/extensions/api_test/webrequest/test_simple_cancel.html
            chrome/test/data/extensions/api_test/webrequest/test_simple_cancel_navigation.html
            chrome/test/data/extensions/api_test/webrequest/test_simple_websocket_cancel.html

        • File chrome/test/data/extensions/api_test/executescript/bad_encoding/bad_encoding.js:

          • Patch Set #1:

            Tools assuming UTF-8 don’t like this file, so I manually reviewed.

        • File chrome/test/data/extensions/calculator_app/LICENSE:

        • File chrome/test/data/extensions/platform_apps/web_view/dom_storage_isolation/page.html:

        • File chrome/test/data/nacl/exit_status/pm_exit_status_test.html:

          • Patch Set #1, Line 3: Use of this source code is governed by a BSD-style license that can

            In 3 files including this one, this line was rewrapped contrary to our standard. The break should be after the word “be”.

            chrome/test/data/nacl/exit_status/pm_exit_status_test.html
            chrome/test/data/nacl/manifest_file/irt_manifest_file_test.html
            chrome/test/data/nacl/sysconf_nprocessors_onln/sysconf_nprocessors_onln_test.html

        To view, visit change 3888258. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I5caf6b21db9c12bea71258223f59c1ac4313a738
        Gerrit-Change-Number: 3888258
        Gerrit-PatchSet: 2
        Gerrit-Attention: Avi Drissman <a...@chromium.org>
        Gerrit-Comment-Date: Fri, 09 Sep 2022 19:06:14 +0000

        Avi Drissman (Gerrit)

        unread,
        Sep 9, 2022, 3:19:50 PM9/9/22
        to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Chromium LUCI CQ, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

        Attention is currently required from: Mark Mentovai.

        Patch set 3:Auto-Submit +1Owners-Override +1

        View Change

          To view, visit change 3888258. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I5caf6b21db9c12bea71258223f59c1ac4313a738
          Gerrit-Change-Number: 3888258
          Gerrit-PatchSet: 3
          Gerrit-Owner: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Charlie Hu <chen...@google.com>
          Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
          Gerrit-Comment-Date: Fri, 09 Sep 2022 19:18:37 +0000

          Mark Mentovai (Gerrit)

          unread,
          Sep 9, 2022, 3:20:44 PM9/9/22
          to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Chromium LUCI CQ, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

          Attention is currently required from: Avi Drissman.

          Patch set 3:Code-Review +1Commit-Queue +2

          View Change

          1 comment:

          • Patchset:

            • Patch Set #3:

              Noted the removal in patch set 3 of:

              chrome/browser/plugins/plugin_finder.h
              chrome/browser/plugins/plugin_finder.cc
              chrome/browser/plugins/plugin_finder_unittest.cc
              chrome/browser/plugins/plugin_infobar_delegates.h
              chrome/browser/plugins/plugin_infobar_delegates.cc
              chrome/browser/plugins/plugin_installer.h
              chrome/browser/plugins/plugin_installer.cc
              chrome/browser/plugins/plugin_installer_observer.h
              chrome/browser/plugins/plugin_installer_observer.cc
              chrome/browser/plugins/plugin_installer_unittest.cc

          Gerrit-Attention: Avi Drissman <a...@chromium.org>
          Gerrit-Comment-Date: Fri, 09 Sep 2022 19:20:00 +0000

          Avi Drissman (Gerrit)

          unread,
          Sep 9, 2022, 3:35:29 PM9/9/22
          to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com

          Chromium LUCI CQ (Gerrit)

          unread,
          Sep 9, 2022, 3:37:40 PM9/9/22
          to Avi Drissman, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Mark Mentovai, Akihiro Ota, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

          KAMPANAT THUMWONG (Gerrit)

          unread,
          Feb 13, 2023, 7:38:54 AM2/13/23
          to Avi Drissman, Chromium LUCI CQ, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

          Attention is currently required from: KAMPANAT THUMWONG.

          View Change

          1 comment:

          To view, visit change 3888258. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I5caf6b21db9c12bea71258223f59c1ac4313a738
          Gerrit-Change-Number: 3888258
          Gerrit-PatchSet: 5
          Gerrit-Owner: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Charlie Hu <chen...@google.com>
          Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-CC: Dominic Schulz <domini...@google.com>
          Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
          Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
          Gerrit-CC: James Maclean <wjma...@chromium.org>
          Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
          Gerrit-CC: Jiewei Qian <q...@chromium.org>
          Gerrit-CC: KAMPANAT THUMWONG <kongp...@gmail.com>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-CC: Kevin McNee <mc...@chromium.org>
          Gerrit-CC: Lei Zhang <the...@chromium.org>
          Gerrit-CC: Mathias Bynens <mat...@chromium.org>
          Gerrit-CC: Michael Moss <mm...@chromium.org>
          Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
          Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
          Gerrit-CC: Peter Beverloo <pe...@chromium.org>
          Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-CC: Ryan Sultanem <rs...@google.com>
          Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
          Gerrit-CC: Tommy Li <tomm...@chromium.org>
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: KAMPANAT THUMWONG <kongp...@gmail.com>
          Gerrit-Comment-Date: Mon, 13 Feb 2023 12:38:12 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Gerrit-MessageType: comment

          KAMPANAT THUMWONG (Gerrit)

          unread,
          Feb 13, 2023, 7:40:51 AM2/13/23
          to Avi Drissman, Chromium LUCI CQ, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

          View Change

          1 comment:

          To view, visit change 3888258. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Comment-Date: Mon, 13 Feb 2023 12:40:19 +0000

          KAMPANAT THUMWONG (Gerrit)

          unread,
          Feb 13, 2023, 9:22:18 AM2/13/23
          to Avi Drissman, Chromium LUCI CQ, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dominic Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean

          Attention is currently required from: Avi Drissman, Daniel Cheng, KAMPANAT THUMWONG, Sadrul Chowdhury.

          View Change

          1 comment:

          • File chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.cc:

            • Patch Set #1, Line 2: 

               * Copyright 2013 The Chromium Authors
               * Use of this source code is governed by a BSD-style license that can be
               * found in the LICENSE file.

            • In 4 files including this one, a very unusual `/* */` comment style for our C++ code. […]

              kongp...@gmail.com

          To view, visit change 3888258. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I5caf6b21db9c12bea71258223f59c1ac4313a738
          Gerrit-Change-Number: 3888258
          Gerrit-PatchSet: 5
          Gerrit-Owner: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: KAMPANAT THUMWONG <kongp...@gmail.com>
          Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Charlie Hu <chen...@google.com>
          Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-CC: Dominic Schulz <domini...@google.com>
          Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
          Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
          Gerrit-CC: James Maclean <wjma...@chromium.org>
          Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
          Gerrit-CC: Jiewei Qian <q...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-CC: Kevin McNee <mc...@chromium.org>
          Gerrit-CC: Lei Zhang <the...@chromium.org>
          Gerrit-CC: Mathias Bynens <mat...@chromium.org>
          Gerrit-CC: Michael Moss <mm...@chromium.org>
          Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
          Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
          Gerrit-CC: Peter Beverloo <pe...@chromium.org>
          Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-CC: Ryan Sultanem <rs...@google.com>
          Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
          Gerrit-CC: Tommy Li <tomm...@chromium.org>
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
          Gerrit-Attention: Avi Drissman <a...@chromium.org>
          Gerrit-Attention: Sadrul Chowdhury <sad...@chromium.org>
          Gerrit-Attention: KAMPANAT THUMWONG <kongp...@gmail.com>
          Gerrit-Comment-Date: Mon, 13 Feb 2023 14:21:38 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
          Gerrit-MessageType: comment

          Eimy Diaz (Gerrit)

          unread,
          Apr 7, 2026, 8:15:34 PMApr 7
          to Chromium LUCI CQ, Avi Drissman, Mark Mentovai, Christian Biesinger, Charlie Hu, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dom Schulz, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Javier Fernandez, Kevin Babbitt, Mathias Bynens, Kevin McNee, Michael Moss, Nancy Wang, native-cli...@googlegroups.com, Giovanni Ortuno Urquidi, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Ryan Sultanem, Sadrul Chowdhury, Lei Zhang, Tommy Li, James Maclean, abigailbk...@google.com, ajwong...@chromium.org, alancutter...@chromium.org, alemat...@chromium.org, amalov...@chromium.org, amraboelk...@chromium.org, anastas...@google.com, andysjl...@chromium.org, anthony...@chormium.org, antoniosarto...@chromium.org, antoniosartori+wa...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, ashleydp+fe...@google.com, asvitki...@chromium.org, autofill_ass...@google.com, azeemarshad+w...@chromium.org, azeemarshad+...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, bhatiaro...@chromium.org, blundell+in...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, caitkp...@chromium.org, cambickel+fe...@google.com, carlos...@chromium.org, cc-...@chromium.org, cclem+wat...@google.com, cclem+watc...@google.com, cclem+wat...@google.com, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-shari...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cmfcmf...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-essential...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-teleme...@google.com, cros-tele...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, cwp-review...@google.com, danlee+watch...@google.com, danlee+wa...@google.com, danlee+watc...@google.com, danlee+wa...@google.com, davidj...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watc...@chromium.org, dominickn+...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watch-...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dpr...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, ender...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, freedj...@chromium.org, fuchsia...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gavinwill+sc...@chromium.org, gavinwill+watch-...@chromium.org, gayane...@chromium.org, gcasto+w...@chromium.org, glenro...@chromium.org, gogerald+pa...@chromium.org, gogeral...@chromium.org, gordonseto+wa...@google.com, gordonseto+w...@google.com, grt+...@chromium.org, hais+wat...@google.com, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hanxi...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hnakashi...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, isandr...@chromium.org, iwells...@chromium.org, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jeffreyco...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+watch...@chromium.org, jimmyxgong+w...@chromium.org, jinsukk...@chromium.org, jmedle...@chromium.org, joenotcha...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsaul+aut...@google.com, jshikaram+watch...@chromium.org, jshikaram+watch-a...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khmel...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, knollr+wa...@chromium.org, knollr+wat...@chromium.org, kristipa...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, lingqi...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marcinjb...@google.com, martijn...@martijnc.be, mattreyno...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, melzhang+wat...@chromium.org, melzhang+watch...@chromium.org, melzhang+wat...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, michaelpg+wa...@chromium.org, mickeybu...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch-...@chromium.org, mxcai+wat...@chromium.org, nator...@chromium.org, nburris+pa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olesiamaru...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, peconn...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pshmako...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rlp+...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsleev...@chromium.org, sarakat...@chromium.org, security-...@chromium.org, shannc...@chromium.org, shend...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, spdongh...@chromium.org, speed-metr...@chromium.org, spelchat+ch...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, tgupta...@chromium.org, tjohnsonkanu+w...@google.com, tjohnsonkanu+...@google.com, tommcke...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webapks-...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, wfh+...@chromuium.org, wittma...@chromium.org, wnwen...@chromium.org, wychen...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zentaro+sca...@chromium.org, zentaro+watch-a...@chromium.org, zentaro+wat...@chromium.org, zhangwenyu+f...@google.com
          Attention needed from Deleted User and Sadrul Chowdhury

          Eimy Diaz added 1 comment

          Patchset-level comments
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Deleted User
          • Sadrul Chowdhury
          Submit Requirements:
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I5caf6b21db9c12bea71258223f59c1ac4313a738
          Gerrit-Change-Number: 3888258
          Gerrit-PatchSet: 5
          Gerrit-Owner: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Deleted User
          Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Charlie Hu <chen...@google.com>
          Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-CC: Deleted User
          Gerrit-CC: Dom Schulz <domini...@google.com>
          Gerrit-CC: Eimy Diaz <diazei...@gmail.com>
          Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
          Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
          Gerrit-CC: James Maclean <wjma...@chromium.org>
          Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
          Gerrit-CC: Jiewei Qian <q...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-CC: Kevin McNee <mc...@chromium.org>
          Gerrit-CC: Lei Zhang <the...@chromium.org>
          Gerrit-CC: Mathias Bynens <mat...@chromium.org>
          Gerrit-CC: Michael Moss <mm...@chromium.org>
          Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
          Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
          Gerrit-CC: Peter Beverloo <pe...@chromium.org>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-CC: Ryan Sultanem <rs...@google.com>
          Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
          Gerrit-CC: Tommy Li <tomm...@chromium.org>
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: Sadrul Chowdhury <sad...@chromium.org>
          Gerrit-Attention: Deleted User
          Gerrit-Comment-Date: Wed, 08 Apr 2026 00:14:35 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages