Revert "[discard] Set single_outermost_main_frame for WebContentsDiscard" [chromium/src : main]

0 views
Skip to first unread message

Takashi Sakamoto (Gerrit)

unread,
Dec 7, 2025, 10:37:20 PMDec 7
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Keren Zhu, Tom Lukaszewicz, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Keren Zhu and Tom Lukaszewicz

Takashi Sakamoto voted

Auto-Submit+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keren Zhu
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I54c16b621cf12995f9ec71c1c11ce8bc738b1e05
Gerrit-Change-Number: 7234854
Gerrit-PatchSet: 1
Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Keren Zhu <kere...@chromium.org>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Mon, 08 Dec 2025 03:36:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Dec 7, 2025, 10:37:25 PMDec 7
to Takashi Sakamoto, AyeAye, Chromium LUCI CQ, Keren Zhu, Tom Lukaszewicz, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Keren Zhu and Tom Lukaszewicz

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Keren Zhu
  • Tom Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I54c16b621cf12995f9ec71c1c11ce8bc738b1e05
    Gerrit-Change-Number: 7234854
    Gerrit-PatchSet: 1
    Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Keren Zhu <kere...@chromium.org>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Mon, 08 Dec 2025 03:37:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 7, 2025, 10:37:45 PMDec 7
    to Takashi Sakamoto, Rubber Stamper, AyeAye, Keren Zhu, Tom Lukaszewicz, chromium...@chromium.org, chrome-gr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[discard] Set single_outermost_main_frame for WebContentsDiscard"

    This reverts commit c1cbe491acbbefe17efe7ea6b4e31bb71da35ba4.

    Reason for revert: crrev.com/c/7235172 needs this revert.

    Original change's description:
    > [discard] Set single_outermost_main_frame for WebContentsDiscard
    >
    > This CL updates AttemptFastKillForDiscard() to set the
    > single_outermost_main_frame param for FastShutdownIfPossible() when
    > running the WebContentsDiscard experiment.
    >
    > This param allows fast-kills in the case where all frames resident
    > in a process belong to a single WebContents, vs page_count which
    > checks for RenderWidgetHost counts (all of which may belong to
    > a single tab but add to a count greater than 0).
    >
    > This CL affects behavior only when running WebContentsDiscard
    > (behavior is unchanged otherwise).
    >
    > Bug: 463735439
    > Change-Id: Ide557a6821f7a8c66dd6871b7281d04bd0693cbf
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7205447
    > Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
    > Reviewed-by: Keren Zhu <kere...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1555253}
    Bug: 463735439
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I54c16b621cf12995f9ec71c1c11ce8bc738b1e05
    Auto-Submit: Takashi Sakamoto <ta...@google.com>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Owners-Override: Takashi Sakamoto <ta...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1555272}
    Files:
    • M chrome/browser/resource_coordinator/utils.cc
    Change size: S
    Delta: 1 file changed, 2 insertions(+), 12 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I54c16b621cf12995f9ec71c1c11ce8bc738b1e05
    Gerrit-Change-Number: 7234854
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages