[bedrock] Remove Browser* from tab_manager_unittest [chromium/src : main]
1 view
Skip to first unread message
Daniel Rubery (Gerrit)
May 1, 2026, 10:58:54 AMMay 1
to chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chrome-gr...@chromium.org
Attention needed from chromium-bedrock-reviews
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- chromium-bedrock-reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
May 1, 2026, 11:01:43 AMMay 1
to Daniel Rubery, chromium-bedrock-reviews, Sophie Chang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chrome-gr...@chromium.org
Attention needed from Sophie Chang
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
sophi...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)
Related details
Attention is currently required from:
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
May 1, 2026, 8:18:33 PMMay 1
to Daniel Rubery, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chrome-gr...@chromium.org
Attention needed from Daniel Rubery
Sophie Chang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Rubery
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
May 4, 2026, 11:38:51 AM (13 days ago) May 4
to Sophie Chang, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chrome-gr...@chromium.org
Daniel Rubery voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 4, 2026, 12:29:28 PM (13 days ago) May 4
to Daniel Rubery, Sophie Chang, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[bedrock] Remove Browser* from tab_manager_unittest
This CL moves the one test that users a Browser* in
chrome/browser/resource_coordinator/tab_manager_unittest.cc to the
browser test file.
Patchset 1 is a pure move of the test.
Fixed: 508301692
Commit-Queue: Daniel Rubery <dru...@chromium.org>
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1624745}
Files:
- M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
- M chrome/browser/resource_coordinator/tab_manager_unittest.cc
Change size: M
Delta: 2 files changed, 60 insertions(+), 64 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sophie Chang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages