Remove ui_test_utils::GetTestUrl from c/b/picture_in* to c/b/translate [chromium/src : main]
1 view
Skip to first unread message
Ho Cheung (Gerrit)
Oct 30, 2025, 10:59:03 AM (8 days ago) Oct 30
to Avi Drissman, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, mac-r...@chromium.org, chrome-gr...@chromium.org, translat...@chromium.org
Attention needed from Avi Drissman
Ho Cheung voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ho Cheung
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ho Cheung . resolved
@Avi, please take a look at this CL; it's the third in a series of CLs. Also, I've cleaned up the header files that are no longer needed, thank you.
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Oct 30, 2025, 11:01:09 AM (8 days ago) Oct 30
to Ho Cheung, Avi Drissman, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, mac-r...@chromium.org, chrome-gr...@chromium.org, translat...@chromium.org
Attention needed from Ho Cheung
Avi Drissman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Avi Drissman
| Code-Review | +1 |
1 comment
Patchset-level comments
Ho Cheung . resolved
@Avi, please take a look at this CL; it's the third in a series of CLs. Also, I've cleaned up the header files that are no longer needed, thank you.
Avi Drissman
From this CL on, I will rely on your cleaning up the header files when appropriate, so no need to explicitly mention it. 👍
Related details
Attention is currently required from:
- Ho Cheung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ho Cheung (Gerrit)
Oct 30, 2025, 11:23:18 AM (8 days ago) Oct 30
to Avi Drissman, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, mac-r...@chromium.org, chrome-gr...@chromium.org, translat...@chromium.org
Ho Cheung voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 30, 2025, 12:09:33 PM (8 days ago) Oct 30
to Ho Cheung, Avi Drissman, Enterprise Policy Reviews, AyeAye, mac-r...@chromium.org, chrome-gr...@chromium.org, translat...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove ui_test_utils::GetTestUrl from c/b/picture_in* to c/b/translate
This CL updates test files to use chrome_test_utils::GetTestUrl instead
of ui_test_utils::GetTestUrl for constructing test URLs.
Also add the appropriate dependencies in `c/b/picture_in*/BUILD.gn`.
Bug: 443361437
Change-Id: I2386dcd37d3a7f224d2a11c84b61248211329bb5
Reviewed-by: Avi Drissman <a...@chromium.org>
Commit-Queue: Ho Cheung <hoch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1537976}
Files:
- M chrome/browser/picture_in_picture/BUILD.gn
- M chrome/browser/picture_in_picture/auto_picture_in_picture_tab_helper_browsertest.cc
- M chrome/browser/picture_in_picture/document_picture_in_picture_mixin_test_base.cc
- M chrome/browser/picture_in_picture/document_picture_in_picture_pixel_browsertest.cc
- M chrome/browser/picture_in_picture/document_picture_in_picture_window_controller_browsertest.cc
- M chrome/browser/picture_in_picture/video_picture_in_picture_window_controller_browsertest.cc
- M chrome/browser/policy/test/browsing_history_policy_browsertest.cc
- M chrome/browser/profiles/profile_window_browsertest.cc
- M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
- M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm
- M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
- M chrome/browser/save_to_drive/pdf_content_reader_browsertest.cc
- M chrome/browser/save_to_drive/save_to_drive_event_dispatcher_browsertest.cc
- M chrome/browser/save_to_drive/save_to_drive_flow_browsertest.cc
- M chrome/browser/sessions/exit_type_service_browsertest.cc
- M chrome/browser/sessions/session_restore_browsertest.cc
- M chrome/browser/sessions/session_restore_interactive_uitest.cc
- M chrome/browser/sessions/tab_restore_browsertest.cc
- M chrome/browser/task_manager/task_manager_browsertest.cc
- M chrome/browser/translate/translate_manager_browsertest.cc
Change size: M
Delta: 20 files changed, 97 insertions(+), 81 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages