Add some missing includes of //base/time/time.h [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Aug 11, 2025, 4:36:11 PMAug 11
to Enterprise Policy Reviews, Mathias Bynens, Sean Maher, Thiabaud Engelbrecht, 王若宸, AyeAye, Chromium LUCI CQ, tbarzi...@chromium.org, rrsilva+wat...@google.com, mac-r...@chromium.org, odejesu...@chromium.org, mattreyno...@chromium.org, arc-review...@google.com, oshima...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, hashimo...@chromium.org, chrome-gr...@chromium.org, chromotin...@chromium.org, rouslan+au...@chromium.org, prerenderi...@chromium.org, tburkar...@chromium.org, gavin...@chromium.org, blink-revi...@chromium.org, hansberry+w...@chromium.org, crisrael+w...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, hais+wat...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, ajayramamurth...@google.com, performance-m...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, feature-me...@chromium.org, scheduler...@chromium.org, network-ser...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chrome-tab-group-en...@google.com, net-r...@chromium.org, mpdento...@chromium.org, glazuno...@chromium.org
Attention needed from David Sanders

Message from David Sanders

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f0207b68dfe3c77d517e44e37b034169db85453
Gerrit-Change-Number: 6832689
Gerrit-PatchSet: 30
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: 王若宸 <jo198...@gmail.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 20:36:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Aug 13, 2025, 1:56:51 PMAug 13
to David Sanders, Lei Zhang, Enterprise Policy Reviews, Mathias Bynens, Sean Maher, Thiabaud Engelbrecht, 王若宸, AyeAye, Chromium LUCI CQ, tbarzi...@chromium.org, rrsilva+wat...@google.com, mac-r...@chromium.org, odejesu...@chromium.org, mattreyno...@chromium.org, arc-review...@google.com, oshima...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, hashimo...@chromium.org, chrome-gr...@chromium.org, chromotin...@chromium.org, rouslan+au...@chromium.org, prerenderi...@chromium.org, tburkar...@chromium.org, gavin...@chromium.org, blink-revi...@chromium.org, hansberry+w...@chromium.org, crisrael+w...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, hais+wat...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, ajayramamurth...@google.com, performance-m...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, feature-me...@chromium.org, scheduler...@chromium.org, network-ser...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chrome-tab-group-en...@google.com, net-r...@chromium.org, mpdento...@chromium.org, glazuno...@chromium.org
Attention needed from David Sanders

Lei Zhang voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f0207b68dfe3c77d517e44e37b034169db85453
Gerrit-Change-Number: 6832689
Gerrit-PatchSet: 30
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: 王若宸 <jo198...@gmail.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Wed, 13 Aug 2025 17:56:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Aug 13, 2025, 3:46:30 PMAug 13
to David Sanders, Lei Zhang, Enterprise Policy Reviews, Mathias Bynens, Sean Maher, Thiabaud Engelbrecht, 王若宸, AyeAye, Chromium LUCI CQ, tbarzi...@chromium.org, rrsilva+wat...@google.com, mac-r...@chromium.org, odejesu...@chromium.org, mattreyno...@chromium.org, arc-review...@google.com, oshima...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, hashimo...@chromium.org, chrome-gr...@chromium.org, chromotin...@chromium.org, rouslan+au...@chromium.org, prerenderi...@chromium.org, tburkar...@chromium.org, gavin...@chromium.org, blink-revi...@chromium.org, hansberry+w...@chromium.org, crisrael+w...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, hais+wat...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, ajayramamurth...@google.com, performance-m...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, feature-me...@chromium.org, scheduler...@chromium.org, network-ser...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chrome-tab-group-en...@google.com, net-r...@chromium.org, mpdento...@chromium.org, glazuno...@chromium.org
Attention needed from David Sanders

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Wed, 13 Aug 2025 19:46:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 13, 2025, 5:03:27 PMAug 13
to David Sanders, Lei Zhang, Enterprise Policy Reviews, Mathias Bynens, Sean Maher, Thiabaud Engelbrecht, 王若宸, AyeAye, tbarzi...@chromium.org, rrsilva+wat...@google.com, mac-r...@chromium.org, odejesu...@chromium.org, mattreyno...@chromium.org, arc-review...@google.com, oshima...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, hashimo...@chromium.org, chrome-gr...@chromium.org, chromotin...@chromium.org, rouslan+au...@chromium.org, prerenderi...@chromium.org, tburkar...@chromium.org, gavin...@chromium.org, blink-revi...@chromium.org, hansberry+w...@chromium.org, crisrael+w...@google.com, suetfei+wa...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, hais+wat...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, dclasson+w...@google.com, ajayramamurth...@google.com, performance-m...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, feature-me...@chromium.org, scheduler...@chromium.org, network-ser...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chrome-tab-group-en...@google.com, net-r...@chromium.org, mpdento...@chromium.org, glazuno...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add some missing includes of //base/time/time.h

Prefer forward decls in headers where feasible.
Bug: 40216326
Change-Id: I1f0207b68dfe3c77d517e44e37b034169db85453
Reviewed-by: Lei Zhang <the...@chromium.org>
Owners-Override: Lei Zhang <the...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1501019}
Files:
  • M ash/api/tasks/fake_tasks_client.h
  • M ash/api/tasks/tasks_client.h
  • M base/debug/debugger.cc
  • M base/lazy_instance_helpers.cc
  • M base/task/common/operations_controller_unittest.cc
  • M base/threading/thread_collision_warner_unittest.cc
  • M chrome/browser/ash/login/signin/token_handle_fetcher.h
  • M chrome/browser/enterprise/platform_auth/extensible_enterprise_sso_provider_mac.h
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_external.h
  • M chrome/browser/ui/autofill/bubble_manager_impl.h
  • M chrome/test/chromedriver/chrome/scoped_temp_dir_with_retry.cc
  • M chromeos/ash/components/dbus/arc/arcvm_data_migrator_client.h
  • M chromeos/ash/experiences/arc/dlc_installer/arc_dlc_installer.h
  • M components/data_sharing/public/logger.h
  • M components/enterprise/connectors/core/reporting_utils.h
  • M components/gwp_asan/client/guarded_page_allocator_unittest.cc
  • M components/metrics/cloned_install_detector.h
  • M components/performance_manager/public/graph/frame_node.h
  • M components/policy/core/common/cloud/device_management_service.h
  • M components/signin/public/base/signin_prefs.h
  • M components/viz/service/performance_hint/hint_session.h
  • M content/browser/preloading/prerender/prerender_no_vary_search_commit_deferring_condition.h
  • M content/public/browser/cdm_storage_data_model.h
  • M mojo/public/cpp/system/tests/wait_set_unittest.cc
  • M net/http/no_vary_search_cache.h
  • M remoting/host/clipboard_win.cc
  • M services/device/usb/usb_context_unittest.cc
  • M services/network/public/cpp/fetch_retry_options.h
  • M third_party/blink/renderer/core/editing/markers/glic_marker.cc
  • M third_party/blink/renderer/core/frame/use_counter_impl.h
  • M third_party/blink/renderer/platform/blob/blob_data.h
  • M ui/native_theme/native_theme.h
Change size: M
Delta: 32 files changed, 66 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f0207b68dfe3c77d517e44e37b034169db85453
Gerrit-Change-Number: 6832689
Gerrit-PatchSet: 31
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages