Clean up unused dependencies around //chrome/browser/history [chromium/src : main]

0 views
Skip to first unread message

Keybo Qian (Gerrit)

unread,
Apr 24, 2026, 3:13:17 PM (13 hours ago) Apr 24
to chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
Attention needed from chromium-bedrock-reviews

Keybo Qian voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • chromium-bedrock-reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
Gerrit-Change-Number: 7791505
Gerrit-PatchSet: 3
Gerrit-Owner: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 19:13:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Apr 24, 2026, 3:15:36 PM (13 hours ago) Apr 24
to Keybo Qian, chromium-bedrock-reviews, Sophie Chang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
Attention needed from Sophie Chang

Message from gwsq

Reviewer source(s):
sophi...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Sophie Chang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
Gerrit-Change-Number: 7791505
Gerrit-PatchSet: 3
Gerrit-Owner: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Apr 2026 19:15:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sophie Chang (Gerrit)

unread,
Apr 24, 2026, 4:23:06 PM (11 hours ago) Apr 24
to Keybo Qian, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
Attention needed from Keybo Qian

Sophie Chang added 3 comments

File chrome/browser/browsing_data/counters/history_counter_browsertest.cc
Line 18, Patchset 3 (Latest):#include "chrome/browser/profiles/profile.h"
Sophie Chang . unresolved

alphabetize

File chrome/browser/history/web_history_service_factory.h
Line 9, Patchset 3 (Latest):class Profile;
Sophie Chang . unresolved

this is in the wrong place

File chrome/browser/history/web_history_service_factory.cc
Line 11, Patchset 3 (Latest):#include "chrome/browser/profiles/profile.h"
Sophie Chang . unresolved

alphabetize

Open in Gerrit

Related details

Attention is currently required from:
  • Keybo Qian
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
    Gerrit-Change-Number: 7791505
    Gerrit-PatchSet: 3
    Gerrit-Owner: Keybo Qian <ke...@google.com>
    Gerrit-Reviewer: Keybo Qian <ke...@google.com>
    Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
    Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
    Gerrit-CC: gwsq
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Keybo Qian <ke...@google.com>
    Gerrit-Comment-Date: Fri, 24 Apr 2026 20:22:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keybo Qian (Gerrit)

    unread,
    Apr 24, 2026, 5:26:42 PM (10 hours ago) Apr 24
    to chromium-bedrock-reviews, Sophie Chang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
    Attention needed from Sophie Chang

    Keybo Qian voted and added 4 comments

    Votes added by Keybo Qian

    Auto-Submit+1

    4 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Keybo Qian . resolved

    Thanks!

    File chrome/browser/browsing_data/counters/history_counter_browsertest.cc
    Line 18, Patchset 3:#include "chrome/browser/profiles/profile.h"
    Sophie Chang . resolved

    alphabetize

    Keybo Qian

    Done

    File chrome/browser/history/web_history_service_factory.h
    Line 9, Patchset 3:class Profile;
    Sophie Chang . resolved

    this is in the wrong place

    Keybo Qian

    Done

    File chrome/browser/history/web_history_service_factory.cc
    Line 11, Patchset 3:#include "chrome/browser/profiles/profile.h"
    Sophie Chang . resolved

    alphabetize

    Keybo Qian

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sophie Chang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
      Gerrit-Change-Number: 7791505
      Gerrit-PatchSet: 4
      Gerrit-Owner: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 24 Apr 2026 21:26:33 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Sophie Chang <sophi...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sophie Chang (Gerrit)

      unread,
      Apr 24, 2026, 5:29:01 PM (10 hours ago) Apr 24
      to Keybo Qian, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
      Attention needed from Keybo Qian

      Sophie Chang voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Keybo Qian
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
      Gerrit-Change-Number: 7791505
      Gerrit-PatchSet: 4
      Gerrit-Owner: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Keybo Qian <ke...@google.com>
      Gerrit-Comment-Date: Fri, 24 Apr 2026 21:28:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages