Clean up unused dependencies around //chrome/browser/history [chromium/src : main]

1 view
Skip to first unread message

Keybo Qian (Gerrit)

unread,
Apr 24, 2026, 3:13:17 PMApr 24
to chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
Attention needed from chromium-bedrock-reviews

Keybo Qian voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • chromium-bedrock-reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
Gerrit-Change-Number: 7791505
Gerrit-PatchSet: 3
Gerrit-Owner: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 19:13:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Apr 24, 2026, 3:15:36 PMApr 24
to Keybo Qian, chromium-bedrock-reviews, Sophie Chang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
Attention needed from Sophie Chang

Message from gwsq

Reviewer source(s):
sophi...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Sophie Chang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
Gerrit-Change-Number: 7791505
Gerrit-PatchSet: 3
Gerrit-Owner: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: Keybo Qian <ke...@google.com>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Apr 2026 19:15:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sophie Chang (Gerrit)

unread,
Apr 24, 2026, 4:23:06 PMApr 24
to Keybo Qian, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
Attention needed from Keybo Qian

Sophie Chang added 3 comments

File chrome/browser/browsing_data/counters/history_counter_browsertest.cc
Line 18, Patchset 3 (Latest):#include "chrome/browser/profiles/profile.h"
Sophie Chang . unresolved

alphabetize

File chrome/browser/history/web_history_service_factory.h
Line 9, Patchset 3 (Latest):class Profile;
Sophie Chang . unresolved

this is in the wrong place

File chrome/browser/history/web_history_service_factory.cc
Line 11, Patchset 3 (Latest):#include "chrome/browser/profiles/profile.h"
Sophie Chang . unresolved

alphabetize

Open in Gerrit

Related details

Attention is currently required from:
  • Keybo Qian
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
    Gerrit-Change-Number: 7791505
    Gerrit-PatchSet: 3
    Gerrit-Owner: Keybo Qian <ke...@google.com>
    Gerrit-Reviewer: Keybo Qian <ke...@google.com>
    Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
    Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
    Gerrit-CC: gwsq
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Keybo Qian <ke...@google.com>
    Gerrit-Comment-Date: Fri, 24 Apr 2026 20:22:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keybo Qian (Gerrit)

    unread,
    Apr 24, 2026, 5:26:42 PMApr 24
    to chromium-bedrock-reviews, Sophie Chang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
    Attention needed from Sophie Chang

    Keybo Qian voted and added 4 comments

    Votes added by Keybo Qian

    Auto-Submit+1

    4 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Keybo Qian . resolved

    Thanks!

    File chrome/browser/browsing_data/counters/history_counter_browsertest.cc
    Line 18, Patchset 3:#include "chrome/browser/profiles/profile.h"
    Sophie Chang . resolved

    alphabetize

    Keybo Qian

    Done

    File chrome/browser/history/web_history_service_factory.h
    Line 9, Patchset 3:class Profile;
    Sophie Chang . resolved

    this is in the wrong place

    Keybo Qian

    Done

    File chrome/browser/history/web_history_service_factory.cc
    Line 11, Patchset 3:#include "chrome/browser/profiles/profile.h"
    Sophie Chang . resolved

    alphabetize

    Keybo Qian

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sophie Chang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
      Gerrit-Change-Number: 7791505
      Gerrit-PatchSet: 4
      Gerrit-Owner: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 24 Apr 2026 21:26:33 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Sophie Chang <sophi...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sophie Chang (Gerrit)

      unread,
      Apr 24, 2026, 5:29:01 PMApr 24
      to Keybo Qian, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org
      Attention needed from Keybo Qian

      Sophie Chang voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Keybo Qian
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
      Gerrit-Change-Number: 7791505
      Gerrit-PatchSet: 4
      Gerrit-Owner: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Keybo Qian <ke...@google.com>
      Gerrit-Comment-Date: Fri, 24 Apr 2026 21:28:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Keybo Qian (Gerrit)

      unread,
      Apr 27, 2026, 10:05:23 AMApr 27
      to Sophie Chang, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org

      Keybo Qian voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
      Gerrit-Change-Number: 7791505
      Gerrit-PatchSet: 5
      Gerrit-Owner: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Comment-Date: Mon, 27 Apr 2026 14:05:10 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 27, 2026, 11:38:56 AMApr 27
      to Keybo Qian, Sophie Chang, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, prerendering-reviews, msrame...@chromium.org, dullweb...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavin...@chromium.org, mdjone...@chromium.org, tburkar...@chromium.org, yuezhang...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      4 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: chrome/browser/ui/webui/new_tab_page/action_chips/BUILD.gn
      Insertions: 64, Deletions: 61.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      Clean up unused dependencies around //chrome/browser/history

      This removes the dependencies of //c/b/history as well as references to
      //c/b/history in other components.
      Cq-Include-Trybots: luci.chromium.try:android-cast-arm-rel
      Bug: 505818265
      Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
      Reviewed-by: Sophie Chang <sophi...@chromium.org>
      Auto-Submit: Keybo Qian <ke...@google.com>
      Commit-Queue: Keybo Qian <ke...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1621113}
      Files:
      • M chrome/browser/browsing_data/counters/history_counter_browsertest.cc
      • M chrome/browser/extensions/BUILD.gn
      • M chrome/browser/history/chrome_history_backend_client.cc
      • M chrome/browser/history/chrome_history_client.cc
      • M chrome/browser/history/domain_diversity_reporter_factory.cc
      • M chrome/browser/history/history_service_factory.cc
      • M chrome/browser/history/history_tab_helper.cc
      • M chrome/browser/history/top_sites_factory.cc
      • M chrome/browser/history/web_history_service_factory.cc
      • M chrome/browser/history/web_history_service_factory.h
      • M chrome/browser/preloading/prefetch/BUILD.gn
      • M chrome/browser/resource_coordinator/BUILD.gn
      • M chrome/browser/ui/sync/BUILD.gn
      • M chrome/browser/ui/webui/commerce/BUILD.gn
      • M chrome/browser/ui/webui/new_tab_page/action_chips/BUILD.gn
      Change size: S
      Delta: 15 files changed, 4 insertions(+), 23 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Sophie Chang
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia1d65151aea6d51fbc27e9e85dec00fb0ef50b21
      Gerrit-Change-Number: 7791505
      Gerrit-PatchSet: 6
      Gerrit-Owner: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Keybo Qian <ke...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages