Commit-Queue | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Commit-Queue | +1 |
Dana ptal c/b/ui
Francois ptal c/b/resource_coordinator
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
This change meets the code coverage requirements.
Code-Coverage | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Code-Review | +1 |
Tentative LGTM. The controller system here is very complex so I'm hoping nothing breaks, but I'm sure we'll get bug reports if something does.
Certainly nothing looks too out of the ordinary.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Commit-Queue | +2 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
This change meets the code coverage requirements.
Code-Coverage | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Update hover cards to support retained WebContents discard impl
This CL updates the ThumbnailReadinessTracker to reset its status to
kNotReady after a discard.
In the current impl this is a no-op as the tracker is re-created with
kNotReady as the default when the null WebContents is created. This
change ensures the tracker is reset to a similar state in the new
impl which does not re-create the tab helper after discard.
The ThumbnailTabHelper has also been updated to avoid clearing data
for discarded tabs and attempting a reload when starting a new
thumbnail observation (a new observation is started when the user
hovers over a tab and cleared when unhovered).
Both changes are logically appropriate and there is no impact on the
current implementation. This allows side-by-side support of the
current and new discard impls.
TabLifecycleUnit is updated to explicitly notify TabStripModel::
UpdateWebContentsStateAt(), ensuring downstream code responds
appropriately to discard status changes and that this is reflected
in updated TabRenderData.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |