Remove histograms TabManager.Discarding.{Discard|Inactive}ToReloadTime.Proactive [chromium/src : main]

7 views
Skip to first unread message

Vovo Yang (Gerrit)

unread,
Oct 28, 2025, 3:35:14 AM (9 days ago) Oct 28
to Anthony Vallée-Dubois, Tom Lukaszewicz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Attention needed from Joe Mason

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9b32712536f53060f11122547ee4e3f0f719efe0
Gerrit-Change-Number: 7089951
Gerrit-PatchSet: 4
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-CC: Anthony Vallée-Dubois <anth...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Tue, 28 Oct 2025 07:34:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anthony Vallée-Dubois (Gerrit)

unread,
Oct 28, 2025, 11:27:00 AM (8 days ago) Oct 28
to Vovo Yang, Tom Lukaszewicz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Attention needed from Joe Mason and Vovo Yang

Anthony Vallée-Dubois voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
  • Vovo Yang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b32712536f53060f11122547ee4e3f0f719efe0
    Gerrit-Change-Number: 7089951
    Gerrit-PatchSet: 4
    Gerrit-Owner: Vovo Yang <vo...@chromium.org>
    Gerrit-Reviewer: Anthony Vallée-Dubois <anth...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Vovo Yang <vo...@chromium.org>
    Gerrit-Attention: Joe Mason <joenot...@google.com>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 15:26:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joe Mason (Gerrit)

    unread,
    Oct 28, 2025, 3:58:16 PM (8 days ago) Oct 28
    to Vovo Yang, Anthony Vallée-Dubois, Tom Lukaszewicz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
    Attention needed from Vovo Yang

    Joe Mason voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vovo Yang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b32712536f53060f11122547ee4e3f0f719efe0
    Gerrit-Change-Number: 7089951
    Gerrit-PatchSet: 4
    Gerrit-Owner: Vovo Yang <vo...@chromium.org>
    Gerrit-Reviewer: Anthony Vallée-Dubois <anth...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Vovo Yang <vo...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 19:58:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Vovo Yang (Gerrit)

    unread,
    Oct 28, 2025, 7:05:28 PM (8 days ago) Oct 28
    to Anthony Vallée-Dubois, Tom Lukaszewicz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org

    Vovo Yang voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b32712536f53060f11122547ee4e3f0f719efe0
    Gerrit-Change-Number: 7089951
    Gerrit-PatchSet: 4
    Gerrit-Owner: Vovo Yang <vo...@chromium.org>
    Gerrit-Reviewer: Anthony Vallée-Dubois <anth...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 23:04:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 28, 2025, 7:08:22 PM (8 days ago) Oct 28
    to Vovo Yang, Anthony Vallée-Dubois, Tom Lukaszewicz, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove histograms TabManager.Discarding.{Discard|Inactive}ToReloadTime.Proactive

    These histograms are expired. Removing these histograms would make
    removing TabLifecycleUnit easier.
    Bug: 330166297, 333390741, 394889323
    Change-Id: I9b32712536f53060f11122547ee4e3f0f719efe0
    Commit-Queue: Vovo Yang <vo...@chromium.org>
    Reviewed-by: Anthony Vallée-Dubois <anth...@chromium.org>
    Reviewed-by: Joe Mason <joenot...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1536972}
    Files:
    • M chrome/browser/resource_coordinator/discard_metrics_lifecycle_unit_observer.cc
    • M chrome/browser/resource_coordinator/discard_metrics_lifecycle_unit_observer_unittest.cc
    • M tools/metrics/histograms/metadata/tab/histograms.xml
    Change size: M
    Delta: 3 files changed, 0 insertions(+), 82 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joe Mason, +1 by Anthony Vallée-Dubois
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b32712536f53060f11122547ee4e3f0f719efe0
    Gerrit-Change-Number: 7089951
    Gerrit-PatchSet: 5
    Gerrit-Owner: Vovo Yang <vo...@chromium.org>
    Gerrit-Reviewer: Anthony Vallée-Dubois <anth...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages