Victor Vianna (Gerrit)

unread,

Nov 11, 2025, 12:03:25 PMNov 11

to Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Sophie Chang, Sean Maher, Thiabaud Engelbrecht, Tommy Li, abigailbk...@google.com, ajayramamurth...@google.com, ajayramamurth...@google.com, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+w...@google.com, chadduffin+w...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rhalava...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Lei Zhang

Victor Vianna voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Nov 11, 2025, 7:51:20 PMNov 11

to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Sophie Chang, Sean Maher, Thiabaud Engelbrecht, Tommy Li, abigailbk...@google.com, ajayramamurth...@google.com, ajayramamurth...@google.com, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+w...@google.com, chadduffin+w...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rhalava...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 11, 2025, 7:59:19 PMNov 11

to Lei Zhang, Daniel Cheng, Victor Vianna, Akihiro Ota, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Sophie Chang, Sean Maher, Thiabaud Engelbrecht, Tommy Li, abigailbk...@google.com, ajayramamurth...@google.com, ajayramamurth...@google.com, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+w...@google.com, chadduffin+w...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rhalava...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove superfluous callback.h includes from //chrome headers

Remove unused includes mostly found by heuristics in headers that do not
contain keywords like "Callback" or "Closure".

Bug: 40318405

Change-Id: I4cc8a9cb5a3aaf3b8d149360eb4ebd5cb002f92a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7139543

Reviewed-by: Victor Vianna <victor...@google.com>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1543439}

Files:

M chrome/browser/ash/account_manager/account_manager_edu_coexistence_controller.h
M chrome/browser/ash/arc/input_method_manager/arc_input_method_state.h
M chrome/browser/ash/exo/chrome_data_exchange_delegate.h
M chrome/browser/ash/file_manager/io_task_controller.h
M chrome/browser/ash/file_system_provider/operation_request_manager.h
M chrome/browser/ash/growth/ui_action_performer.h
M chrome/browser/ash/input_method/text_field_contextual_info_fetcher.h
M chrome/browser/ash/login/demo_mode/demo_mode_idle_handler.h
M chrome/browser/ash/login/enrollment/timebound_user_context_holder.h
M chrome/browser/ash/login/smart_lock/smart_lock_auth_attempt.h
M chrome/browser/ash/login/smart_lock/smart_lock_notification_controller.h
M chrome/browser/ash/plugin_vm/plugin_vm_features.h
M chrome/browser/ash/printing/enterprise/print_servers_provider.h
M chrome/browser/ash/remote_apps/remote_apps_model.h
M chrome/browser/ash/wallpaper_handlers/mock_sea_pen_fetcher.h
M chrome/browser/component_updater/afp_blocked_domain_list_component_installer.h
M chrome/browser/component_updater/iwa_key_distribution_component_installer.h
M chrome/browser/contextual_tasks/contextual_tasks_ui_service.h
M chrome/browser/devtools/device/adb/mock_adb_server.h
M chrome/browser/download/android/download_controller_base.h
M chrome/browser/download/android/mock_download_controller.h
M chrome/browser/extensions/api/image_writer_private/zip_extractor.h
M chrome/browser/extensions/api/settings_private/settings_private_delegate.h
M chrome/browser/extensions/theme_installed_infobar_delegate.h
M chrome/browser/glic/host/context/glic_share_image_handler.h
M chrome/browser/media/router/providers/wired_display/wired_display_presentation_receiver.h
M chrome/browser/media_galleries/mtp_read_file_worker.h
M chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h
M chrome/browser/nearby_sharing/bluetooth_advertising_interval_client.h
M chrome/browser/nearby_sharing/contacts/nearby_share_contact_manager.h
M chrome/browser/nearby_sharing/contacts/nearby_share_contact_manager_impl.h
M chrome/browser/nearby_sharing/instantmessaging/stream_parser.h
M chrome/browser/new_tab_page/chrome_colors/chrome_colors_service.h
M chrome/browser/notifications/notification_display_queue.h
M chrome/browser/notifications/scheduler/internal/display_decider.h
M chrome/browser/password_manager/android/grouped_affiliations/acknowledge_grouped_credential_sheet_controller_test_helper.h
M chrome/browser/picture_in_picture/scoped_picture_in_picture_occlusion_observation.h
M chrome/browser/policy/messaging_layer/util/upload_response_parser.h
M chrome/browser/preloading/preview/preview_test_util.h
M chrome/browser/resource_coordinator/tab_load_tracker.h
M chrome/browser/screen_ai/screen_ai_install_state.h
M chrome/browser/ssl/chrome_security_state_tab_helper.h
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h
M chrome/browser/sync_file_system/local/syncable_file_operation_runner.h
M chrome/browser/ui/android/fast_checkout/fast_checkout_view_impl.h
M chrome/browser/ui/android/webid/account_selection_view_android.h
M chrome/browser/ui/ash/network/tether_notification_presenter.h
M chrome/browser/ui/autofill/autofill_suggestion_controller_test_base.h
M chrome/browser/ui/interventions/intervention_infobar_delegate.h
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
M chrome/browser/ui/plus_addresses/android/all_plus_addresses_bottom_sheet_view.h
M chrome/browser/ui/screen_capture_notification_ui.h
M chrome/browser/ui/sharing_hub/fake_sharing_hub_bubble_controller.h
M chrome/browser/ui/tab_modal_confirm_dialog_delegate.h
M chrome/browser/ui/views/frame/browser_frame_header_chromeos.h
M chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h
M chrome/browser/ui/views/safe_browsing/tailored_security_unconsented_modal.h
M chrome/browser/ui/views/toolbar/toolbar_action_view.h
M chrome/browser/ui/views/webid/account_selection_bubble_view.h
M chrome/browser/ui/webui/nearby_internals/quick_pair/quick_pair_handler.h
M chrome/browser/ui/webui/signin/managed_user_profile_notice_ui.h
M chrome/browser/ui/webui/top_chrome/preload_candidate_selector.h
M chrome/browser/unexpire_flags.h
M chrome/browser/vr/elements/transient_element.h
M chrome/browser/vr/elements/ui_element.h
M chrome/browser/vr/test/ui_utils.h
M chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration.h
M chrome/common/profiler/native_unwinder_android_map_delegate_impl.h
M chrome/renderer/net/net_error_helper.h
M chrome/renderer/net/net_error_helper_core.h
M chrome/renderer/supervised_user/supervised_user_error_page_controller.h
M chrome/test/accessibility/ax_client/ax_client_uia.h
M chrome/test/chromedriver/chrome/web_view_impl.h
M chrome/updater/win/task_scheduler.h
M chrome/utility/safe_browsing/rar_analyzer.h
M chrome/utility/safe_browsing/seven_zip_analyzer.h
M chrome/utility/safe_browsing/zip_analyzer.h

Change size: M

Delta: 77 files changed, 0 insertions(+), 79 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Victor Vianna

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Yuki Shiino (Gerrit)

unread,

Nov 12, 2025, 3:15:57 AMNov 12

to Lei Zhang, Chromium LUCI CQ, Daniel Cheng, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Sophie Chang, Sean Maher, Thiabaud Engelbrecht, Tommy Li, abigailbk...@google.com, ajayramamurth...@google.com, ajayramamurth...@google.com, arc-review...@google.com, asumane...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+w...@google.com, chadduffin+w...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rhalava...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org, Yuki Shiino

Yuki Shiino has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Remove superfluous callback.h includes from //chrome headers [chromium/src : main]

Victor Vianna (Gerrit)

Victor Vianna voted Code-Review+1

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Yuki Shiino (Gerrit)

Yuki Shiino has created a revert of this change

Related details