Migrate base::Contains() to std::ranges::contains() in chrome [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Jan 13, 2026, 1:19:26 AM (5 days ago) Jan 13
to Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
Attention needed from Marc Treib

Victor Vianna voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Marc Treib
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1ba8de383e4a99287dac00e6c4533c0f087d2143
Gerrit-Change-Number: 7459685
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Marc Treib <tr...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 06:19:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Marc Treib (Gerrit)

unread,
Jan 13, 2026, 6:24:12 AM (5 days ago) Jan 13
to Victor Vianna, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
Attention needed from Victor Vianna

Marc Treib voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ba8de383e4a99287dac00e6c4533c0f087d2143
    Gerrit-Change-Number: 7459685
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 11:23:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 10:59:39 AM (5 days ago) Jan 13
    to Elie Maamari, Tim, Elly FJ, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
    Attention needed from Elie Maamari, Elly FJ and Tim

    Victor Vianna added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Victor Vianna . resolved

    +emaamari@ for c/b/ui/ash/login
    +tjudkins@ for c/b/ui/extensions/extensions_overrides
    +ellyjones@ for chrome/browser/printing/web_api/web_printing_type_converters*

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Elie Maamari
    • Elly FJ
    • Tim
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ba8de383e4a99287dac00e6c4533c0f087d2143
    Gerrit-Change-Number: 7459685
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Elie Maamari <emaa...@google.com>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Tim <tjud...@chromium.org>
    Gerrit-Attention: Elly FJ <elly...@chromium.org>
    Gerrit-Attention: Elie Maamari <emaa...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 15:59:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Elly FJ (Gerrit)

    unread,
    Jan 13, 2026, 1:04:20 PM (4 days ago) Jan 13
    to Victor Vianna, Elly FJ, Elie Maamari, Tim, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
    Attention needed from Elie Maamari, Tim and Victor Vianna

    Elly FJ voted and added 1 comment

    Votes added by Elly FJ

    Code-Review+1

    1 comment

    Patchset-level comments
    Elly FJ . resolved

    lgtm!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Elie Maamari
    • Tim
    • Victor Vianna
    Gerrit-Attention: Elie Maamari <emaa...@google.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 18:04:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tim (Gerrit)

    unread,
    Jan 13, 2026, 2:51:13 PM (4 days ago) Jan 13
    to Victor Vianna, Elly FJ, Elie Maamari, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
    Attention needed from Elie Maamari and Victor Vianna

    Tim voted and added 1 comment

    Votes added by Tim

    Code-Review+1

    1 comment

    Patchset-level comments
    Tim . resolved

    chrome/browser/ui/extensions/extensions_overrides/ LGTM! Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Elie Maamari
    • Victor Vianna
    Gerrit-Attention: Elie Maamari <emaa...@google.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:50:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 2:51:44 PM (4 days ago) Jan 13
    to Tim, Elly FJ, Elie Maamari, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
    Attention needed from Elie Maamari

    Victor Vianna voted Auto-Submit+1

    Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Elie Maamari
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:51:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 7:22:07 PM (4 days ago) Jan 13
    to Hidehiko Abe, Tim, Elly FJ, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
    Attention needed from Hidehiko Abe

    Victor Vianna voted and added 1 comment

    Votes added by Victor Vianna

    Commit-Queue+1

    1 comment

    Patchset-level comments
    Victor Vianna . resolved

    +hidehiko@ for chrome/browser/ui/ash/login/login_display_host_common.cc

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ba8de383e4a99287dac00e6c4533c0f087d2143
    Gerrit-Change-Number: 7459685
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 00:21:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    Jan 14, 2026, 12:14:12 AM (4 days ago) Jan 14
    to Victor Vianna, Tim, Elly FJ, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org
    Attention needed from Victor Vianna

    Hidehiko Abe voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Victor Vianna
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ba8de383e4a99287dac00e6c4533c0f087d2143
    Gerrit-Change-Number: 7459685
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 05:13:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 14, 2026, 12:22:32 AM (4 days ago) Jan 14
    to Victor Vianna, Hidehiko Abe, Tim, Elly FJ, Marc Treib, Andrew Rayskiy, Simon Hangl, Sophie Chang, Avi Drissman, AyeAye, feature-me...@chromium.org, extension...@chromium.org, creis...@chromium.org, msrame...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, mac-r...@chromium.org, prerenderi...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org, steimel+...@chromium.org, permissio...@chromium.org, print-rev...@chromium.org, translat...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, ajwong...@chromium.org, tburkar...@chromium.org, chrome-gr...@chromium.org, lingqi...@chromium.org, tbarzi...@chromium.org, yuezhang...@chromium.org, mdjone...@chromium.org, cros-print...@google.com, rmcelra...@chromium.org, rrsilva+wat...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, tote-eng...@google.com, xinghui...@chromium.org, gavin...@chromium.org, mfoltz+wa...@chromium.org, druber...@chromium.org, rginda...@chromium.org, gcasto+w...@chromium.org, ayman...@chromium.org, cc-...@chromium.org, jdonnel...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Migrate base::Contains() to std::ranges::contains() in chrome

    base::Contains() is an alias to std::ranges::contains() since
    crrev.com/c/7415207, so this CL has no behavior change.
    Bug: 470391351
    Change-Id: I1ba8de383e4a99287dac00e6c4533c0f087d2143
    Reviewed-by: Marc Treib <tr...@chromium.org>
    Reviewed-by: Tim <tjud...@chromium.org>
    Commit-Queue: Hidehiko Abe <hide...@chromium.org>
    Reviewed-by: Hidehiko Abe <hide...@chromium.org>
    Reviewed-by: Elly FJ <elly...@chromium.org>
    Auto-Submit: Victor Vianna <victor...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1568900}
    Files:
    • M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
    • M chrome/browser/prefs/profile_pref_store_manager_unittest.cc
    • M chrome/browser/preloading/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc
    • M chrome/browser/preloading/prefetch/search_prefetch/search_preload_unified_browsertest.cc
    • M chrome/browser/printing/print_preview_dialog_controller.cc
    • M chrome/browser/printing/pwg_raster_converter.cc
    • M chrome/browser/printing/web_api/web_printing_service_chromeos.cc
    • M chrome/browser/printing/web_api/web_printing_type_converters.cc
    • M chrome/browser/process_singleton_posix_unittest.cc
    • M chrome/browser/profiles/batch_upload/batch_upload_service.cc
    • M chrome/browser/profiles/host_zoom_map_browsertest.cc
    • M chrome/browser/profiles/profile_browsertest.cc
    • M chrome/browser/profiles/profile_manager.cc
    • M chrome/browser/profiles/profile_shortcut_manager_win.cc
    • M chrome/browser/promos/promos_utils.cc
    • M chrome/browser/resource_coordinator/test_lifecycle_unit.cc
    • M chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
    • M chrome/browser/safe_browsing/chrome_password_protection_service.cc
    • M chrome/browser/safe_browsing/download_protection/deep_scanning_request_unittest.cc
    • M chrome/browser/safe_browsing/extension_telemetry/potential_password_theft_signal_processor.cc
    • M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc
    • M chrome/browser/safe_browsing/test_safe_browsing_database_helper.cc
    • M chrome/browser/shortcuts/shortcut_creator_mac.mm
    • M chrome/browser/signin/android/signin_manager_android_unittest.cc
    • M chrome/browser/signin/dice_intercepted_session_startup_helper.cc
    • M chrome/browser/speech/on_device_speech_recognition_impl.cc
    • M chrome/browser/spellchecker/spellcheck_language_policy_handlers_unittest.cc
    • M chrome/browser/spellchecker/spellcheck_service.cc
    • M chrome/browser/spellchecker/spellcheck_service_unittest.cc
    • M chrome/browser/ssl/ssl_browsertest.cc
    • M chrome/browser/ssl/typed_navigation_upgrade_throttle_interactive_uitest.cc
    • M chrome/browser/supervised_user/supervised_user_extensions_manager.cc
    • M chrome/browser/supervised_user/supervised_user_navigation_observer.cc
    • M chrome/browser/support_tool/ash/system_state_data_collector.cc
    • M chrome/browser/sync/sessions/browser_list_router_helper_unittest.cc
    • M chrome/browser/tab/tab_state_storage_updater_builder.cc
    • M chrome/browser/task_manager/mock_web_contents_task_manager.cc
    • M chrome/browser/task_manager/providers/fallback_task_provider.cc
    • M chrome/browser/task_manager/providers/fallback_task_provider_unittest.cc
    • M chrome/browser/themes/browser_theme_pack.cc
    • M chrome/browser/thumbnail/cc/thumbnail_cache.cc
    • M chrome/browser/translate/translate_manager_render_view_host_unittest.cc
    • M chrome/browser/ui/accelerator_table.cc
    • M chrome/browser/ui/accelerator_table_unittest.cc
    • M chrome/browser/ui/android/extensions/extension_keybinding_registry_android.cc
    • M chrome/browser/ui/ash/app_access/app_access_notifier.cc
    • M chrome/browser/ui/ash/birch/birch_test_util.cc
    • M chrome/browser/ui/ash/desks/desks_client_browsertest.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_downloads_delegate.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_file_system_delegate.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_persistence_delegate.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_suggestions_delegate.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_util.cc
    • M chrome/browser/ui/ash/login/login_display_host_common.cc
    • M chrome/browser/ui/ash/shelf/app_shortcut_shelf_item_controller.cc
    • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_util.cc
    • M chrome/browser/ui/ash/shelf/chrome_shelf_prefs.cc
    • M chrome/browser/ui/ash/shelf/chrome_shelf_prefs_unittest.cc
    • M chrome/browser/ui/ash/wallpaper/wallpaper_controller_client_impl_unittest.cc
    • M chrome/browser/ui/browser_command_controller.cc
    • M chrome/browser/ui/browser_command_controller_browsertest.cc
    • M chrome/browser/ui/browser_list.cc
    • M chrome/browser/ui/browser_list_enumerator.cc
    • M chrome/browser/ui/browser_window/internal/android/android_browser_window_enumerator.cc
    • M chrome/browser/ui/commerce/product_specifications_entry_point_controller.cc
    • M chrome/browser/ui/commerce/product_specifications_page_action_controller.cc
    • M chrome/browser/ui/content_settings/framebust_block_browsertest.cc
    • M chrome/browser/ui/extensions/extensions_overrides/simple_overrides_unittest.cc
    • M chrome/browser/ui/global_media_controls/cast_media_notification_producer.cc
    • M chrome/browser/ui/hats/hats_service_desktop.cc
    • M chrome/browser/ui/hid/hid_chooser_controller.cc
    • M chrome/browser/ui/media_router/media_router_ui.cc
    • M chrome/browser/ui/media_router/media_router_ui_unittest.cc
    • M chrome/browser/ui/media_router/query_result_manager.cc
    • M chrome/browser/ui/media_router/query_result_manager_unittest.cc
    • M chrome/browser/ui/page_info/page_info_unittest.cc
    • M chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc
    • M chrome/browser/ui/performance_controls/performance_intervention_button_controller.cc
    • M chrome/browser/ui/safety_hub/revoked_permissions_result_unittest.cc
    • M chrome/browser/ui/safety_hub/revoked_permissions_service_browsertest.cc
    • M chrome/browser/ui/safety_hub/revoked_permissions_service_unittest.cc
    • M chrome/browser/ui/search_engines/template_url_table_model.cc
    • M chrome/browser/ui/serial/serial_chooser_controller.cc
    • M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
    • M chrome/browser/ui/tab_contents/chrome_web_contents_view_handle_drop.cc
    • M chrome/browser/ui/tabs/organization/tab_organization.cc
    • M chrome/browser/ui/toolbar/cast/cast_contextual_menu_browsertest.cc
    • M chrome/browser/ui/toolbar/chrome_labs/chrome_labs_utils.cc
    • M chrome/browser/ui/toolbar/toolbar_actions_model.cc
    • M chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
    • M chrome/browser/ui/views/apps/app_dialog/app_local_block_dialog_view.cc
    • M chrome/browser/ui/views/autofill/popup/popup_view_views_unittest.cc
    • M chrome/browser/ui/views/contextual_tasks/contextual_tasks_ephemeral_button_controller.cc
    • M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc
    • M chrome/browser/ui/views/media_router/cast_browser_controller.cc
    • M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
    • M chrome/browser/ui/views/overlay/video_overlay_window_views_unittest.cc
    • M chrome/browser/ui/views/page_action/page_action_icon_controller.cc
    • M chrome/browser/ui/views/permissions/permission_prompt_base_view_browsertest.cc
    • M chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view.cc
    Change size: L
    Delta: 100 files changed, 318 insertions(+), 302 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Elly FJ, +1 by Hidehiko Abe, +1 by Tim, +1 by Marc Treib
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ba8de383e4a99287dac00e6c4533c0f087d2143
    Gerrit-Change-Number: 7459685
    Gerrit-PatchSet: 3
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages