[bedrock] FindBrowserWithActiveWindow() function call point refactoring [chromium/src : main]

2 views
Skip to first unread message

Qikai Zhong (Gerrit)

unread,
Mar 23, 2026, 1:38:05 AM (13 days ago) Mar 23
to Yu He, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
Attention needed from Yu He

Qikai Zhong added 1 comment

File chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate.cc
Line 119, Patchset 5 (Latest): browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);
Qikai Zhong . unresolved

nit: NavigateToUrl?

Open in Gerrit

Related details

Attention is currently required from:
  • Yu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
Gerrit-Change-Number: 7672837
Gerrit-PatchSet: 5
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Yu He <y...@microsoft.com>
Gerrit-Comment-Date: Mon, 23 Mar 2026 05:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yu He (Gerrit)

unread,
Mar 23, 2026, 3:58:37 AM (13 days ago) Mar 23
to Qikai Zhong, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
Attention needed from Qikai Zhong and Tom Lukaszewicz

Yu He added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Yu He . resolved

This CL is ready, please help to review, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
Gerrit-Change-Number: 7672837
Gerrit-PatchSet: 7
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Kun Wang <kun...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 07:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yu He (Gerrit)

unread,
Mar 23, 2026, 3:58:58 AM (13 days ago) Mar 23
to Qikai Zhong, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
Attention needed from Qikai Zhong and Tom Lukaszewicz

Yu He added 1 comment

File chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate.cc
Line 119, Patchset 5: browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);
Qikai Zhong . resolved

nit: NavigateToUrl?

Yu He

fixed

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Tom Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
    Gerrit-Change-Number: 7672837
    Gerrit-PatchSet: 7
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
    Gerrit-CC: Kun Wang <kun...@microsoft.com>
    Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Mon, 23 Mar 2026 07:58:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Qikai Zhong (Gerrit)

    unread,
    Mar 23, 2026, 4:02:30 AM (13 days ago) Mar 23
    to Yu He, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
    Attention needed from Tom Lukaszewicz and Yu He

    Qikai Zhong added 1 comment

    File chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate.cc
    Line 138, Patchset 7 (Latest): browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);
    Qikai Zhong . unresolved
    Maybe
    ```
      content::OpenURLParams params(url, content::Referrer(),
                                    WindowOpenDisposition::NEW_FOREGROUND_TAB,
                                    ui::PAGE_TRANSITION_LINK, false);
      browser->GetBrowserForMigrationOnly->OpenURL(params, /*navigation_handle_callback=*/{});
    ```

    `browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);` do not look like inconsistent with
    ```
      content::OpenURLParams params(url, content::Referrer(),
                                    WindowOpenDisposition::NEW_FOREGROUND_TAB,
                                    ui::PAGE_TRANSITION_LINK, false);
      browser->OpenURL(params, /*navigation_handle_callback=*/{});
    ```
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Lukaszewicz
    • Yu He
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
      Gerrit-Change-Number: 7672837
      Gerrit-PatchSet: 7
      Gerrit-Owner: Yu He <y...@microsoft.com>
      Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
      Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
      Gerrit-Reviewer: Yu He <y...@microsoft.com>
      Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
      Gerrit-CC: Kun Wang <kun...@microsoft.com>
      Gerrit-Attention: Yu He <y...@microsoft.com>
      Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
      Gerrit-Comment-Date: Mon, 23 Mar 2026 08:02:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Yu He (Gerrit)

      unread,
      Mar 23, 2026, 4:12:40 AM (13 days ago) Mar 23
      to Qikai Zhong, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
      Attention needed from Qikai Zhong and Tom Lukaszewicz

      Yu He added 1 comment

      File chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate.cc
      Line 138, Patchset 7 (Latest): browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);
      Qikai Zhong . resolved
      Maybe
      ```
        content::OpenURLParams params(url, content::Referrer(),
                                      WindowOpenDisposition::NEW_FOREGROUND_TAB,
                                      ui::PAGE_TRANSITION_LINK, false);
        browser->GetBrowserForMigrationOnly->OpenURL(params, /*navigation_handle_callback=*/{});
      ```

      `browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);` do not look like inconsistent with
      ```
        content::OpenURLParams params(url, content::Referrer(),
                                      WindowOpenDisposition::NEW_FOREGROUND_TAB,
                                      ui::PAGE_TRANSITION_LINK, false);
        browser->OpenURL(params, /*navigation_handle_callback=*/{});
      ```
      Yu He

      I think the same.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Qikai Zhong
      • Tom Lukaszewicz
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
        Gerrit-Change-Number: 7672837
        Gerrit-PatchSet: 7
        Gerrit-Owner: Yu He <y...@microsoft.com>
        Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
        Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
        Gerrit-Reviewer: Yu He <y...@microsoft.com>
        Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
        Gerrit-CC: Kun Wang <kun...@microsoft.com>
        Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
        Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
        Gerrit-Comment-Date: Mon, 23 Mar 2026 08:12:31 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Tom Lukaszewicz (Gerrit)

        unread,
        Mar 23, 2026, 5:32:19 PM (12 days ago) Mar 23
        to Yu He, Hidehiko Abe, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
        Attention needed from Hidehiko Abe, Qikai Zhong and Yu He

        Tom Lukaszewicz voted and added 3 comments

        Votes added by Tom Lukaszewicz

        Code-Review+1

        3 comments

        Patchset-level comments
        Tom Lukaszewicz . resolved

        lgtm - Hidehiko could you ptal

        Commit Message
        Line 13, Patchset 7 (Latest):Change the return type of FindBrowserWithActiveWindow() from Browser* to
        BrowserWindowInterface* at each call site. Replace Browser-specific
        member access patterns with their BrowserWindowInterface equivalents:
        browser->tab_strip_model() → browser->GetTabStripModel()
        browser->profile() → browser->GetProfile() browser->is_type_normal() →
        browser->GetType() == BrowserWindowInterface::TYPE_NORMAL
        NavigateToUrl(browser, url) → browser->OpenGURL(url, disposition) Update
        #include directives accordingly, adding browser_window_interface.h and
        removing unnecessary includes like browser_list.h / browser_window.h
        where applicable. Add //chrome/browser/ui/browser_window dependency to
        BUILD.gn for the new_window target. This is part of the ongoing Bedrock
        effort to decouple components from the concrete Browser type and program
        against the BrowserWindowInterface abstraction, improving modularity and
        testability.
        Tom Lukaszewicz . unresolved

        nit: Thanks for justifying the comment to gerrit's column requirement!

        Could we add some additional formatting / newlines to make the description easier to read (helps with git blames down the road)

        File chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate.cc
        Line 138, Patchset 7 (Latest): browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);
        Qikai Zhong . resolved
        Maybe
        ```
          content::OpenURLParams params(url, content::Referrer(),
                                        WindowOpenDisposition::NEW_FOREGROUND_TAB,
                                        ui::PAGE_TRANSITION_LINK, false);
          browser->GetBrowserForMigrationOnly->OpenURL(params, /*navigation_handle_callback=*/{});
        ```

        `browser->OpenGURL(url, WindowOpenDisposition::NEW_FOREGROUND_TAB);` do not look like inconsistent with
        ```
          content::OpenURLParams params(url, content::Referrer(),
                                        WindowOpenDisposition::NEW_FOREGROUND_TAB,
                                        ui::PAGE_TRANSITION_LINK, false);
          browser->OpenURL(params, /*navigation_handle_callback=*/{});
        ```
        Yu He

        I think the same.

        Tom Lukaszewicz

        Took a look and BrowserWindowInterface::OpenGURL does seem like a match for the params as constructed here so checks out by me.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hidehiko Abe
        • Qikai Zhong
        • Yu He
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
          Gerrit-Change-Number: 7672837
          Gerrit-PatchSet: 7
          Gerrit-Owner: Yu He <y...@microsoft.com>
          Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
          Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
          Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
          Gerrit-Reviewer: Yu He <y...@microsoft.com>
          Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
          Gerrit-CC: Kun Wang <kun...@microsoft.com>
          Gerrit-Attention: Yu He <y...@microsoft.com>
          Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
          Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
          Gerrit-Comment-Date: Mon, 23 Mar 2026 21:32:02 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Yu He <y...@microsoft.com>
          Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Yu He (Gerrit)

          unread,
          Mar 23, 2026, 9:34:26 PM (12 days ago) Mar 23
          to Hidehiko Abe, Tom Lukaszewicz, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
          Attention needed from Hidehiko Abe and Qikai Zhong

          Yu He voted and added 1 comment

          Votes added by Yu He

          Auto-Submit+1

          1 comment

          Commit Message
          Line 13, Patchset 7:Change the return type of FindBrowserWithActiveWindow() from Browser* to

          BrowserWindowInterface* at each call site. Replace Browser-specific
          member access patterns with their BrowserWindowInterface equivalents:
          browser->tab_strip_model() → browser->GetTabStripModel()
          browser->profile() → browser->GetProfile() browser->is_type_normal() →
          browser->GetType() == BrowserWindowInterface::TYPE_NORMAL
          NavigateToUrl(browser, url) → browser->OpenGURL(url, disposition) Update
          #include directives accordingly, adding browser_window_interface.h and
          removing unnecessary includes like browser_list.h / browser_window.h
          where applicable. Add //chrome/browser/ui/browser_window dependency to
          BUILD.gn for the new_window target. This is part of the ongoing Bedrock
          effort to decouple components from the concrete Browser type and program
          against the BrowserWindowInterface abstraction, improving modularity and
          testability.
          Tom Lukaszewicz . resolved

          nit: Thanks for justifying the comment to gerrit's column requirement!

          Could we add some additional formatting / newlines to make the description easier to read (helps with git blames down the road)

          Yu He

          Sure.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Hidehiko Abe
          • Qikai Zhong
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
            Gerrit-Change-Number: 7672837
            Gerrit-PatchSet: 7
            Gerrit-Owner: Yu He <y...@microsoft.com>
            Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
            Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
            Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
            Gerrit-Reviewer: Yu He <y...@microsoft.com>
            Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
            Gerrit-CC: Kun Wang <kun...@microsoft.com>
            Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
            Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
            Gerrit-Comment-Date: Tue, 24 Mar 2026 01:34:01 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Tom Lukaszewicz <tl...@chromium.org>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Qikai Zhong (Gerrit)

            unread,
            Mar 23, 2026, 9:50:57 PM (12 days ago) Mar 23
            to Yu He, Hidehiko Abe, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
            Attention needed from Hidehiko Abe and Yu He

            Qikai Zhong voted and added 1 comment

            Votes added by Qikai Zhong

            Code-Review+1
            Commit-Queue+2

            1 comment

            Patchset-level comments
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Hidehiko Abe
            • Yu He
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement is not satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
              Gerrit-Change-Number: 7672837
              Gerrit-PatchSet: 8
              Gerrit-Owner: Yu He <y...@microsoft.com>
              Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
              Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
              Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
              Gerrit-Reviewer: Yu He <y...@microsoft.com>
              Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
              Gerrit-CC: Kun Wang <kun...@microsoft.com>
              Gerrit-Attention: Yu He <y...@microsoft.com>
              Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
              Gerrit-Comment-Date: Tue, 24 Mar 2026 01:50:46 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Qikai Zhong (Gerrit)

              unread,
              Mar 23, 2026, 9:51:31 PM (12 days ago) Mar 23
              to Yu He, Hidehiko Abe, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
              Attention needed from Hidehiko Abe, Qikai Zhong and Yu He

              Qikai Zhong voted and added 1 comment

              Votes added by Qikai Zhong

              Commit-Queue+1

              1 comment

              Patchset-level comments
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Hidehiko Abe
              • Qikai Zhong
              • Yu He
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement is not satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
              Gerrit-Change-Number: 7672837
              Gerrit-PatchSet: 8
              Gerrit-Owner: Yu He <y...@microsoft.com>
              Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
              Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
              Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
              Gerrit-Reviewer: Yu He <y...@microsoft.com>
              Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
              Gerrit-CC: Kun Wang <kun...@microsoft.com>
              Gerrit-Attention: Yu He <y...@microsoft.com>
              Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
              Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
              Gerrit-Comment-Date: Tue, 24 Mar 2026 01:51:21 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Hidehiko Abe (Gerrit)

              unread,
              Mar 24, 2026, 1:48:43 AM (12 days ago) Mar 24
              to Yu He, Qikai Zhong, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org
              Attention needed from Qikai Zhong and Yu He

              Hidehiko Abe voted

              Code-Review+1
              Commit-Queue+2
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Qikai Zhong
              • Yu He
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
              Gerrit-Change-Number: 7672837
              Gerrit-PatchSet: 8
              Gerrit-Owner: Yu He <y...@microsoft.com>
              Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
              Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
              Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
              Gerrit-Reviewer: Yu He <y...@microsoft.com>
              Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
              Gerrit-CC: Kun Wang <kun...@microsoft.com>
              Gerrit-Attention: Yu He <y...@microsoft.com>
              Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
              Gerrit-Comment-Date: Tue, 24 Mar 2026 05:48:28 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Chromium LUCI CQ (Gerrit)

              unread,
              Mar 24, 2026, 1:58:40 AM (12 days ago) Mar 24
              to Yu He, Hidehiko Abe, Qikai Zhong, Tom Lukaszewicz, Kun Wang, Kevin DiClemente, chromium...@chromium.org, armalhotra+a...@google.com, ayman...@chromium.org, chrome-gr...@chromium.org, grt+...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, yuezhang...@chromium.org

              Chromium LUCI CQ submitted the change

              Change information

              Commit message:
              [bedrock] FindBrowserWithActiveWindow() function call point refactoring

              This CL updates 9 files across various Chrome browser components to
              transition from the concrete Browser class to the BrowserWindowInterface
              abstraction. This is part of the ongoing Bedrock effort to improve
              modularity and testability by decoupling UI components from the
              monolithic Browser type.

              Key Changes:
              - Updated FindBrowserWithActiveWindow() to return BrowserWindowInterface* instead of Browser*.
              - Replaced direct Browser member access with interface-compatible methods:
                * browser->tab_strip_model() -> browser->GetTabStripModel()
                * browser->profile() -> browser->GetProfile()
                * browser->is_type_normal() ->
                  browser->GetType() == BrowserWindowInterface::Type::TYPE_NORMAL
                * NavigateToUrl(browser, url) -> browser->OpenGURL(url, disposition)
              - Updated #include directives to add browser_window_interface.h and
                pruned unnecessary includes like browser_list.h and browser_window.h.
              - Added //chrome/browser/ui/browser_window dependency to the
                new_window target in BUILD.gn.

              Impacted Components:
              - Tab lifecycle management
              - New window client
              - Autofill payments bubble controllers
              - History menu
              - Relaunch notification
              - Shopping UI
              Bug: 494010890
              Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
              Reviewed-by: Qikai Zhong <qikai...@microsoft.com>
              Commit-Queue: Hidehiko Abe <hide...@chromium.org>
              Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
              Reviewed-by: Hidehiko Abe <hide...@chromium.org>
              Auto-Submit: Yu He <y...@microsoft.com>
              Cr-Commit-Position: refs/heads/main@{#1603904}
              Files:
              • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
              • M chrome/browser/ui/ash/new_window/BUILD.gn
              • M chrome/browser/ui/ash/new_window/DEPS
              • M chrome/browser/ui/ash/new_window/chrome_new_window_client.cc
              • M chrome/browser/ui/autofill/payments/BUILD.gn
              • M chrome/browser/ui/autofill/payments/filled_card_information_bubble_controller_impl.cc
              • M chrome/browser/ui/autofill/payments/offer_notification_bubble_controller_impl.cc
              • M chrome/browser/ui/autofill/payments/virtual_card_enroll_bubble_controller_impl.cc
              • M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm
              • M chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_desktop.cc
              • M chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate.cc
              Change size: M
              Delta: 11 files changed, 42 insertions(+), 31 deletions(-)
              Branch: refs/heads/main
              Submit Requirements:
              • requirement satisfiedCode-Review: +1 by Tom Lukaszewicz, +1 by Hidehiko Abe, +1 by Qikai Zhong
              Open in Gerrit
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: merged
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I82a1fa538609fab200ee5bb30eeda47b94d82be9
              Gerrit-Change-Number: 7672837
              Gerrit-PatchSet: 9
              Gerrit-Owner: Yu He <y...@microsoft.com>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
              Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
              Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
              Gerrit-Reviewer: Yu He <y...@microsoft.com>
              open
              diffy
              satisfied_requirement
              Reply all
              Reply to author
              Forward
              0 new messages