Add feature flag to disable tab discarding [chromium/src : main]
0 views
Skip to first unread message
Alex Attar (Gerrit)
Feb 17, 2026, 2:07:42 PM (3 days ago) Feb 17
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org
Attention needed from Joe Mason
Alex Attar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Feb 17, 2026, 4:42:53 PM (3 days ago) Feb 17
to Alex Attar, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org
Attention needed from Alex Attar
Joe Mason added 1 comment![]( "Open in Gerrit")
File chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
Line 309, Patchset 2 (Latest):
if (base::FeatureList::IsEnabled(Joe Mason . unresolved
We need to ignore this flag if `reason` is EXTERNAL, because then the discard's requested by an extension and ignoring it will break the extension functionality.
We might also want to ignore the flag if `reason` is FROZEN_WITH_GROWING_MEMORY, because that means the tab's already frozen but keeps allocating memory, probably because incoming Mojo messages are building up without being processed. We discard the tab as a fallback to make sure it doesn't use too much memory.
Related details
Attention is currently required from:
- Alex Attar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Attar (Gerrit)
Feb 18, 2026, 10:46:15 AM (2 days ago) Feb 18
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org
Attention needed from Joe Mason
Alex Attar added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
We need to ignore this flag if `reason` is EXTERNAL, because then the discard's requested by an extension and ignoring it will break the extension functionality.
We might also want to ignore the flag if `reason` is FROZEN_WITH_GROWING_MEMORY, because that means the tab's already frozen but keeps allocating memory, probably because incoming Mojo messages are building up without being processed. We discard the tab as a fallback to make sure it doesn't use too much memory.
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Feb 18, 2026, 4:18:43 PM (2 days ago) Feb 18
to Alex Attar, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org
Attention needed from Alex Attar
Joe Mason voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Attar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Attar (Gerrit)
Feb 19, 2026, 9:50:54 AM (yesterday) Feb 19
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org
Alex Attar voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 9:53:46 AM (yesterday) Feb 19
to Alex Attar, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add feature flag to disable tab discarding
Introduces the `kDisableTabDiscarding` feature flag in the performance
manager.
When enabled, this flag causes `TabLifecycleUnit::Discard` to abort
early, preventing the browser from proactively discarding tabs to save
memory. This allows for measuring the impact of tab discarding on memory
usage and user experience compared to other optimization strategies.
Change-Id: I5a00e44fb8b60351d9ad14a24ad3ded68fcc9be8
Reviewed-by: Joe Mason <joenot...@google.com>
Commit-Queue: Alex Attar <aat...@google.com>
Cr-Commit-Position: refs/heads/main@{#1587082}
Files:
- M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
- M components/performance_manager/features.cc
- M components/performance_manager/public/features.h
Change size: S
Delta: 3 files changed, 23 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Mason
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages