[bedrock] Use GetWindow()->Show()/ShowInactive() in chrome/ [chromium/src : main]

0 views
Skip to first unread message

Neil Bao (Gerrit)

unread,
Jun 8, 2026, 8:47:10 PMJun 8
to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, aixba+wat...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, ydago...@chromium.org, zelin+watch-we...@chromium.org

Neil Bao voted and added 1 comment

Votes added by Neil Bao

Auto-Submit+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Neil Bao . resolved

Please take a look.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c31cd749d664ba543dee7201c234d2cb1b5abca
Gerrit-Change-Number: 7903004
Gerrit-PatchSet: 1
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 00:46:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Neil Bao (Gerrit)

unread,
Jun 8, 2026, 9:16:02 PMJun 8
to Thomas Lukaszewicz, Qikai Zhong, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, aixba+wat...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong and Thomas Lukaszewicz

Neil Bao voted and added 1 comment

Votes added by Neil Bao

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Neil Bao . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c31cd749d664ba543dee7201c234d2cb1b5abca
Gerrit-Change-Number: 7903004
Gerrit-PatchSet: 1
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 01:15:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
Jun 8, 2026, 9:32:41 PMJun 8
to Neil Bao, Qikai Zhong, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, aixba+wat...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Neil Bao and Qikai Zhong

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
Thomas Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
  • Qikai Zhong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c31cd749d664ba543dee7201c234d2cb1b5abca
Gerrit-Change-Number: 7903004
Gerrit-PatchSet: 1
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Neil Bao <nei...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 01:32:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Qikai Zhong (Gerrit)

unread,
Jun 8, 2026, 10:17:52 PMJun 8
to Neil Bao, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, aixba+wat...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Neil Bao

Qikai Zhong voted and added 1 comment

Votes added by Qikai Zhong

Code-Review+1

1 comment

Patchset-level comments
Qikai Zhong . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c31cd749d664ba543dee7201c234d2cb1b5abca
    Gerrit-Change-Number: 7903004
    Gerrit-PatchSet: 1
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Neil Bao <nei...@microsoft.com>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 02:17:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 8, 2026, 10:55:22 PMJun 8
    to Neil Bao, Qikai Zhong, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, aixba+wat...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, ydago...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bedrock] Use GetWindow()->Show()/ShowInactive() in chrome/

    Phase 1 (cont.): replace browser->window()->Show() and
    browser->window()->ShowInactive() with browser->GetWindow()->Show() /
    ShowInactive() across chrome/.

    Step toward eliminating Browser::window(). GetWindow() returns
    ui::BaseWindow*, which is sufficient for Show()/ShowInactive() callers.
    No behavior change.
    Bug: 496674143
    Change-Id: I7c31cd749d664ba543dee7201c234d2cb1b5abca
    Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
    Reviewed-by: Qikai Zhong <qikai...@microsoft.com>
    Commit-Queue: Neil Bao <nei...@microsoft.com>
    Auto-Submit: Neil Bao <nei...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1643637}
    Files:
    • M chrome/browser/actor/tools/load_and_extract_content_tool_browsertest.cc
    • M chrome/browser/app_controller_mac_browsertest.mm
    • M chrome/browser/apps/app_service/launch_utils.cc
    • M chrome/browser/apps/app_service/metrics/website_metrics_browser_test_mixin.cc
    • M chrome/browser/apps/app_service/metrics/website_metrics_browsertest.cc
    • M chrome/browser/apps/app_shim/app_shim_manager_mac.cc
    • M chrome/browser/apps/platform_apps/platform_app_launch.cc
    • M chrome/browser/ash/app_mode/kiosk_guest_view_browsertest.cc
    • M chrome/browser/ash/app_mode/test/kiosk_test_utils.cc
    • M chrome/browser/ash/app_mode/test/new_windows_in_kiosk_allowed_browsertest.cc
    • M chrome/browser/ash/app_restore/full_restore_app_launch_handler_browsertest.cc
    • M chrome/browser/ash/boca/on_task/on_task_locked_session_navigation_throttle_interactive_ui_test.cc
    • M chrome/browser/ash/boca/on_task/on_task_system_web_app_manager_impl.cc
    • M chrome/browser/ash/browser_delegate/browser_delegate_impl.cc
    • M chrome/browser/chromeos/app_mode/kiosk_browser_window_handler.cc
    • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_access_control_browsertest.cc
    • M chrome/browser/extensions/api/identity/web_auth_flow.cc
    • M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_browsertest.cc
    • M chrome/browser/glic/glic_context_menu_browsertest.cc
    • M chrome/browser/glic/host/guest_util_browsertest.cc
    • M chrome/browser/mac/auth_session_request.mm
    • M chrome/browser/media/webrtc/capture_handle_app_window_browsertest.cc
    • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
    • M chrome/browser/sessions/better_session_restore_browsertest.cc
    • M chrome/browser/sessions/session_restore.cc
    • M chrome/browser/sessions/session_restore_browsertest.cc
    • M chrome/browser/sync/test/integration/sync_test.cc
    • M chrome/browser/ui/ash/desks/desks_client_browsertest.cc
    • M chrome/browser/ui/ash/desks/desks_templates_app_launch_handler.cc
    • M chrome/browser/ui/ash/new_window/chrome_new_window_client_browsertest.cc
    • M chrome/browser/ui/ash/shelf/app_service/app_service_app_window_browsertest.cc
    • M chrome/browser/ui/ash/shelf/browser_shortcut_shelf_item_controller_browsertest.cc
    • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_browsertest.cc
    • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_unittest.cc
    • M chrome/browser/ui/browser_finder_chromeos_browsertest.cc
    • M chrome/browser/ui/browser_focus_interactive_uitest.cc
    • M chrome/browser/ui/browser_window/public/browser_window_interface_iterator_browsertest.cc
    • M chrome/browser/ui/cocoa/applescript/window_applescript.mm
    • M chrome/browser/ui/extensions/application_launch.cc
    • M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
    • M chrome/browser/ui/passwords/manage_passwords_test.cc
    • M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
    • M chrome/browser/ui/startup/startup_browser_creator_impl.cc
    • M chrome/browser/ui/tabs/existing_tab_group_sub_menu_model_browsertest.cc
    • M chrome/browser/ui/views/extensions/security_dialog_tracker_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_native_widget_aura_linux_interactive_uitest.cc
    • M chrome/browser/ui/views/frame/browser_view_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_view_focus_uitest.cc
    • M chrome/browser/ui/views/frame/browser_view_unittest.cc
    • M chrome/browser/ui/views/frame/immersive_mode_controller_chromeos_browsertest.cc
    • M chrome/browser/ui/views/frame/immersive_mode_controller_chromeos_unittest.cc
    • M chrome/browser/ui/views/occlusion_visibility_interactive_uitest.cc
    • M chrome/browser/ui/views/permissions/permission_prompt_base_view_browsertest.cc
    • M chrome/browser/ui/views/profiles/dice_web_signin_interception_bubble_view_browsertest.cc
    • M chrome/browser/ui/views/profiles/profile_menu_view_browsertest.cc
    • M chrome/browser/ui/views/tabs/dragging/tab_drag_controller.cc
    • M chrome/browser/ui/views/tabs/dragging/tab_drag_controller_interactive_uitest.cc
    • M chrome/browser/ui/views/tabs/vertical/vertical_tab_strip_link_drag_browsertest.cc
    • M chrome/browser/ui/views/toolbar/pinned_toolbar_actions_container_browsertest.cc
    • M chrome/browser/ui/waap/initial_webui_browsertest.cc
    • M chrome/browser/ui/web_applications/test/system_web_app_interactive_uitest.cc
    • M chrome/browser/ui/web_applications/web_app_browsertest.cc
    • M chrome/browser/ui/webauthn/authenticator_request_window.cc
    • M chrome/browser/ui/webui_browser/webui_browser_browsertest.cc
    • M chrome/browser/webauthn/enclave_authenticator_browsertest.cc
    • M chrome/test/base/ash/util/ash_test_util.cc
    • M chrome/test/base/in_process_browser_test.cc
    Change size: M
    Delta: 68 files changed, 100 insertions(+), 100 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Thomas Lukaszewicz, +1 by Qikai Zhong
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c31cd749d664ba543dee7201c234d2cb1b5abca
    Gerrit-Change-Number: 7903004
    Gerrit-PatchSet: 2
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages