Fix various IWYU errors related to base/logging.h [chromium/src : main]

0 views

Skip to first unread message

Daniel Cheng (Gerrit)

unread,

Apr 4, 2026, 11:15:41 AMApr 4

to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mathias Bynens, Mike Taylor, Hu, Ningxin, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, Sarah Krakowiak, James Su, Victor Tan, Ian Vollick, Lin, Wanming, cblume...@chromium.org, penghuan...@chromium.org, abigailbk...@google.com, aixba+wat...@chromium.org, ajayramamurth...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, cros-print...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hayato...@chromium.org, headless...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jatapiaro+wat...@google.com, jbauma...@chromium.org, jdeblas...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, martijn...@martijnc.be, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rsleev...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, tgupta...@chromium.org, thiabaud+watch-d...@google.com, titoua...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, trewin...@google.com, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Takuto Ikuta (Gerrit)

unread,

Apr 5, 2026, 9:58:08 PMApr 5

to Daniel Cheng, Takuto Ikuta, Zijie He, Lei Zhang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mathias Bynens, Mike Taylor, Hu, Ningxin, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, Sarah Krakowiak, James Su, Victor Tan, Ian Vollick, Lin, Wanming, halliwe...@chromium.org, fuchsia...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, abigailbk...@google.com, aixba+wat...@chromium.org, ajayramamurth...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, cros-print...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hayato...@chromium.org, headless...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jatapiaro+wat...@google.com, jbauma...@chromium.org, jdeblas...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, martijn...@martijnc.be, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rsleev...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, tgupta...@chromium.org, thiabaud+watch-d...@google.com, titoua...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, trewin...@google.com, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Daniel Cheng and Lei Zhang

Takuto Ikuta voted and added 2 comments

Votes added by Takuto Ikuta

Code-Review	+1
Owners-Override	+1

2 comments

File chrome/browser/web_applications/test/debug_info_printer.cc

Line 19, Patchset 8 (Parent):

Takuto Ikuta . unresolved

Better to keep this empty line?

File chrome/browser/web_applications/test/os_integration_test_override_impl.cc

Line 49, Patchset 8 (Parent):

Takuto Ikuta . unresolved

Same and for other files.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Apr 5, 2026, 10:48:48 PMApr 5

Attention needed from Lei Zhang

Daniel Cheng added 2 comments

File chrome/browser/web_applications/test/debug_info_printer.cc

Line 19, Patchset 8 (Parent):

Takuto Ikuta . resolved

Better to keep this empty line?

Daniel Cheng

I think so too... but this is from `git cl format`. I will followup on chat to consider possible options here.

File chrome/browser/web_applications/test/os_integration_test_override_impl.cc

Line 49, Patchset 8 (Parent):

Takuto Ikuta . resolved

Same and for other files.

Daniel Cheng

Also git cl format.

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Apr 6, 2026, 11:12:36 AMApr 6

Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+2

Commit-Queue

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 6, 2026, 11:25:12 AMApr 6

to Daniel Cheng, Takuto Ikuta, Zijie He, Lei Zhang, AyeAye, Akihiro Ota, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mathias Bynens, Mike Taylor, Hu, Ningxin, Permissions Reviews, Peter Beverloo, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, Sarah Krakowiak, James Su, Victor Tan, Ian Vollick, Lin, Wanming, halliwe...@chromium.org, fuchsia...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, abigailbk...@google.com, aixba+wat...@chromium.org, ajayramamurth...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, cros-print...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hayato...@chromium.org, headless...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jatapiaro+wat...@google.com, jbauma...@chromium.org, jdeblas...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, martijn...@martijnc.be, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rsleev...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, tgupta...@chromium.org, thiabaud+watch-d...@google.com, titoua...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, trewin...@google.com, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Fix various IWYU errors related to base/logging.h

A followup CL removes base/logging.h from validation_errors.h, which
reveals a lot of pre-existing IWYU violations of base/logging.h and/or
headers included from base/logging.h.

CL largely generated by gemini-cli, using an iterative process and a
script to add the most appropriate includes to source files that failed
to build. Manual fixups for additional issues found via the trybots.

Bug: 499476145

Change-Id: I0c06e20742765161d6a94ba1daae60cbc89a3982

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7730403

Reviewed-by: Takuto Ikuta <tik...@chromium.org>

Owners-Override: Takuto Ikuta <tik...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1610307}

Files:

M android_webview/browser/aw_print_manager.cc
M android_webview/browser/gfx/aw_draw_fn_impl.cc
M android_webview/browser/permission/permission_request_handler.cc
M cc/layers/render_surface_impl.cc
M cc/mojo_embedder/async_layer_tree_frame_sink.cc
M cc/mojo_embedder/viz_layer_context.cc
M cc/raster/one_copy_raster_buffer_provider.cc
M cc/raster/zero_copy_raster_buffer_provider.cc
M cc/slim/frame_sink_impl.cc
M cc/slim/layer_tree_impl.cc
M chrome/app_shim/app_shim_main_delegate.mm
M chrome/browser/accessibility/ax_main_node_annotator_controller.cc
M chrome/browser/accessibility/embedded_a11y_extension_loader.cc
M chrome/browser/ai/ai_language_model.cc
M chrome/browser/android/foreign_session_helper.cc
M chrome/browser/android/persisted_tab_data/language_persisted_tab_data_android.cc
M chrome/browser/android/tab_android_conversions.cc
M chrome/browser/android/vr/arcore_device/fake_arcore.cc
M chrome/browser/apps/app_shim/app_shim_host_bootstrap_mac.cc
M chrome/browser/apps/app_shim/app_shim_listener.mm
M chrome/browser/apps/app_shim/web_app_shim_manager_delegate_mac.cc
M chrome/browser/background/background_contents_service.cc
M chrome/browser/background/extensions/background_application_list_model.cc
M chrome/browser/chrome_browser_main_win.cc
M chrome/browser/component_updater/subresource_filter_component_installer.cc
M chrome/browser/context_sharing/tab_bottom_sheet/android/tab_bottom_sheet_bridge.cc
M chrome/browser/devtools/device/cast_device_provider.cc
M chrome/browser/dom_distiller/dom_distiller_service_factory.cc
M chrome/browser/enterprise/connectors/analysis/clipboard_request_handler.cc
M chrome/browser/enterprise/connectors/analysis/content_analysis_dialog_controller.cc
M chrome/browser/enterprise/connectors/analysis/content_analysis_dialog_delegate.cc
M chrome/browser/enterprise/connectors/analysis/page_print_request_handler.cc
M chrome/browser/extensions/activity_log/counting_policy.cc
M chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
M chrome/browser/extensions/api/cookies/cookies_helpers_unittest.cc
M chrome/browser/extensions/api/debugger/debugger_api.cc
M chrome/browser/extensions/api/extension_action/extension_action_api.cc
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc
M chrome/browser/extensions/api/mdns/mdns_api.cc
M chrome/browser/extensions/api/preference/preference_api.cc
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc
M chrome/browser/extensions/chrome_app_sorting.cc
M chrome/browser/extensions/chrome_app_sorting_unittest.cc
M chrome/browser/extensions/component_loader.cc
M chrome/browser/extensions/corrupted_extension_reinstaller.cc
M chrome/browser/extensions/extension_allowlist.cc
M chrome/browser/extensions/forced_extensions/assessment_assistant_tracker.cc
M chrome/browser/extensions/installed_loader.cc
M chrome/browser/extensions/launch_util.cc
M chrome/browser/external_protocol/external_protocol_handler.cc
M chrome/browser/geolocation/geolocation_permission_context_extensions.cc
M chrome/browser/glic/host/glic_region_capture_controller.cc
M chrome/browser/icon_transcoder/svg_icon_transcoder.cc
M chrome/browser/importer/external_process_importer_client.cc
M chrome/browser/indigo/indigo_agent_host.cc
M chrome/browser/indigo/indigo_image_replacement_manager.cc
M chrome/browser/media/cdm_document_service_impl.cc
M chrome/browser/media/prefs/capture_device_ranking.h
M chrome/browser/media/protected_media_identifier_permission_context.cc
M chrome/browser/media/router/mojo/media_router_debugger_impl.cc
M chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
M chrome/browser/media/router/providers/test/test_media_route_provider.cc
M chrome/browser/media/webrtc/webrtc_event_log_manager.cc
M chrome/browser/notifications/notification_channels_provider_android.cc
M chrome/browser/notifications/notifier_state_tracker.cc
M chrome/browser/performance_manager/policies/page_discarding_helper.cc
M chrome/browser/permissions/prediction_service/language_detection_observer.cc
M chrome/browser/permissions/prediction_service/passage_embedder_delegate.cc
M chrome/browser/permissions/prediction_service/prediction_model_handler_provider_factory.cc
M chrome/browser/policy/cloud/user_fm_registration_token_uploader.cc
M chrome/browser/profiles/pref_service_builder_utils.cc
M chrome/browser/profiling_host/profiling_process_host.cc
M chrome/browser/push_messaging/push_messaging_notification_manager.cc
M chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_util.cc
M chrome/browser/screen_ai/public/optical_character_recognizer.cc
M chrome/browser/screen_ai/screen_ai_service_handler_base.cc
M chrome/browser/shell_integration_win.cc
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util.cc
M chrome/browser/themes/browser_theme_pack.cc
M chrome/browser/themes/theme_syncable_service.cc
M chrome/browser/translate/android/translate_bridge.cc
M chrome/browser/ui/android/tab_model/tab_model.cc
M chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
M chrome/browser/ui/autofill/autofill_ai/entity_attribute_update_details.cc
M chrome/browser/ui/media_router/query_result_manager.cc
M chrome/browser/ui/sad_tab.cc
M chrome/browser/ui/tabs/tab_ukm_test_helper.cc
M chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
M chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
M chrome/browser/ui/views/menu_item_view_interactive_uitest.cc
M chrome/browser/ui/views/tabs/hovercard/tab_hover_card_bubble_view_unittest.cc
M chrome/browser/ui/views/user_education/impl/browser_user_education_interface_impl.cc
M chrome/browser/ui/webui/app_management/app_management_page_handler_base.cc
M chrome/browser/ui/webui/cr_components/history_embeddings/history_embeddings_handler.cc
M chrome/browser/ui/webui/customize_buttons/customize_buttons_handler.cc
M chrome/browser/ui/webui/history/foreign_session_handler.cc
M chrome/browser/ui/webui/media/webrtc_logs_ui.cc
M chrome/browser/ui/webui/metrics_reporter/metrics_reporter.cc
M chrome/browser/ui/webui/ntp/new_tab_ui.cc
M chrome/browser/ui/webui/settings/import_data_handler.cc
M chrome/browser/ui/webui/settings/settings_utils_linux.cc
M chrome/browser/ui/webui/settings/site_settings_helper.cc
M chrome/browser/ui/webui/side_panel/read_anything/read_anything_screenshotter.cc
M chrome/browser/ui/webui/side_panel/read_anything/read_anything_untrusted_page_handler.cc
M chrome/browser/ui/webui/theme_source.cc
M chrome/browser/vr/vr_browser_renderer_thread.cc
M chrome/browser/web_applications/os_integration/os_integration_manager.cc
M chrome/browser/web_applications/os_integration/web_app_file_handler_registration_linux.cc
M chrome/browser/web_applications/os_integration/web_app_handler_registration_utils_win.cc
M chrome/browser/web_applications/os_integration/web_app_shortcut_win.cc
M chrome/browser/web_applications/test/debug_info_printer.cc
M chrome/browser/web_applications/test/fake_web_app_database_factory.cc
M chrome/browser/web_applications/test/fake_web_app_ui_manager.cc
M chrome/browser/web_applications/test/os_integration_test_override_impl.cc
M chrome/browser/web_applications/test/web_app_test_observers.cc
M chrome/browser/webapps/installable/installed_webapp_geolocation_bridge.cc
M chrome/browser/webshare/prepare_directory_task.cc
M chrome/browser/webshare/share_service_impl.cc
M chrome/common/extensions/api/common_extension_api_unittest.cc
M chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
M chrome/common/extensions/manifest_handlers/app_launch_info.cc
M chrome/enterprise_companion/installer_posix.cc
M chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac.cc
M chrome/services/file_util/public/cpp/sandboxed_rar_analyzer.cc
M chrome/services/file_util/public/cpp/sandboxed_seven_zip_analyzer.cc
M chrome/services/file_util/public/cpp/sandboxed_zip_analyzer.cc
M chrome/services/printing/pdf_to_emf_converter.cc
M chrome/services/sharing/nearby/quick_start_decoder/quick_start_conversions.cc
M chrome/test/chromedriver/chrome/devtools_http_client.cc
M chrome/test/chromedriver/log_replay/replay_http_client.cc
M chrome/updater/app/server/update_service_internal_stub.cc
M chrome/updater/mac/keystone/ksadmin_unittest.cc
M chrome/utility/image_writer/image_writer.cc
M chromecast/media/service/video_geometry_setter_service.cc
M chromecast/mojo/remote_interfaces.cc
M codelabs/mojo_examples/02-associated-interface-freezing/renderer.cc
M codelabs/mojo_examples/03-channel-associated-interface-freezing/renderer.cc
M codelabs/mojo_examples/04-legacy-ipc-with-sepearate-remote/renderer.cc
M components/assist_ranker/assist_ranker_service_impl.cc
M components/assist_ranker/base_predictor.cc
M components/assist_ranker/binary_classifier_predictor.cc
M components/assist_ranker/classifier_predictor.cc
M components/assist_ranker/ranker_model_loader_impl.cc
M components/autofill/content/browser/content_autofill_driver.cc
M components/autofill/core/browser/crowdsourcing/randomized_encoder.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_component.cc
M components/autofill/core/browser/data_model/autofill_ai/entity_instance.cc
M components/autofill/core/browser/form_parsing/address_field_parser_ng.cc
M components/autofill/core/browser/form_parsing/name_field_parser_unittest.cc
M components/autofill/core/browser/foundations/form_forest_test_api.cc
M components/autofill/core/common/form_data.cc
M components/autofill/core/common/form_field_data.cc
M components/client_hints/browser/client_hints.cc
M components/content_settings/core/browser/content_settings_default_provider.cc
M components/data_sharing/internal/logger_impl.cc
M components/discardable_memory/service/discardable_shared_memory_manager.cc
M components/download/internal/background_service/controller_impl.cc
M components/embedder_support/origin_trials/origin_trials_settings_storage.cc
M components/enterprise/browser/reporting/real_time_report_controller.cc
M components/heap_profiling/multi_process/client_connection_manager.cc
M components/heap_profiling/multi_process/supervisor.cc
M components/history_embeddings/core/ml_answerer.cc
M components/input/gesture_event_queue.cc
M components/input/render_input_router.cc
M components/live_caption/views/caption_bubble_model.cc
M components/media_router/browser/logger_impl.cc
M components/mirroring/service/mirroring_logger.cc
M components/on_device_ai/ai_utils.cc
M components/on_load_script_injector/browser/on_load_script_injector_host.cc
M components/optimization_guide/content/browser/page_content_proto_util.cc
M components/optimization_guide/core/delivery/prediction_manager.cc
M components/optimization_guide/core/delivery/prediction_model_override.cc
M components/optimization_guide/core/model_execution/manifest_broker/manifest_broker_state.cc
M components/optimization_guide/core/model_execution/model_broker_state.cc
M components/optimization_guide/core/model_execution/on_device_model_classifier_controller.cc
M components/optimization_guide/core/model_execution/on_device_model_service_controller.cc
M components/page_content_annotations/content/page_content_screenshot_service.cc
M components/paint_preview/browser/paint_preview_client.cc
M components/paint_preview/common/paint_preview_tracker.cc
M components/paint_preview/player/android/javatests/paint_preview_test_service.cc
M components/paint_preview/player/android/player_compositor_delegate_android.cc
M components/paint_preview/player/player_compositor_delegate.cc
M components/passage_embeddings/core/passage_embedder_model_observer.cc
M components/passage_embeddings/core/passage_embeddings_service_controller.cc
M components/password_manager/core/browser/form_parsing/form_data_parser.cc
M components/password_manager/core/browser/form_parsing/form_data_parser_unittest.cc
M components/password_manager/core/browser/leak_detection/bulk_leak_check_service.cc
M components/policy/core/common/cloud/profile_cloud_policy_store_unittest.cc
M components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc
M components/printing/browser/headless/headless_print_manager.cc
M components/printing/browser/print_to_pdf/pdf_print_job.cc
M components/safe_browsing/android/remote_database_manager.cc
M components/safe_browsing/content/browser/threat_details_history.cc
M components/safe_browsing/core/browser/safe_browsing_url_checker_impl.cc
M components/segmentation_platform/internal/execution/processing/feature_processor_state.cc
M components/segmentation_platform/internal/segmentation_ukm_helper.cc
M components/send_tab_to_self/outgoing_tab_form_field_extractor.cc
M components/services/font/font_service_app.cc
M components/services/heap_profiling/public/cpp/settings.cc
M components/services/paint_preview_compositor/paint_preview_compositor_impl.cc
M components/services/paint_preview_compositor/paint_preview_compositor_impl_unittest.cc
M components/services/storage/dom_storage/storage_area_impl.cc
M components/services/storage/dom_storage/storage_area_impl_unittest.cc
M components/services/storage/dom_storage/test_support/dom_storage_database_testing.cc
M components/services/storage/shared_storage/shared_storage_database.cc
M components/spellcheck/browser/spellchecker_session_bridge_android.cc
M components/spellcheck/renderer/spellcheck_provider_hunspell_unittest.cc
M components/spellcheck/renderer/spellcheck_provider_unittest.cc
M components/spellcheck/renderer/spellcheck_unittest.cc
M components/subresource_filter/core/browser/async_document_subresource_filter.cc
M components/sync/engine/sync_manager_impl.cc
M components/sync/engine/syncer_unittest.cc
M components/translate/core/browser/translate_language_list.cc
M components/translate/core/browser/translate_prefs.cc
M components/translate/core/browser/translate_ranker_impl.cc
M components/ukm/app_source_url_recorder.cc
M components/url_rewrite/browser/url_request_rewrite_rules_validation.cc
M components/user_education/webui/help_bubble_handler.cc
M components/variations/service/variations_field_trial_creator.cc
M components/variations/variations_ids_provider.cc
M components/viz/host/host_display_client.cc
M components/viz/service/debugger/viz_debugger.cc
M components/viz/service/display/display.cc
M components/viz/service/display/overlay_dc_unittest.cc
M components/viz/service/display/readback_pixeltest.cc
M components/viz/service/display/software_renderer.cc
M components/viz/service/display_embedder/output_presenter_fuchsia.cc
M components/viz/service/display_embedder/output_presenter_gl.cc
M components/viz/service/display_embedder/skia_output_device_dawn.cc
M components/viz/service/display_embedder/skia_output_device_offscreen.cc
M components/viz/service/display_embedder/software_output_device_win.cc
M components/viz/service/frame_sinks/external_begin_frame_source_mac.cc
M components/viz/service/frame_sinks/frame_counter.cc
M components/viz/service/gl/gpu_log_message_manager.cc
M components/viz/service/main/viz_main_impl.cc
M components/web_package/web_bundle_parser.cc
M components/web_resource/resource_request_allowed_notifier.cc
M components/webxr/android/arcore_install_helper.cc
M components/webxr/android/cardboard_utils.cc
M components/webxr/android/xr_session_coordinator.cc
M content/browser/accessibility/browser_accessibility_state_impl_auralinux.cc
M content/browser/android/app_web_message_port.cc
M content/browser/device_posture/device_posture_registry_watcher_win.cc
M content/browser/devtools/devtools_frontend_host_impl.cc
M content/browser/devtools/devtools_stream_file.cc
M content/browser/download/download_request_utils.cc
M content/browser/indexed_db/indexed_db_leveldb_coding.cc
M content/browser/indexed_db/indexed_db_leveldb_coding_decodeidbkeypath_fuzzer.cc
M content/browser/media/capture/native_screen_capture_picker_mac.mm
M content/browser/media/cdm_storage_database.cc
M content/browser/media/cdm_storage_manager.cc
M content/browser/media/media_service.cc
M content/browser/notifications/notification_database.cc
M content/browser/preloading/prefetch/prefetch_params.cc
M content/browser/renderer_host/input/synthetic_gesture_target_base.cc
M content/browser/renderer_host/media/aec_dump_manager_impl.cc
M content/browser/renderer_host/randomized_confidence_utils_unittest.cc
M content/browser/renderer_host/text_input_manager.cc
M content/browser/tracing/tracing_controller_impl_data_endpoint.cc
M content/browser/web_contents_based_canceller.cc
M content/browser/webrtc/webrtc_internals_message_handler.cc
M content/browser/xr/service/xr_runtime_manager_impl.cc
M content/child/child_process_sandbox_support_impl_mac.cc
M content/child/runtime_features.cc
M content/common/content_switches_internal.cc
M content/public/browser/console_message.h
M content/public/browser/gpu_utils.cc
M content/public/browser/provision_fetcher_impl.cc
M content/public/browser/web_ui_controller_interface_binder.h
M content/public/test/web_ui_browsertest_util.cc
M content/renderer/discardable_memory_utils.cc
M content/renderer/mhtml_handle_writer.cc
M content/renderer/render_process_impl.cc
M content/test/fuzzer/fuzzer_support.cc
M device/bluetooth/adapter.cc
M device/bluetooth/advertisement.cc
M device/bluetooth/server_socket.cc
M device/bluetooth/socket.cc
M device/gamepad/gamepad_platform_data_fetcher_android.cc
M device/gamepad/raw_input_data_fetcher_win.cc
M device/gamepad/raw_input_gamepad_device_win.cc
M device/vr/android/arcore/arcore_anchor_manager.cc
M device/vr/android/arcore/arcore_impl.cc
M device/vr/android/arcore/arcore_plane_manager.cc
M device/vr/openxr/openxr_view_configuration.cc
M device/vr/orientation/orientation_device.cc
M device/vr/vr_device_base.cc
M device/vr/windows/d3d11_texture_helper.cc
M extensions/browser/api/content_settings/content_settings_store.cc
M extensions/browser/api/declarative_net_request/rules_monitor_service.cc
M extensions/browser/api/test/test_api.cc
M extensions/browser/convert_user_script.cc
M extensions/browser/extension_prefs.cc
M extensions/browser/extension_user_script_loader.cc
M extensions/browser/install_verifier.cc
M extensions/browser/requirements_checker_unittest.cc
M extensions/browser/updater/update_data_provider.cc
M extensions/common/api/declarative_net_request/dnr_manifest_unittest.cc
M extensions/common/extension.cc
M extensions/common/extension_builder.cc
M extensions/common/extension_set_unittest.cc
M extensions/common/extension_unittest.cc
M extensions/common/file_util_unittest.cc
M extensions/common/manifest_handlers/extension_action_handler_unittest.cc
M extensions/renderer/console.cc
M extensions/shell/browser/default_shell_browser_main_delegate.cc
M extensions/shell/browser/shell_speech_recognition_manager_delegate.cc
M gpu/command_buffer/client/client_shared_image.cc
M gpu/command_buffer/client/shared_image_interface.cc
M gpu/command_buffer/client/shared_image_pool.h
M gpu/command_buffer/service/shared_image/dawn_copy_strategy.cc
M gpu/command_buffer/service/shared_image/external_vk_image_backing_factory.cc
M gpu/command_buffer/service/shared_image/external_vk_image_dawn_representation.cc
M gpu/command_buffer/service/shared_image/external_vk_image_skia_representation.cc
M gpu/command_buffer/service/shared_image/shared_image_backing.cc
M gpu/config/gpu_preferences_unittest.cc
M ipc/ipc_cpu_perftest.cc
M media/capture/video/android/video_capture_device_android.cc
M media/capture/video/android/video_capture_device_factory_android.cc
M media/capture/video/apple/video_capture_device_apple_unittest.mm
M media/capture/video/apple/video_capture_device_avfoundation_unittest.mm
M media/capture/video/apple/video_capture_device_factory_apple.mm
M media/capture/video/apple/video_capture_device_factory_unittest.mm
M media/capture/video/blob_utils.cc
M media/capture/video/chromeos/camera_metadata_utils.cc
M media/capture/video/fake_video_capture_device.cc
M media/capture/video/fake_video_capture_device_factory.cc
M media/capture/video/linux/v4l2_capture_delegate.cc
M media/capture/video/linux/v4l2_capture_delegate_gpu_helper.cc
M media/capture/video/linux/v4l2_capture_delegate_unittest.cc
M media/capture/video/linux/video_capture_device_factory_v4l2.cc
M media/capture/video/linux/video_capture_device_factory_webrtc.cc
M media/capture/video/mappable_shared_image_utils.cc
M media/capture/video/video_capture_device_unittest.cc
M media/capture/video/win/video_capture_device_factory_win_unittest.cc
M media/capture/video/win/video_capture_device_utils_win.h
M media/capture/video/win/video_capture_device_win.cc
M media/gpu/android/codec_buffer_wait_coordinator.cc
M media/gpu/test/video_test_environment.cc
M media/midi/midi_manager_mac.cc
M media/midi/midi_manager_winrt.cc
M media/mojo/services/mojo_audio_input_stream.cc
M media/mojo/services/mojo_cdm_file_io.cc
M media/mojo/services/mojo_cdm_helper.cc
M media/mojo/services/mojo_provision_fetcher.cc
M mojo/public/tools/fuzzers/mojo_fuzzer_message_dump.cc
M pdf/pdfium/pdfium_on_demand_searchifier.cc
M pdf/pdfium/pdfium_searchify.cc
M printing/backend/print_backend_unittest.cc
M printing/backend/xps_utils_win.cc
M printing/common/metafile_utils.cc
M printing/test_printing_context.cc
M remoting/host/chromoting_host_services_client.cc
M remoting/host/chromoting_host_services_server.cc
M sandbox/policy/sandbox_type.cc
M services/audio/loopback_stream.cc
M services/audio/loopback_stream_unittest.cc
M services/data_decoder/image_decoder_impl_unittest.cc
M services/device/battery/battery_status_manager_linux_unittest.cc
M services/device/generic_sensor/platform_sensor.cc
M services/device/generic_sensor/platform_sensor_provider_linux.cc
M services/device/generic_sensor/platform_sensor_provider_win.cc
M services/device/generic_sensor/platform_sensor_reader_win.cc
M services/device/generic_sensor/platform_sensor_reader_winrt.cc
M services/device/geolocation/geolocation_impl.cc
M services/device/hid/input_service_linux.cc
M services/device/public/cpp/hid/hid_blocklist.cc
M services/device/public/cpp/hid/hid_collection.cc
M services/device/public/cpp/test/fake_usb_device.cc
M services/device/time_zone_monitor/time_zone_monitor_linux.cc
M services/device/usb/usb_descriptors.cc
M services/device/wake_lock/wake_lock.cc
M services/device/wake_lock/wake_lock_provider.cc
M services/metrics/public/cpp/delegating_ukm_recorder.cc
M services/network/network_sandbox_hook_linux.cc
M services/network/public/cpp/content_security_policy/csp_source_list.cc
M services/on_device_model/ml/constraint_factory.cc
M services/on_device_model/public/cpp/service_client.cc
M services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_linux.cc
M services/screen_ai/proto/main_content_extractor_proto_convertor_unittest.cc
M services/screen_ai/sandbox/screen_ai_sandbox_hook_linux.cc
M services/service_manager/tests/lifecycle/lifecycle_unittest.cc
M services/service_manager/tests/service_manager/embedder.cc
M services/shape_detection/barcode_detection_impl_mac_unittest.mm
M services/shape_detection/barcode_detection_provider_mac_unittest.mm
M services/shape_detection/face_detection_provider_impl.cc
M services/shape_detection/shape_detection_sandbox_hook.cc
M services/shape_detection/text_detection_impl.cc
M services/tracing/perfetto/perfetto_service.cc
M services/tracing/public/cpp/perfetto/java_heap_profiler/java_heap_profiler_android.cc
M services/tracing/public/cpp/perfetto/perfetto_config.cc
M services/tracing/public/cpp/perfetto/perfetto_traced_process.cc
M services/tracing/public/cpp/system_metrics_sampler.cc
M services/tracing/public/cpp/system_tracing_service.cc
M services/webnn/coreml/graph_builder_coreml.cc
M services/webnn/coreml/tensor_impl_coreml.mm
M services/webnn/tflite/graph_impl_litert.cc
M services/webnn/tflite/graph_impl_tflite.cc
M services/webnn/webnn_context_provider_impl.cc
M services/webnn/webnn_graph_impl.cc
M services/webnn/webnn_tensor_impl.cc
M storage/browser/blob/blob_data_builder.cc
M storage/browser/blob/blob_memory_controller.cc
M storage/browser/blob/blob_transport_strategy.cc
M storage/browser/file_system/file_system_url.cc
M storage/browser/file_system/sandbox_directory_database.cc
M storage/browser/quota/quota_database.cc
M storage/browser/quota/quota_manager_impl.cc
M storage/browser/quota/quota_temporary_storage_evictor.cc
M third_party/blink/common/indexeddb/indexeddb_key.cc
M third_party/blink/common/input/web_gesture_event.cc
M third_party/blink/renderer/platform/testing/video_frame_utils.cc
M ui/accessibility/ax_table_fuzzer.cc
M ui/accessibility/ax_tree_combiner.cc
M ui/accessibility/ax_tree_fuzzer.cc
M ui/accessibility/ax_tree_manager.cc
M ui/accessibility/platform/inspect/ax_event_recorder_auralinux.cc
M ui/aura/window_event_dispatcher_unittest.cc
M ui/compositor/layer.cc
M ui/display/linux/test/virtual_display_util_linux.cc
M ui/display/mac/test/virtual_display_util_mac.mm
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc
M ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc
M ui/events/ozone/evdev/input_device_factory_evdev.cc
M ui/events/ozone/evdev/input_device_opener_evdev.cc
M ui/events/ozone/evdev/microphone_mute_switch_event_converter_evdev_unittest.cc
M ui/events/ozone/evdev/pen_tablet_event_converter_evdev_unittest.cc
M ui/events/ozone/evdev/stylus_button_event_converter_evdev_unittest.cc
M ui/ozone/platform/wayland/host/wayland_cursor_shape.cc
M ui/ozone/platform/wayland/host/wayland_frame_manager.cc
M ui/ozone/platform/wayland/host/wayland_popup.cc
M ui/ozone/platform/wayland/host/wayland_subsurface.cc
M ui/ozone/platform/wayland/host/wayland_syncobj_timeline.cc
M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
M ui/ozone/platform/wayland/host/wayland_window.cc
M ui/ozone/platform/wayland/host/zwp_text_input_v3_unittest.cc
M ui/ozone/platform/wayland/ozone_platform_wayland.cc
M ui/ozone/platform/x11/ozone_platform_x11.cc
M ui/qt/qt_ui.cc
M ui/snapshot/snapshot_win.cc
M ui/views/bubble/bubble_dialog_delegate_view.cc
M ui/views/bubble/bubble_frame_view_unittest.cc
M ui/views/controls/editable_combobox/editable_combobox.cc
M ui/views/controls/textfield/textfield.cc
M ui/views/controls/textfield/textfield_model_unittest.cc
M ui/views/examples/button_example.cc
M ui/views/interaction/interaction_test_util_views.cc
M ui/views/view_unittest.cc
M ui/views/widget/desktop_aura/desktop_native_cursor_manager_win.cc
M ui/webui/tracked_element/tracked_element_handler.cc
M ui/wm/core/cursor_loader.cc

Change size: L

Delta: 453 files changed, 678 insertions(+), 18 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Takuto Ikuta

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages