[TabRendererData] Move discard tab data update to TabLifeCycleUnit [chromium/src : main]
0 views
Skip to first unread message
Eshwar Stalin (Gerrit)
Feb 26, 2026, 12:32:18 PMFeb 26
to Steven Luong, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Steven Luong
Eshwar Stalin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Steven Luong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Luong (Gerrit)
Feb 26, 2026, 12:33:22 PMFeb 26
to Eshwar Stalin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Steven Luong voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 26, 2026, 12:36:11 PMFeb 26
to Steven Luong, Eshwar Stalin, AyeAye, chromium...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[TabRendererData] Move discard tab data update to TabLifeCycleUnit
The BrowserTabStripController observes the TabStripModel and force the
tab data to update on discard. The tab data update actually happens
twice on discard if kWebContentsDiscard is enabled. This CL removes the
data update from the BrowserTabStripController and moves it to the
TabLifeCycleUnit instead to be consistent with the case where discard
preserves the web contents.
Bug: 447214891
Change-Id: If8d8288694ecf14a669cdd3aca60506800543556
Commit-Queue: Steven Luong <stl...@chromium.org>
Reviewed-by: Eshwar Stalin <est...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1590901}
Files:
- M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
- M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
- M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
Change size: S
Delta: 3 files changed, 8 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eshwar Stalin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages