Alexei Svitkine (Gerrit)

unread,

Mar 26, 2026, 1:03:30 PM (9 days ago) Mar 26

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from Colin Blundell

Alexei Svitkine voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Mar 26, 2026, 1:07:49 PM (9 days ago) Mar 26

to Alexei Svitkine, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from Alexei Svitkine

Colin Blundell voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Mar 26, 2026, 1:41:41 PM (9 days ago) Mar 26

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Alexei Svitkine voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Mar 26, 2026, 1:42:05 PM (9 days ago) Mar 26

to David Schinazi, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from Alexei Svitkine and David Schinazi

Alexei Svitkine voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
David Schinazi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Mar 26, 2026, 1:43:38 PM (9 days ago) Mar 26

to Matt Menke, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from Matt Menke

Alexei Svitkine voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Matt Menke

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Mar 26, 2026, 1:46:21 PM (9 days ago) Mar 26

to Will Harris, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from Will Harris

Alexei Svitkine added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Alexei Svitkine . resolved

+wfh for services/network/public/cpp/url_request_mojom_traits.cc

(sorry for other reviewers I accidentally added - now removed - since Gerrit wasn't giving me correct suggestions for this file)

Open in Gerrit

Related details

Attention is currently required from:

Will Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

mmenke (Gerrit)

unread,

Mar 26, 2026, 1:50:57 PM (9 days ago) Mar 26

to Alexei Svitkine, Will Harris, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from Alexei Svitkine and Will Harris

mmenke added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Alexei Svitkine . resolved

+wfh for services/network/public/cpp/url_request_mojom_traits.cc
(sorry for other reviewers I accidentally added - now removed - since Gerrit wasn't giving me correct suggestions for this file)

mmenke

No worries. Strangely, it is correctly suggesting chrome-ip...@google.com to me (which would then be replaced with one of the relevant owners once sent out for review - but I suspect you know that),

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Will Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Will Harris (Gerrit)

unread,

Mar 26, 2026, 1:51:56 PM (9 days ago) Mar 26

to Alexei Svitkine, Will Harris, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from Alexei Svitkine

Will Harris voted and added 1 comment

Votes added by Will Harris

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Will Harris . unresolved

lgtm services/network/public/cpp/url_request_mojom_traits.cc - nit: no BUG?

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Mar 26, 2026, 1:52:49 PM (9 days ago) Mar 26

to Will Harris, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Alexei Svitkine voted and added 1 comment

Votes added by Alexei Svitkine

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Will Harris . resolved

lgtm services/network/public/cpp/url_request_mojom_traits.cc - nit: no BUG?

Alexei Svitkine

Just a header cleanup, didn't feel like adding a bug...

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Mar 26, 2026, 1:55:09 PM (9 days ago) Mar 26

to Will Harris, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Attention needed from mmenke

Alexei Svitkine added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Alexei Svitkine . resolved

+wfh for services/network/public/cpp/url_request_mojom_traits.cc
(sorry for other reviewers I accidentally added - now removed - since Gerrit wasn't giving me correct suggestions for this file)

mmenke

No worries. Strangely, it is correctly suggesting chrome-ip...@google.com to me (which would then be replaced with one of the relevant owners once sent out for review - but I suspect you know that),

Alexei Svitkine

Odd. Here's what I was seeing: https://screenshot.googleplex.com/4t48AzCwbKau6cz
(internal screenshot)

(I had already previously filed a bug against Gerrit to improve the suggest owners UI which they've not been prioritizing... so not planning to file another.)

Open in Gerrit

Related details

Attention is currently required from:

mmenke

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 26, 2026, 1:55:37 PM (9 days ago) Mar 26

to Alexei Svitkine, Will Harris, Colin Blundell, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Cleanup: Remove histogram macros header includes in services

Bug: None

Change-Id: I8ff09c99f10cd74983ce480c727beb1ec0851452

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7700627

Commit-Queue: Alexei Svitkine <asvi...@chromium.org>

Auto-Submit: Alexei Svitkine <asvi...@chromium.org>

Reviewed-by: Colin Blundell <blun...@chromium.org>

Reviewed-by: Will Harris <w...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1605659}

Files:

M services/metrics/public/cpp/mojo_ukm_recorder.cc
M services/network/cors/preflight_cache.cc
M services/network/cors/preflight_controller.cc
M services/network/mdns_responder.cc
M services/network/network_qualities_pref_delegate.cc
M services/network/orb/orb_mimetypes.cc
M services/network/orb/orb_sniffers.cc
M services/network/public/cpp/is_potentially_trustworthy.cc
M services/network/public/cpp/url_request_mojom_traits.cc
M services/network/url_loader_factory.cc
M services/preferences/tracked/pref_hash_store_impl.cc
M services/preferences/tracked/tracked_split_preference.cc
M services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
M services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
M services/webnn/dml/graph_impl_dml.cc

Change size: S

Delta: 15 files changed, 3 insertions(+), 15 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Will Harris, +1 by Colin Blundell

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

mmenke (Gerrit)

unread,

Mar 26, 2026, 2:03:08 PM (9 days ago) Mar 26

to Chromium LUCI CQ, Alexei Svitkine, Will Harris, Colin Blundell, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, chrome-gr...@chromium.org, network-ser...@chromium.org

mmenke added 1 comment

Patchset-level comments

File-level comment, Patchset 4:

Alexei Svitkine . resolved

+wfh for services/network/public/cpp/url_request_mojom_traits.cc
(sorry for other reviewers I accidentally added - now removed - since Gerrit wasn't giving me correct suggestions for this file)

mmenke

No worries. Strangely, it is correctly suggesting chrome-ip...@google.com to me (which would then be replaced with one of the relevant owners once sent out for review - but I suspect you know that),

Alexei Svitkine

Odd. Here's what I was seeing: https://screenshot.googleplex.com/4t48AzCwbKau6cz
(internal screenshot)
(I had already previously filed a bug against Gerrit to improve the suggest owners UI which they've not been prioritizing... so not planning to file another.)

mmenke

Maybe an issue with the corp variant? Anyhow, I've found filing issues against gerrit or buganizer not to be productive, so not something I'd bother with, either.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Cleanup: Remove histogram macros header includes in services [chromium/src : main]

Alexei Svitkine (Gerrit)

Alexei Svitkine voted Auto-Submit+1

Related details

Colin Blundell (Gerrit)

Colin Blundell voted Code-Review+1

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine voted Commit-Queue+2

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine voted Commit-Queue+2

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine voted Commit-Queue+2

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine added 1 comment

Related details

mmenke (Gerrit)

mmenke added 1 comment

Related details

Will Harris (Gerrit)

Will Harris voted and added 1 comment

Votes added by Will Harris

1 comment

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine voted and added 1 comment

Votes added by Alexei Svitkine

1 comment

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine added 1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

mmenke (Gerrit)

mmenke added 1 comment

Related details