Extract clean leaf targets from //chrome/browser/ui:ui [chromium/src : main]

0 views
Skip to first unread message

Erik Chen (Gerrit)

unread,
Jun 16, 2026, 1:32:57 PM (8 days ago) Jun 16
to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromiumme...@microsoft.com, extension...@chromium.org, mac-r...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, stluon...@chromium.org, aixba+wat...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, philli...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Thomas Lukaszewicz

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
Gerrit-Change-Number: 7948401
Gerrit-PatchSet: 6
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Jun 2026 17:32:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Chen (Gerrit)

unread,
Jun 16, 2026, 1:33:31 PM (8 days ago) Jun 16
to Toni Barzic, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromiumme...@microsoft.com, extension...@chromium.org, mac-r...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, stluon...@chromium.org, aixba+wat...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, philli...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Thomas Lukaszewicz and Toni Barzic

Erik Chen added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Erik Chen . resolved

tbarzic: PTAL apps

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
  • Toni Barzic
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
Gerrit-Change-Number: 7948401
Gerrit-PatchSet: 6
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Toni Barzic <tba...@chromium.org>
Gerrit-Attention: Toni Barzic <tba...@chromium.org>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Jun 2026 17:33:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
Jun 16, 2026, 2:17:34 PM (8 days ago) Jun 16
to Erik Chen, Toni Barzic, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromiumme...@microsoft.com, extension...@chromium.org, mac-r...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, stluon...@chromium.org, aixba+wat...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, philli...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Erik Chen and Toni Barzic

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
Thomas Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
  • Toni Barzic
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
    Gerrit-Change-Number: 7948401
    Gerrit-PatchSet: 6
    Gerrit-Owner: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Toni Barzic <tba...@chromium.org>
    Gerrit-Attention: Erik Chen <erik...@chromium.org>
    Gerrit-Attention: Toni Barzic <tba...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Jun 2026 18:17:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Erik Chen (Gerrit)

    unread,
    Jun 16, 2026, 2:18:15 PM (8 days ago) Jun 16
    to Thomas Lukaszewicz, Toni Barzic, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromiumme...@microsoft.com, extension...@chromium.org, mac-r...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, stluon...@chromium.org, aixba+wat...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, philli...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Toni Barzic

    Erik Chen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Toni Barzic
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
    Gerrit-Change-Number: 7948401
    Gerrit-PatchSet: 6
    Gerrit-Owner: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Toni Barzic <tba...@chromium.org>
    Gerrit-Attention: Toni Barzic <tba...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Jun 2026 18:18:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Toni Barzic (Gerrit)

    unread,
    Jun 16, 2026, 3:25:57 PM (7 days ago) Jun 16
    to Erik Chen, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromiumme...@microsoft.com, extension...@chromium.org, mac-r...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, stluon...@chromium.org, aixba+wat...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, philli...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Erik Chen

    Toni Barzic voted and added 1 comment

    Votes added by Toni Barzic

    Code-Review+1

    1 comment

    Patchset-level comments
    Toni Barzic . resolved

    apps lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Erik Chen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
    Gerrit-Change-Number: 7948401
    Gerrit-PatchSet: 6
    Gerrit-Owner: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Toni Barzic <tba...@chromium.org>
    Gerrit-Attention: Erik Chen <erik...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Jun 2026 19:25:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Erik Chen (Gerrit)

    unread,
    Jun 16, 2026, 3:27:04 PM (7 days ago) Jun 16
    to Toni Barzic, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromiumme...@microsoft.com, extension...@chromium.org, mac-r...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, stluon...@chromium.org, aixba+wat...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, philli...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org

    Erik Chen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
    Gerrit-Change-Number: 7948401
    Gerrit-PatchSet: 6
    Gerrit-Owner: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Toni Barzic <tba...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Jun 2026 19:26:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 16, 2026, 3:32:03 PM (7 days ago) Jun 16
    to Erik Chen, Toni Barzic, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromiumme...@microsoft.com, extension...@chromium.org, mac-r...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, stluon...@chromium.org, aixba+wat...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, philli...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Extract clean leaf targets from //chrome/browser/ui:ui

    Carve seven self-contained components out of the //chrome/browser/ui:ui
    monolith into their own source_sets, each with explicit dependencies and
    no circular includes back into :ui:

      recently_audible_helper, simple_message_box_internal,
      incognito_allowed_url, browser_ui_prefs, browser_otr_state,
      browser_action_prefs_listener, focus_tab_after_navigation_helper

    Consumers (including :ui itself) now depend directly on the small
    targets instead of obtaining these headers transitively from the
    monolith. This shrinks :ui -- which is slated for removal -- and adds no
    allow_circular_includes_from entries.

    AGENT_GENERATED_CL
    Bug: 353332589
    Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
    Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
    Reviewed-by: Toni Barzic <tba...@chromium.org>
    Commit-Queue: Erik Chen <erik...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1647805}
    Files:
    • M apps/BUILD.gn
    • M chrome/browser/android/BUILD.gn
    • M chrome/browser/content_settings/BUILD.gn
    • M chrome/browser/extensions/BUILD.gn
    • M chrome/browser/media/BUILD.gn
    • M chrome/browser/metrics/BUILD.gn
    • M chrome/browser/picture_in_picture/BUILD.gn
    • M chrome/browser/prefs/BUILD.gn
    • M chrome/browser/resource_coordinator/BUILD.gn
    • M chrome/browser/tracing/BUILD.gn
    • M chrome/browser/ui/BUILD.gn
    • M chrome/browser/ui/bookmarks/BUILD.gn
    • M chrome/browser/ui/cocoa/BUILD.gn
    • M chrome/browser/ui/navigator/BUILD.gn
    • M chrome/browser/ui/profiles/BUILD.gn
    • M chrome/browser/ui/startup/BUILD.gn
    • M chrome/browser/ui/tabs/alert/BUILD.gn
    • M chrome/browser/ui/views/tabs/vertical/BUILD.gn
    • M chrome/browser/ui/webui/tab_search/BUILD.gn
    • M chrome/browser/upgrade_detector/BUILD.gn
    • M chrome/browser/web_applications/BUILD.gn
    • M chrome/test/BUILD.gn
    Change size: M
    Delta: 22 files changed, 144 insertions(+), 18 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Toni Barzic, +1 by Thomas Lukaszewicz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibfb6ed6096af2c4f844529716a2d86a85fb88d1f
    Gerrit-Change-Number: 7948401
    Gerrit-PatchSet: 7
    Gerrit-Owner: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Toni Barzic <tba...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages