base: add RandIntInclusive alias for RandInt [chromium/src : main]

0 views
Skip to first unread message

Elly FJ (Gerrit)

unread,
Jan 19, 2026, 4:27:03 PMJan 19
to Elly FJ, Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sean Maher, Thiabaud Engelbrecht, Victor Tan, Wang, Wei4, Xida Chen, AyeAye Python Dispatcher, abigailbk...@google.com, agriev...@chromium.org, aixba+wat...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-enterpris...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, hsuregan+wa...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, thefro...@chromium.org, torne...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Elly FJ added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Elly FJ . resolved

dcheng: please have a look? :)

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb64e5c2cee0d0dd3a6cf8e1c38ad6d1b3c5cddb
Gerrit-Change-Number: 7494488
Gerrit-PatchSet: 2
Gerrit-Owner: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 19 Jan 2026 21:26:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 20, 2026, 12:20:57 PMJan 20
to Elly FJ, Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sean Maher, Thiabaud Engelbrecht, Victor Tan, Wang, Wei4, Xida Chen, AyeAye Python Dispatcher, abigailbk...@google.com, agriev...@chromium.org, aixba+wat...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-enterpris...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, hsuregan+wa...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, thefro...@chromium.org, torne...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Elly FJ

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
Daniel Cheng . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Elly FJ
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Comment-Date: Tue, 20 Jan 2026 17:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Elly FJ (Gerrit)

unread,
Jan 20, 2026, 12:26:17 PMJan 20
to Elly FJ, Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sean Maher, Thiabaud Engelbrecht, Victor Tan, Wang, Wei4, Xida Chen, AyeAye Python Dispatcher, abigailbk...@google.com, agriev...@chromium.org, aixba+wat...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-enterpris...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, hsuregan+wa...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, thefro...@chromium.org, torne...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Elly FJ . resolved

thanks dcheng! -> cq :)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb64e5c2cee0d0dd3a6cf8e1c38ad6d1b3c5cddb
Gerrit-Change-Number: 7494488
Gerrit-PatchSet: 3
Gerrit-Comment-Date: Tue, 20 Jan 2026 17:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Elly FJ (Gerrit)

unread,
Jan 21, 2026, 11:10:35 AMJan 21
to Elly FJ, Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sean Maher, Thiabaud Engelbrecht, Victor Tan, Wang, Wei4, Xida Chen, AyeAye Python Dispatcher, abigailbk...@google.com, agriev...@chromium.org, aixba+wat...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-enterpris...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, hsuregan+wa...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, thefro...@chromium.org, torne...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Elly FJ voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Wed, 21 Jan 2026 16:10:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 21, 2026, 5:14:24 PMJan 21
to Elly FJ, Daniel Cheng, Akihiro Ota, Menard, Alexis, Arnaud Mandy, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sean Maher, Thiabaud Engelbrecht, Victor Tan, Wang, Wei4, Xida Chen, AyeAye Python Dispatcher, abigailbk...@google.com, agriev...@chromium.org, aixba+wat...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-enterpris...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, hsuregan+wa...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, scheduler-...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, thefro...@chromium.org, torne...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
base: add RandIntInclusive alias for RandInt

This name makes it clearer that the function includes both endpoints.

This change also bulk-rewrites all references from base::RandInt to
base::RandIntInclusive.
Bug: 40283703
Change-Id: Ieb64e5c2cee0d0dd3a6cf8e1c38ad6d1b3c5cddb
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Elly FJ <elly...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572569}
Files:
  • M android_webview/browser/tracing/aw_background_tracing_metrics_provider_unittest.cc
  • M ash/system/focus_mode/focus_mode_controller.cc
  • M ash/system/mahi/mahi_panel_view_unittest.cc
  • M ash/wallpaper/wallpaper_daily_refresh_scheduler.cc
  • M base/android/self_compaction_manager.cc
  • M base/containers/intrusive_heap_unittest.cc
  • M base/rand_util.cc
  • M base/rand_util.h
  • M base/substring_set_matcher/substring_set_matcher_perftest.cc
  • M base/task/common/checked_lock_unittest.cc
  • M cc/paint/paint_op_reader.cc
  • M chrome/browser/ash/file_system_provider/cloud_file_system.cc
  • M chrome/browser/ash/login/users/default_user_image/default_user_images.cc
  • M chrome/browser/ash/net/network_diagnostics/dns_latency_routine.cc
  • M chrome/browser/ash/net/network_diagnostics/network_diagnostics_util.cc
  • M chrome/browser/ash/policy/dlp/dialogs/files_policy_dialog_browsertest.cc
  • M chrome/browser/devtools/device/android_web_socket.cc
  • M chrome/browser/download/download_target_determiner.cc
  • M chrome/browser/extensions/cws_info_service.cc
  • M chrome/browser/intranet_redirect_detector.cc
  • M chrome/browser/media/wv_test_license_server_config.cc
  • M chrome/browser/navigation_predictor/navigation_predictor.cc
  • M chrome/browser/performance_manager/policies/background_tab_loading_policy_helpers_unittest.cc
  • M chrome/browser/profiles/profile_avatar_icon_util.cc
  • M chrome/browser/safe_browsing/chrome_password_protection_service.cc
  • M chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
  • M chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
  • M chrome/browser/ui/hats/trust_safety_sentiment_service.cc
  • M chrome/browser/ui/omnibox/chrome_omnibox_client.cc
  • M chrome/browser/ui/profiles/profile_colors_util.cc
  • M chrome/browser/ui/toolbar/chrome_labs/chrome_labs_utils.cc
  • M chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
  • M chrome/browser/updater/scheduler_impl.cc
  • M chrome/browser/web_applications/web_app_pref_guardrails_unittest.cc
  • M chrome/common/profiler/thread_profiler_platform_configuration.cc
  • M chrome/test/base/chromeos/crosier/test_accounts.cc
  • M chromecast/cast_core/grpc/grpc_server_streaming_test.cc
  • M chromecast/media/audio/rate_adjuster_unittest.cc
  • M chromeos/ash/components/memory/userspace_swap/userfaultfd_unittest.cc
  • M chromeos/ash/components/memory/userspace_swap/userspace_swap_unittest.cc
  • M components/autofill/core/browser/metrics/form_interactions_ukm_logger.cc
  • M components/autofill/core/browser/test_utils/autofill_test_utils.cc
  • M components/breadcrumbs/core/breadcrumbs_status.cc
  • M components/crash/core/app/crashpad_android.cc
  • M components/download/public/common/desktop/desktop_auto_resumption_handler.cc
  • M components/enterprise/obfuscation/core/utils_unittest.cc
  • M components/favicon/core/favicon_backend.cc
  • M components/feed/core/v2/persistent_key_value_store_impl.cc
  • M components/history/core/browser/history_backend.cc
  • M components/history/core/browser/history_database.cc
  • M components/history/core/browser/sync/delete_directive_handler.cc
  • M components/input/fling_controller_unittest.cc
  • M components/media_router/common/providers/cast/channel/cast_message_handler.cc
  • M components/metrics/demographics/user_demographics.cc
  • M components/metrics/entropy_state.cc
  • M components/metrics/structured/lib/key_data.cc
  • M components/optimization_guide/core/model_quality/model_quality_util.cc
  • M components/optimization_guide/core/noisy_metrics_recorder.cc
  • M components/page_load_metrics/browser/observers/ad_metrics/ads_page_load_metrics_observer.cc
  • M components/password_manager/core/browser/password_manager_metrics_util.cc
  • M components/performance_manager/freezing/freezing_policy.cc
  • M components/reporting/util/rate_limiter_leaky_bucket_unittest.cc
  • M components/reporting/util/rate_limiter_slide_window_unittest.cc
  • M components/reporting/util/rate_limiter_token_bucket_unittest.cc
  • M components/safe_browsing/content/browser/triggers/ad_sampler_trigger.cc
  • M components/safe_browsing/core/browser/db/v4_update_protocol_manager.cc
  • M components/safe_browsing/core/browser/hashprefix_realtime/ohttp_key_service.cc
  • M components/saved_tab_groups/test_support/saved_tab_group_test_utils.cc
  • M components/segmentation_platform/internal/database/ukm_metrics_table_unittest.cc
  • M components/segmentation_platform/internal/segmentation_ukm_helper.cc
  • M components/sync/engine/backoff_delay_provider.cc
  • M components/sync/engine/commit.cc
  • M components/sync_sessions/synced_session_tracker_unittest.cc
  • M components/variations/entropy_provider_unittest.cc
  • M components/visited_url_ranking/internal/visited_url_ranking_service_impl.cc
  • M components/viz/common/resources/peak_gpu_memory_tracker_util_unittest.cc
  • M components/web_package/web_bundle_parser_unittest.cc
  • M components/webauthn/core/browser/rate_limiter_slide_window_unittest.cc
  • M content/browser/accessibility/browser_accessibility_state_impl.cc
  • M content/browser/client_hints/client_hints.cc
  • M content/browser/gpu/gpu_data_manager_impl_private.cc
  • M content/browser/interest_group/interest_group_auction.cc
  • M content/browser/interest_group/interest_group_manager_impl.cc
  • M content/browser/interest_group/noiser_and_bucketer.cc
  • M content/browser/preloading/prefetch/prefetch_proxy_configurator.cc
  • M content/browser/renderer_host/back_forward_cache_impl.cc
  • M content/browser/webid/metrics.cc
  • M content/common/profiling_utils.cc
  • M content/public/test/browser_test_base.cc
  • M device/bluetooth/dbus/fake_bluetooth_device_client.cc
  • M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_client.cc
  • M gpu/command_buffer/service/service_font_manager.cc
  • M ipc/ipc_channel.cc
  • M media/base/audio_push_fifo_unittest.cc
  • M media/capture/content/animated_content_sampler_unittest.cc
  • M media/cast/logging/stats_event_subscriber_unittest.cc
  • M media/gpu/chromeos/image_processor_test.cc
  • M media/gpu/windows/d3d12_video_encode_av1_delegate_unittest.cc
  • M media/gpu/windows/d3d12_video_encode_delegate_unittest.cc
  • M mojo/core/trap_unittest.cc
  • M mojo/public/cpp/bindings/lib/test_random_mojo_delays.cc
  • M net/base/prioritized_task_runner_unittest.cc
  • M net/disk_cache/disk_cache_perftest.cc
  • M net/dns/dns_transaction_unittest.cc
  • M net/nqe/network_qualities_prefs_manager.cc
  • M net/socket/socket_test_util.cc
  • M net/socket/udp_socket_posix.cc
  • M remoting/base/rsa_key_pair.cc
  • M remoting/host/win/unprivileged_process_delegate.cc
  • M sandbox/win/src/interception.cc
  • M sandbox/win/src/process_mitigations.cc
  • M services/device/public/cpp/compute_pressure/cpu_pressure_converter.cc
  • M services/network/cors/preflight_cache.cc
  • M services/network/websocket_throttler.cc
  • M third_party/blink/common/mediastream/media_stream_mojom_traits_unittest.cc
  • M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_deserializer.cc
  • M third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc
  • M third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
  • M third_party/blink/renderer/core/timing/measure_memory/measure_memory_controller.cc
  • M third_party/blink/renderer/core/timing/navigation_id_generator.cc
  • M third_party/blink/renderer/core/timing/responsiveness_metrics.cc
  • M third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc
  • M third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc
  • M third_party/blink/renderer/modules/compute_pressure/change_rate_monitor.cc
  • M third_party/blink/renderer/modules/csspaint/paint_worklet.cc
  • M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client.cc
  • M third_party/blink/renderer/platform/disk_data_allocator_test.cc
  • M third_party/blink/renderer/platform/loader/web_url_request_util.cc
  • M third_party/blink/renderer/platform/network/network_state_notifier.h
  • M third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager.cc
  • M third_party/blink/renderer/platform/wtf/text/utf16_test.cc
  • M third_party/crashpad/crashpad/client/annotation_list_test.cc
  • M third_party/crashpad/crashpad/util/misc/random_string.cc
  • M third_party/crashpad/crashpad/util/net/http_multipart_builder.cc
  • M third_party/crashpad/crashpad/util/stream/base94_output_stream_test.cc
  • M third_party/crashpad/crashpad/util/stream/zlib_output_stream_test.cc
  • M ui/views/view_unittest.cc
Change size: L
Delta: 137 files changed, 278 insertions(+), 239 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb64e5c2cee0d0dd3a6cf8e1c38ad6d1b3c5cddb
Gerrit-Change-Number: 7494488
Gerrit-PatchSet: 4
Gerrit-Owner: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages