[bedrock] Add ui_test_utils::BrowserCreatedObserver [chromium/src : main]

0 views
Skip to first unread message

Tom Lukaszewicz (Gerrit)

unread,
Sep 15, 2025, 2:43:15 AMSep 15
to Dana Fried, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, longbowei+fe...@google.com, mac-r...@chromium.org, chrome-gr...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, ydago...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, kuragin+web-ap...@chromium.org, feature-me...@chromium.org, tbarzi...@chromium.org, philli...@chromium.org, ashleydp+fe...@google.com, webap...@microsoft.com, chromium-a...@chromium.org, zelin+watch-we...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, performance-m...@chromium.org, msrame...@chromium.org, yyhyyh+fee...@google.com, jdonnel...@chromium.org, dmurph+wat...@chromium.org, hidehik...@chromium.org, dullweb...@chromium.org, xiangdongkong+...@google.com, cambickel+fe...@google.com, nicolas...@chromium.org, wangdanny+fe...@google.com, yhanada+...@chromium.org, dibyapal+wa...@chromium.org, loyso...@chromium.org, chrome-waff...@google.com, mgiuca...@chromium.org, extension...@chromium.org, dmurph+watc...@chromium.org
Attention needed from Dana Fried

Tom Lukaszewicz added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tom Lukaszewicz . resolved

Dana ptal (sorry it's a little big but mostly mechanical)

Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9dc0680b85e12ac719b114b54d962b4cd751b97
Gerrit-Change-Number: 6947028
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 06:42:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dana Fried (Gerrit)

unread,
Sep 15, 2025, 10:28:01 AMSep 15
to Tom Lukaszewicz, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, longbowei+fe...@google.com, mac-r...@chromium.org, chrome-gr...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, ydago...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, kuragin+web-ap...@chromium.org, feature-me...@chromium.org, tbarzi...@chromium.org, philli...@chromium.org, ashleydp+fe...@google.com, webap...@microsoft.com, chromium-a...@chromium.org, zelin+watch-we...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, performance-m...@chromium.org, msrame...@chromium.org, yyhyyh+fee...@google.com, jdonnel...@chromium.org, dmurph+wat...@chromium.org, hidehik...@chromium.org, dullweb...@chromium.org, xiangdongkong+...@google.com, cambickel+fe...@google.com, nicolas...@chromium.org, wangdanny+fe...@google.com, yhanada+...@chromium.org, dibyapal+wa...@chromium.org, loyso...@chromium.org, chrome-waff...@google.com, mgiuca...@chromium.org, extension...@chromium.org, dmurph+watc...@chromium.org
Attention needed from Tom Lukaszewicz

Dana Fried added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Dana Fried . unresolved

Mac isn't compiling; not sure why.

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib9dc0680b85e12ac719b114b54d962b4cd751b97
    Gerrit-Change-Number: 6947028
    Gerrit-PatchSet: 7
    Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Sep 2025 14:27:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Lukaszewicz (Gerrit)

    unread,
    Sep 15, 2025, 2:54:43 PMSep 15
    to Dana Fried, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, longbowei+fe...@google.com, mac-r...@chromium.org, chrome-gr...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, ydago...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, kuragin+web-ap...@chromium.org, feature-me...@chromium.org, tbarzi...@chromium.org, philli...@chromium.org, ashleydp+fe...@google.com, webap...@microsoft.com, chromium-a...@chromium.org, zelin+watch-we...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, performance-m...@chromium.org, msrame...@chromium.org, yyhyyh+fee...@google.com, jdonnel...@chromium.org, dmurph+wat...@chromium.org, hidehik...@chromium.org, dullweb...@chromium.org, xiangdongkong+...@google.com, cambickel+fe...@google.com, nicolas...@chromium.org, wangdanny+fe...@google.com, yhanada+...@chromium.org, dibyapal+wa...@chromium.org, loyso...@chromium.org, chrome-waff...@google.com, mgiuca...@chromium.org, extension...@chromium.org, dmurph+watc...@chromium.org
    Attention needed from Dana Fried

    Tom Lukaszewicz voted and added 1 comment

    Votes added by Tom Lukaszewicz

    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 7:
    Dana Fried . resolved

    Mac isn't compiling; not sure why.

    Tom Lukaszewicz

    Made a bad patch on Mac I didn't catch building locally - should be fixed in latest patchset.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dana Fried
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib9dc0680b85e12ac719b114b54d962b4cd751b97
    Gerrit-Change-Number: 6947028
    Gerrit-PatchSet: 9
    Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Dana Fried <dfr...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Sep 2025 18:54:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Dana Fried <dfr...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dana Fried (Gerrit)

    unread,
    Sep 15, 2025, 3:40:11 PMSep 15
    to Tom Lukaszewicz, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, longbowei+fe...@google.com, mac-r...@chromium.org, chrome-gr...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, ydago...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, kuragin+web-ap...@chromium.org, feature-me...@chromium.org, tbarzi...@chromium.org, philli...@chromium.org, ashleydp+fe...@google.com, webap...@microsoft.com, chromium-a...@chromium.org, zelin+watch-we...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, performance-m...@chromium.org, msrame...@chromium.org, yyhyyh+fee...@google.com, jdonnel...@chromium.org, dmurph+wat...@chromium.org, hidehik...@chromium.org, dullweb...@chromium.org, xiangdongkong+...@google.com, cambickel+fe...@google.com, nicolas...@chromium.org, wangdanny+fe...@google.com, yhanada+...@chromium.org, dibyapal+wa...@chromium.org, loyso...@chromium.org, chrome-waff...@google.com, mgiuca...@chromium.org, extension...@chromium.org, dmurph+watc...@chromium.org
    Attention needed from Tom Lukaszewicz

    Dana Fried voted and added 1 comment

    Votes added by Dana Fried

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 9 (Latest):
    Dana Fried . unresolved

    I'd love to move away from BrowserList and to some other solution but I'm not sure that per-profile tracking of browsers would help in tests.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Lukaszewicz
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib9dc0680b85e12ac719b114b54d962b4cd751b97
    Gerrit-Change-Number: 6947028
    Gerrit-PatchSet: 9
    Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Sep 2025 19:40:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Lukaszewicz (Gerrit)

    unread,
    Sep 15, 2025, 6:30:56 PMSep 15
    to Dana Fried, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, longbowei+fe...@google.com, mac-r...@chromium.org, chrome-gr...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, ydago...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, kuragin+web-ap...@chromium.org, feature-me...@chromium.org, tbarzi...@chromium.org, philli...@chromium.org, ashleydp+fe...@google.com, webap...@microsoft.com, chromium-a...@chromium.org, zelin+watch-we...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, performance-m...@chromium.org, msrame...@chromium.org, yyhyyh+fee...@google.com, jdonnel...@chromium.org, dmurph+wat...@chromium.org, hidehik...@chromium.org, dullweb...@chromium.org, xiangdongkong+...@google.com, cambickel+fe...@google.com, nicolas...@chromium.org, wangdanny+fe...@google.com, yhanada+...@chromium.org, dibyapal+wa...@chromium.org, loyso...@chromium.org, chrome-waff...@google.com, mgiuca...@chromium.org, extension...@chromium.org, dmurph+watc...@chromium.org

    Tom Lukaszewicz voted and added 1 comment

    Votes added by Tom Lukaszewicz

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 9:
    Dana Fried . resolved

    I'd love to move away from BrowserList and to some other solution but I'm not sure that per-profile tracking of browsers would help in tests.

    Tom Lukaszewicz

    Yeah for sure, fwiw the next step in the bedrock workstream on our end is pairing down / eliminating the BrowserList API.

    There may be a better way to listen to browser events that comes out of this - and supporting both BrowserDestroyedObserver and BrowserCreatedObserver should also make it easier to at least switch out the underlying implementation for the existing clients.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib9dc0680b85e12ac719b114b54d962b4cd751b97
    Gerrit-Change-Number: 6947028
    Gerrit-PatchSet: 10
    Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Sep 2025 22:30:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Dana Fried <dfr...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 15, 2025, 6:34:18 PMSep 15
    to Tom Lukaszewicz, Dana Fried, AyeAye, chromium...@chromium.org, longbowei+fe...@google.com, mac-r...@chromium.org, chrome-gr...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, ydago...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, kuragin+web-ap...@chromium.org, feature-me...@chromium.org, tbarzi...@chromium.org, philli...@chromium.org, ashleydp+fe...@google.com, webap...@microsoft.com, chromium-a...@chromium.org, zelin+watch-we...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, performance-m...@chromium.org, msrame...@chromium.org, yyhyyh+fee...@google.com, jdonnel...@chromium.org, dmurph+wat...@chromium.org, hidehik...@chromium.org, dullweb...@chromium.org, xiangdongkong+...@google.com, cambickel+fe...@google.com, nicolas...@chromium.org, wangdanny+fe...@google.com, yhanada+...@chromium.org, dibyapal+wa...@chromium.org, loyso...@chromium.org, chrome-waff...@google.com, mgiuca...@chromium.org, extension...@chromium.org, dmurph+watc...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    9 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [bedrock] Add ui_test_utils::BrowserCreatedObserver

    This CL introduces BrowserCreatedObserver, which replaces
    BrowserChangeObserver with ChangeType::kAdded.

    This simplifies client code and eliminates the unnecessarily
    complicated BrowserChangeObserver, which would return dangling
    references to removed Browsers in BrowserChangeObserver::Wait().

    There are no intended behavior changes with this CL, simply a
    mechanical transition from BrowserChangeObserver to
    BrowserCreatedObserver.

    Specifically:
      - All instances of BrowserCreatedObserver named
        browser_created_observer
      - Constructor takes no params (previously always nullptr and
        ChangeType::kAdded)
      - Calls to Wait() unchanged in the conversion
    Bug: 431672609
    Change-Id: Ib9dc0680b85e12ac719b114b54d962b4cd751b97
    Reviewed-by: Dana Fried <dfr...@chromium.org>
    Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1515740}
    Files:
    • M chrome/browser/app_controller_mac_browsertest.mm
    • M chrome/browser/app_controller_mac_interactive_uitest.mm
    • M chrome/browser/apps/app_service/app_install/app_install_navigation_throttle_browsertest.cc
    • M chrome/browser/ash/app_list/app_list_client_impl_browsertest.cc
    • M chrome/browser/ash/app_list/app_service/app_service_app_item_browsertest.cc
    • M chrome/browser/ash/app_restore/informed_restore_browsertest.cc
    • M chrome/browser/ash/login/demo_mode/demo_session_browsertest.cc
    • M chrome/browser/ash/note_taking/note_taking_helper_browsertest.cc
    • M chrome/browser/ash/os_feedback/chrome_os_feedback_delegate_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/media_app/media_app_integration_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/settings_app_integration_browsertest.cc
    • M chrome/browser/browser_process_platform_part_ash_browsertest.cc
    • M chrome/browser/browsing_data/navigation_entry_remover_browsertest.cc
    • M chrome/browser/chromeos/tablet_mode/chrome_content_browser_client_tablet_mode_part_browsertest.cc
    • M chrome/browser/extensions/api/identity/identity_apitest.cc
    • M chrome/browser/extensions/api/identity/launch_web_auth_flow_delegate_ash_browsertest.cc
    • M chrome/browser/extensions/browsertest_util.cc
    • M chrome/browser/lifetime/browser_close_manager_browsertest.cc
    • M chrome/browser/performance_manager/background_tab_loading_policy_browsertest.cc
    • M chrome/browser/performance_manager/policies/page_discarding_helper_browsertest.cc
    • M chrome/browser/profiles/avatar_menu_browsertest.cc
    • M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
    • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
    • M chrome/browser/sessions/session_restore_browsertest.cc
    • M chrome/browser/sessions/session_restore_interactive_uitest.cc
    • M chrome/browser/signin/e2e_tests/live_sign_in_test.cc
    • M chrome/browser/signin/mirror_interactive_uitest.cc
    • M chrome/browser/ui/ash/arc/arc_open_url_delegate_impl_browsertest.cc
    • M chrome/browser/ui/ash/capture_mode/capture_mode_browsertest.cc
    • M chrome/browser/ui/ash/projector/projector_client_impl_browsertest.cc
    • M chrome/browser/ui/ash/projector/projector_navigation_throttle_browsertest.cc
    • M chrome/browser/ui/ash/shelf/app_service/web_app_shelf_browsertest.cc
    • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_browsertest.cc
    • M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
    • M chrome/browser/ui/browser_browsertest.cc
    • M chrome/browser/ui/browser_commands_browsertest.cc
    • M chrome/browser/ui/browser_tab_strip_model_delegate_browsertest.cc
    • M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
    • M chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • M chrome/browser/ui/settings_window_manager_browsertest_chromeos.cc
    • M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
    • M chrome/browser/ui/tabs/recent_tabs_sub_menu_model_browsertest.cc
    • M chrome/browser/ui/views/default_link_capturing_interactive_uitest.cc
    • M chrome/browser/ui/views/enable_link_capturing_infobar_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_frame_view_chromeos_browsertest.cc
    • M chrome/browser/ui/views/frame/system_menu_model_builder_browsertest_chromeos.cc
    • M chrome/browser/ui/views/intent_picker_bubble_view_browsertest.cc
    • M chrome/browser/ui/views/location_bar/custom_tab_bar_view_browsertest.cc
    • M chrome/browser/ui/views/location_bar/intent_chip_button_browsertest.cc
    • M chrome/browser/ui/views/profiles/profile_menu_view_ui_browsertest.cc
    • M chrome/browser/ui/views/tabs/tab_group_editor_bubble_view_browsertest.cc
    • M chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
    • M chrome/browser/ui/web_applications/launch_web_app_browsertest.cc
    • M chrome/browser/ui/web_applications/test/web_app_browsertest_util.cc
    • M chrome/browser/ui/web_applications/web_app_browsertest.cc
    • M chrome/browser/ui/web_applications/web_app_browsertest_base.cc
    • M chrome/browser/ui/web_applications/web_app_link_capturing_browsertest.cc
    • M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog_browsertest.cc
    • M chrome/browser/ui/webui/search_engine_choice/search_engine_choice_ui_browsertest.cc
    • M chrome/browser/ui/webui/webui_embedding_context_browsertest.cc
    • M chrome/browser/web_applications/commands/web_install_from_url_command_browsertest.cc
    • M chrome/browser/web_applications/navigation_capturing_browser_navigator_browsertest.cc
    • M chrome/browser/web_applications/web_app_automation_browsertest.cc
    • M chrome/browser/web_applications/web_app_link_capturing_parameterized_browsertest.cc
    • M chrome/browser/web_applications/web_app_navigation_capturing_browsertest_base.cc
    • M chrome/browser/web_applications/web_app_navigation_capturing_intent_picker_browsertest.cc
    • M chrome/browser/web_applications/web_app_scope_extensions_browsertest.cc
    • M chrome/browser/web_applications/web_install_browsertest.cc
    • M chrome/test/base/ui_test_utils.cc
    • M chrome/test/base/ui_test_utils.h
    Change size: L
    Delta: 70 files changed, 279 insertions(+), 431 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Dana Fried
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib9dc0680b85e12ac719b114b54d962b4cd751b97
    Gerrit-Change-Number: 6947028
    Gerrit-PatchSet: 11
    Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages